graal-node.js modifications of V8 API must be V8_EXPORTed (on macos).

Author: iamstolis

graal-nodejs/deps/v8/include/v8-function-callback.h

@@ -447,7 +447,7 @@ Isolate* ReturnValue<T>::GetIsolate() const {
 
 template <typename T>
 Local<Value> ReturnValue<T>::Get() const {
-  return internal::CorrectReturnValue<Local<Value>>(GetIsolate(), *value_);
+  return Local<Value>::New(GetIsolate(), internal::CorrectReturnValue(GetIsolate(), *value_));
 }
 
 template <typename T>

graal-nodejs/deps/v8/include/v8-internal.h

@@ -24,6 +24,7 @@ class Array;
 class Context;
 class Data;
 class Isolate;
+class Value;
 
 namespace internal {
 
@@ -1399,8 +1400,8 @@ class HandleHelper final {
 V8_EXPORT void VerifyHandleIsNonEmpty(bool is_empty);
 
 // graal-node.js extensions
-void SaveReturnValue(v8::Isolate* isolate, double value);
-template <typename T> T CorrectReturnValue(v8::Isolate* isolate, Address value);
+V8_EXPORT void SaveReturnValue(v8::Isolate* isolate, double value);
+V8_EXPORT v8::Value* CorrectReturnValue(v8::Isolate* isolate, Address value);
 
 }  // namespace internal
 }  // namespace v8

graal-nodejs/deps/v8/src/graal/graal_handle_content.h

@@ -63,7 +63,13 @@ typedef _jobject *jobject;
 #endif // BUILDING_V8_SHARED
 
 #else  // _WIN32
+
+#ifdef BUILDING_V8_SHARED
+# define V8_EXPORT __attribute__ ((visibility("default")))
+#else
 # define V8_EXPORT
+#endif // BUILDING_V8_SHARED
+
 #endif // _WIN32
 
 class V8_EXPORT GraalHandleContent {

graal-nodejs/deps/v8/src/graal/v8.cc

@@ -140,8 +140,8 @@ namespace v8 {
             reinterpret_cast<GraalIsolate*> (isolate)->SaveReturnValue(value);
         }
 
-        template<> v8::Local<v8::Value> CorrectReturnValue<v8::Local<v8::Value>>(v8::Isolate* isolate, v8::internal::Address value) {
-            return reinterpret_cast<GraalIsolate*> (isolate)->CorrectReturnValue(value);
+        v8::Value* CorrectReturnValue(v8::Isolate* isolate, v8::internal::Address value) {
+            return *(reinterpret_cast<GraalIsolate*> (isolate)->CorrectReturnValue(value));
         }
 
         namespace wasm {