v8::FunctionTemplate::SetClassName() should not set Symbol.toStringTag.

iamstolis · iamstolis · commit 5bec870c0795 · 2021-12-22T17:59:03.000+01:00
diff --git a/graal-nodejs/mx.graal-nodejs/com.oracle.truffle.trufflenode/src/com/oracle/truffle/trufflenode/GraalJSAccess.java b/graal-nodejs/mx.graal-nodejs/com.oracle.truffle.trufflenode/src/com/oracle/truffle/trufflenode/GraalJSAccess.java
@@ -1696,8 +1696,6 @@ public void functionTemplateInherit(Object templateObj, Object parent) {
     public void functionTemplateSetClassName(Object templateObj, Object name) {
         FunctionTemplate functionTemplate = (FunctionTemplate) templateObj;
         functionTemplate.setClassName((String) name);
-        ObjectTemplate instanceTemplate = functionTemplate.getInstanceTemplate();
-        instanceTemplate.addValue(new Value(Symbol.SYMBOL_TO_STRING_TAG, name, JSAttributes.configurableNotEnumerableNotWritable()));
     }
 
     public Object functionTemplateInstanceTemplate(Object templateObj) {

Original file line number	Diff line number	Diff line change
`@@ -1696,8 +1696,6 @@ public void functionTemplateInherit(Object templateObj, Object parent) {`
`1696`	`1696`	`public void functionTemplateSetClassName(Object templateObj, Object name) {`
`1697`	`1697`	`FunctionTemplate functionTemplate = (FunctionTemplate) templateObj;`
`1698`	`1698`	`functionTemplate.setClassName((String) name);`
`1699`		`- ObjectTemplate instanceTemplate = functionTemplate.getInstanceTemplate();`
`1700`		`- instanceTemplate.addValue(new Value(Symbol.SYMBOL_TO_STRING_TAG, name, JSAttributes.configurableNotEnumerableNotWritable()));`
`1701`	`1699`	`}`
`1702`	`1700`
`1703`	`1701`	`public Object functionTemplateInstanceTemplate(Object templateObj) {`