[GR-39662] Upgrading the underlying Node.js to version 16.17.1.

PullRequest: js/2604

Author: gilles-duboscq

3rd_party_licenses.txt

@@ -512,7 +512,7 @@ THE POSSIBILITY OF SUCH DAMAGE.
 
 ================================================================================
 
-Node.js 16.16.0
+Node.js 16.17.1
 
 Node.js is licensed for use as follows:
 
@@ -625,9 +625,22 @@ The externally maintained libraries used by Node.js are:
 
 - ICU, located at deps/icu-small, is licensed as follows:
   """
-    COPYRIGHT AND PERMISSION NOTICE (ICU 58 and later)
+    UNICODE, INC. LICENSE AGREEMENT - DATA FILES AND SOFTWARE
 
-    Copyright © 1991-2020 Unicode, Inc. All rights reserved.
+    See Terms of Use
+    for definitions of Unicode Inc.’s Data Files and Software.
+
+    NOTICE TO USER: Carefully read the following legal agreement.
+    BY DOWNLOADING, INSTALLING, COPYING OR OTHERWISE USING UNICODE INC.'S
+    DATA FILES ("DATA FILES"), AND/OR SOFTWARE ("SOFTWARE"),
+    YOU UNEQUIVOCALLY ACCEPT, AND AGREE TO BE BOUND BY, ALL OF THE
+    TERMS AND CONDITIONS OF THIS AGREEMENT.
+    IF YOU DO NOT AGREE, DO NOT DOWNLOAD, INSTALL, COPY, DISTRIBUTE OR USE
+    THE DATA FILES OR SOFTWARE.
+
+    COPYRIGHT AND PERMISSION NOTICE
+
+    Copyright © 1991-2022 Unicode, Inc. All rights reserved.
     Distributed under the Terms of Use in https://www.unicode.org/copyright.html.
 
     Permission is hereby granted, free of charge, to any person obtaining
@@ -659,15 +672,17 @@ The externally maintained libraries used by Node.js are:
     use or other dealings in these Data Files or Software without prior
     written authorization of the copyright holder.
 
-    ---------------------
+    ----------------------------------------------------------------------
 
     Third-Party Software Licenses
 
     This section contains third-party software notices and/or additional
     terms for licensed third-party software components included within ICU
     libraries.
 
-    1. ICU License - ICU 1.8.1 to ICU 57.1
+    ----------------------------------------------------------------------
+
+    ICU License - ICU 1.8.1 to ICU 57.1
 
     COPYRIGHT AND PERMISSION NOTICE
 
@@ -702,7 +717,9 @@ The externally maintained libraries used by Node.js are:
     All trademarks and registered trademarks mentioned herein are the
     property of their respective owners.
 
-    2. Chinese/Japanese Word Break Dictionary Data (cjdict.txt)
+    ----------------------------------------------------------------------
+
+    Chinese/Japanese Word Break Dictionary Data (cjdict.txt)
 
      #     The Google Chrome software developed by Google is licensed under
      # the BSD license. Other software included in this distribution is
@@ -906,7 +923,9 @@ The externally maintained libraries used by Node.js are:
      #
      #  ---------------COPYING.ipadic-----END----------------------------------
 
-    3. Lao Word Break Dictionary Data (laodict.txt)
+    ----------------------------------------------------------------------
+
+    Lao Word Break Dictionary Data (laodict.txt)
 
      # Copyright (C) 2016 and later: Unicode, Inc. and others.
      # License & terms of use: http://www.unicode.org/copyright.html
@@ -946,7 +965,9 @@ The externally maintained libraries used by Node.js are:
      # OF THE POSSIBILITY OF SUCH DAMAGE.
      #  --------------------------------------------------------------------------
 
-    4. Burmese Word Break Dictionary Data (burmesedict.txt)
+    ----------------------------------------------------------------------
+
+    Burmese Word Break Dictionary Data (burmesedict.txt)
 
      #  Copyright (c) 2014 International Business Machines Corporation
      #  and others. All Rights Reserved.
@@ -986,7 +1007,9 @@ The externally maintained libraries used by Node.js are:
      #  SUCH DAMAGE.
      #  --------------------------------------------------------------------------
 
-    5. Time Zone Database
+    ----------------------------------------------------------------------
+
+    Time Zone Database
 
       ICU uses the public domain data and code derived from Time Zone
     Database for its time zone support. The ownership of the TZ database
@@ -1009,7 +1032,9 @@ The externally maintained libraries used by Node.js are:
      #    making a contribution to the database or code waives all rights to
      #    future claims in that contribution or in the TZ Database.
 
-    6. Google double-conversion
+    ----------------------------------------------------------------------
+
+    Google double-conversion
 
     Copyright 2006-2011, the V8 project authors. All rights reserved.
     Redistribution and use in source and binary forms, with or without
@@ -1037,6 +1062,83 @@ The externally maintained libraries used by Node.js are:
     THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
     (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
     OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+    ----------------------------------------------------------------------
+
+    File: aclocal.m4 (only for ICU4C)
+    Section: pkg.m4 - Macros to locate and utilise pkg-config.
+
+    Copyright © 2004 Scott James Remnant .
+    Copyright © 2012-2015 Dan Nicholson
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful, but
+    WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+    General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
+    02111-1307, USA.
+
+    As a special exception to the GNU General Public License, if you
+    distribute this file as part of a program that contains a
+    configuration script generated by Autoconf, you may include it under
+    the same distribution terms that you use for the rest of that
+    program.
+
+    (The condition for the exception is fulfilled because
+    ICU4C includes a configuration script generated by Autoconf,
+    namely the `configure` script.)
+
+    ----------------------------------------------------------------------
+
+    File: config.guess (only for ICU4C)
+
+    This file is free software; you can redistribute it and/or modify it
+    under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 3 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful, but
+    WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+    General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, see .
+
+    As a special exception to the GNU General Public License, if you
+    distribute this file as part of a program that contains a
+    configuration script generated by Autoconf, you may include it under
+    the same distribution terms that you use for the rest of that
+    program.  This Exception is an additional permission under section 7
+    of the GNU General Public License, version 3 ("GPLv3").
+
+    (The condition for the exception is fulfilled because
+    ICU4C includes a configuration script generated by Autoconf,
+    namely the `configure` script.)
+
+    ----------------------------------------------------------------------
+
+    File: install-sh (only for ICU4C)
+
+    Copyright 1991 by the Massachusetts Institute of Technology
+
+    Permission to use, copy, modify, distribute, and sell this software and its
+    documentation for any purpose is hereby granted without fee, provided that
+    the above copyright notice appear in all copies and that both that
+    copyright notice and this permission notice appear in supporting
+    documentation, and that the name of M.I.T. not be used in advertising or
+    publicity pertaining to distribution of the software without specific,
+    written prior permission.  M.I.T. makes no representations about the
+    suitability of this software for any purpose.  It is provided "as is"
+    without express or implied warranty.
   """
 
 - libuv, located at deps/uv, is licensed as follows:

CHANGELOG.md

@@ -8,7 +8,7 @@ See [version roadmap](https://www.graalvm.org/release-notes/version-roadmap/) fo
 ## Version 22.3.0
 * Implemented the [WebAssembly multi-value](https://github.com/WebAssembly/multi-value) proposal.
 * Added an experimental option `--js.unhandled-rejections=handler` that allows to use a custom callback to track unhandled promise rejections.
-* Updated Node.js to version 16.16.0.
+* Updated Node.js to version 16.17.1.
 * ECMA-402 Internationalization API has been enabled by default. It can be disabled by `--js.intl-402=false` option.
 * Implemented the [Decorators (stage 3)](https://github.com/tc39/proposal-decorators) proposal.
 

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/JSConstructTypedArrayNode.java

@@ -476,8 +476,6 @@ private static int toByteLength(int length, int elementSize) {
     private RuntimeException throwInappropriateLengthError(long length) {
         if (getContext().isOptionNashornCompatibilityMode()) {
             throw Errors.createRangeError("inappropriate array buffer length: " + length);
-        } else if (getContext().isOptionV8CompatibilityMode()) {
-            throw Errors.createRangeError("Invalid array buffer length");
         } else {
             throw Errors.createRangeError("Invalid typed array length: " + length);
         }

graal-nodejs/.eslintignore

@@ -7,4 +7,5 @@ tools/icu
 tools/lint-md/lint-md.mjs
 benchmark/tmp
 doc/**/*.js
+!doc/api_assets/*.js
 !.eslintrc.js

graal-nodejs/.eslintrc.js

@@ -260,6 +260,7 @@ module.exports = {
     'no-useless-concat': 'error',
     'no-useless-constructor': 'error',
     'no-useless-return': 'error',
+    'no-var': 'error',
     'no-void': 'error',
     'no-whitespace-before-property': 'error',
     'object-curly-newline': 'error',
@@ -319,6 +320,7 @@ module.exports = {
     'node-core/no-duplicate-requires': 'error',
   },
   globals: {
+    CustomEvent: 'readable',
     Crypto: 'readable',
     CryptoKey: 'readable',
     fetch: 'readable',

graal-nodejs/.gitattributes

@@ -1,3 +1,6 @@
 test/fixtures/* -text
 vcbuild.bat text eol=crlf
+deps/npm/bin/npm text eol=lf
+deps/npm/bin/npx text eol=lf
+deps/corepack/shims/corepack text eol=lf
 tools/msvs/find_python.cmd text eol=crlf

graal-nodejs/.github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml

@@ -19,11 +19,24 @@ body:
       placeholder: e.g. `test-fs-stat-bigint`
     validations:
       required: true
-  - type: input
+  - type: dropdown
     attributes:
       label: Platform
       description: The platform the test is flaky on.
-      placeholder: e.g. `macos` or `linux`
+      multiple: true
+      options:
+        - AIX
+        - FreeBSD
+        - Linux ARM64
+        - Linux ARMv7
+        - Linux PPC64LE
+        - Linux s390x
+        - Linux x64
+        - macOS ARM64
+        - macOS x64
+        - SmartOS
+        - Windows
+        - Other
   - type: textarea
     attributes:
       label: Console output

graal-nodejs/.github/ISSUE_TEMPLATE/config.yml

@@ -1,4 +1,4 @@
-blank_issues_enabled: false
+blank_issues_enabled: true
 contact_links:
   - name: ⁉️ Need help with Node.js?
     url: https://github.com/nodejs/help

graal-nodejs/.github/label-pr-config.yml

@@ -26,7 +26,7 @@ subSystemLabels:
   /^src\/.*win32.*/: c++, windows
   /^src\/node_zlib/: c++, zlib
   /^src\/tracing/: c++, tracing
-  /^src\/node_api/: c++, node-api
+  /^src\/(?:node_api|js_native_api)/: c++, node-api
   /^src\/node_http2/: c++, http2
   /^src\/node_report/: c++, report
   /^src\/node_wasi/: c++, wasi
@@ -67,7 +67,7 @@ subSystemLabels:
   /^tools\/make-v8/: tools, v8 engine, needs-ci
   /^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
   /^tools\/(code_cache|snapshot)/: needs-ci
-  /^tools\/build-addons.js/: needs-ci
+  /^tools\/build-addons.mjs/: needs-ci
   # all other tool changes should be marked as such
   /^tools\//: tools
   /^\.eslint|\.remark|\.editorconfig/: tools
@@ -117,7 +117,8 @@ exlusiveLabels:
   /^test\/inspector\//: test, inspector
   /^test\/cctest\/test_inspector/: test, inspector
   /^test\/cctest\/test_url/: test, whatwg-url
-  /^test\/addons-napi\//: test, node-api
+  /^test\/node-api\//: test, node-api
+  /^test\/js-native-api\//: test, node-api
   /^test\/async-hooks\//: test, async_hooks
   /^test\/report\//: test, report
   /^test\/fixtures\/es-module/: test, esm

graal-nodejs/.github/workflows/authors.yml

@@ -6,25 +6,30 @@ on:
 
   workflow_dispatch:
 
+permissions:
+  contents: read
+
 jobs:
   authors_update:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
-      - run: tools/update-authors.js  # Run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
+      - run: tools/update-authors.mjs  # Run the AUTHORS tool
+      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:
           author: Node.js GitHub Bot <[email protected]>
           body: >
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
-            `authors.yml` GitHub Action, which runs `tools/update-authors.js`.
+            `authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
           branch: actions/authors-update  # Custom branch *just* for this Action.
           commit-message: 'meta: update AUTHORS'
           labels: meta