Skip to content

Commit 66b909f

Browse files
iamstolisiamstolis
committed
[GR-65223] Enable WebAssembly in graal-nodejs tests.
PullRequest: js/3518
2 parents d0b66f0 + 0ad8365 commit 66b909f

File tree

5 files changed

+9
-184
lines changed

5 files changed

+9
-184
lines changed

‎graal-nodejs/ci.jsonnet‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ local cicommon = import '../ci/common.jsonnet';
2020
// Avoid building native images on machines with very little RAM.
2121
capabilities+: if enabled && 'os' in self && (self.os == 'darwin' && self.arch == 'amd64') then ['ram16gb'] else [],
2222
artifact:: if enabled then 'nodejs' else '',
23-
suiteimports+:: if enabled then ['substratevm', 'tools'] else [],
23+
suiteimports+:: if enabled then ['substratevm', 'tools', 'wasm'] else [],
2424
nativeimages+:: if enabled then ['lib:graal-nodejs', 'lib:jvmcicompiler'] else [],
2525
build_dependencies+:: (if enabled then ['GRAALNODEJS_NATIVE_STANDALONE'] else []) + ['GRAALNODEJS_JVM_STANDALONE'],
2626
build_standalones:: true,

‎graal-nodejs/mx.graal-nodejs/mx_graal_nodejs.py‎

Lines changed: 0 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -78,97 +78,6 @@ def _graal_nodejs_post_gate_runner(args, tasks):
7878
node(commonArgs + ['-e', 'console.log(WebAssembly)'])
7979
# check that fetch API is available when WebAssembly is available
8080
node(commonArgs + ['-e', 'FormData'])
81-
# run selected Node.js tests related to WebAssembly
82-
wasm_tests = [
83-
join('es-module', 'test-esm-extensionless-esm-and-wasm.mjs'),
84-
join('es-module', 'test-esm-loader-entry-url.mjs'),
85-
join('es-module', 'test-esm-loader-http-imports.mjs'),
86-
join('es-module', 'test-esm-type-flag-loose-files.mjs'),
87-
join('es-module', 'test-esm-type-flag-package-scopes.mjs'),
88-
join('es-module', 'test-esm-wasm.mjs'),
89-
join('es-module', 'test-wasm-memory-out-of-bound.js'),
90-
join('es-module', 'test-wasm-simple.js'),
91-
join('es-module', 'test-wasm-web-api.js'),
92-
join('es-module', 'test-typescript.mjs'),
93-
join('es-module', 'test-typescript-eval.mjs'),
94-
join('es-module', 'test-typescript-commonjs.mjs'),
95-
join('es-module', 'test-typescript-module.mjs'),
96-
join('parallel', 'test-abortsignal-cloneable.js'),
97-
join('parallel', 'test-blob.js'),
98-
join('parallel', 'test-blocklist-clone.js'),
99-
join('parallel', 'test-crypto-x509.js'),
100-
join('parallel', 'test-debugger-invalid-json.mjs'),
101-
join('parallel', 'test-diagnostics-channel-module-import.js'),
102-
join('parallel', 'test-eventsource.js'),
103-
join('parallel', 'test-fetch.mjs'),
104-
join('parallel', 'test-fetch-disabled.mjs'),
105-
join('parallel', 'test-fetch-mock.js'),
106-
join('parallel', 'test-http-import-websocket.js'),
107-
join('parallel', 'test-http-response-setheaders.js'),
108-
join('parallel', 'test-messageevent-brandcheck.js'),
109-
join('parallel', 'test-messaging-marktransfermode.js'),
110-
join('parallel', 'test-perf-hooks-histogram.js'),
111-
join('parallel', 'test-repl-colors.js'),
112-
join('parallel', 'test-repl-context.js'),
113-
join('parallel', 'test-repl-definecommand.js'),
114-
join('parallel', 'test-repl-empty.js'),
115-
join('parallel', 'test-repl-domain.js'),
116-
join('parallel', 'test-repl-end-emits-exit.js'),
117-
join('parallel', 'test-repl-editor.js'),
118-
join('parallel', 'test-repl-eval.js'),
119-
join('parallel', 'test-repl-function-definition-edge-case.js'),
120-
join('parallel', 'test-repl-load-multiline-no-trailing-newline.js'),
121-
join('parallel', 'test-repl-mode.js'),
122-
join('parallel', 'test-repl-load-multiline.js'),
123-
join('parallel', 'test-repl-multiline.js'),
124-
join('parallel', 'test-repl-no-terminal.js'),
125-
join('parallel', 'test-repl-null.js'),
126-
join('parallel', 'test-repl-null-thrown.js'),
127-
join('parallel', 'test-repl-options.js'),
128-
join('parallel', 'test-repl-pretty-stack-custom-writer.js'),
129-
join('parallel', 'test-repl-preview-without-inspector.js'),
130-
join('parallel', 'test-repl-programmatic-history.js'),
131-
join('parallel', 'test-repl-recoverable.js'),
132-
join('parallel', 'test-repl-require-cache.js'),
133-
join('parallel', 'test-repl-require.js'),
134-
join('parallel', 'test-repl-reset-event.js'),
135-
join('parallel', 'test-repl-save-load.js'),
136-
join('parallel', 'test-repl-tab.js'),
137-
join('parallel', 'test-repl-syntax-error-stack.js'),
138-
join('parallel', 'test-repl-setprompt.js'),
139-
join('parallel', 'test-repl-tab-complete-crash.js'),
140-
join('parallel', 'test-repl-tab-complete-no-warn.js'),
141-
join('parallel', 'test-repl-throw-null-or-undefined.js'),
142-
join('parallel', 'test-repl-tab-complete-on-editor-mode.js'),
143-
join('parallel', 'test-repl-uncaught-exception.js'),
144-
join('parallel', 'test-repl-uncaught-exception-async.js'),
145-
join('parallel', 'test-repl-uncaught-exception-evalcallback.js'),
146-
join('parallel', 'test-repl-tab-complete-import.js'),
147-
join('parallel', 'test-repl-underscore.js'),
148-
join('parallel', 'test-repl-use-global.js'),
149-
join('parallel', 'test-repl-tab-complete.js'),
150-
join('parallel', 'test-runner-cli.js'),
151-
join('parallel', 'test-socketaddress.js'),
152-
join('parallel', 'test-structuredClone-global.js'),
153-
join('parallel', 'test-websocket.js'),
154-
join('parallel', 'test-webstreams-clone-unref.js'),
155-
join('parallel', 'test-webstream-structured-clone-no-leftovers.mjs'),
156-
join('parallel', 'test-whatwg-webstreams-transfer.js'),
157-
join('parallel', 'test-worker-broadcastchannel.js'),
158-
join('parallel', 'test-worker-broadcastchannel-wpt.js'),
159-
join('parallel', 'test-worker-eval-typescript.js'),
160-
join('parallel', 'test-worker-message-event.js'),
161-
join('parallel', 'test-worker-message-mark-as-uncloneable.js'),
162-
join('parallel', 'test-worker-message-port.js'),
163-
join('parallel', 'test-worker-message-port-transfer-self.js'),
164-
join('parallel', 'test-worker-message-port-wasm-module.js'),
165-
join('parallel', 'test-worker-message-port-wasm-threads.js'),
166-
join('parallel', 'test-worker-onmessage.js'),
167-
] + ([join('parallel', 'test-process-get-builtin.mjs')] if mx.suite('tools', fatalIfMissing=False) is None else [])
168-
for test in wasm_tests:
169-
mx.log('Running \'{}\''.format(test))
170-
node(commonArgs + [join(_suite.dir, 'test', test)])
171-
17281
# test that WebAssembly can be disabled using env. variables
17382
_setEnvVar('NODE_POLYGLOT_OPTIONS', '--js.webassembly=false --experimental-options')
17483
out = mx.OutputCapture()

‎graal-nodejs/test/es-module/es-module.status‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,6 @@ test-esm-detect-ambiguous : FAIL
2121
test-esm-tla-unfinished : FAIL
2222
test-require-module-tla-print-execution: FAIL
2323

24-
# WebAssembly is not enabled
25-
test-esm-extensionless-esm-and-wasm : FAIL
26-
test-esm-loader-entry-url : FAIL
27-
test-esm-loader-http-imports : FAIL
28-
test-esm-type-flag-loose-files : FAIL
29-
test-esm-type-flag-package-scopes : FAIL
30-
test-esm-wasm : FAIL
31-
test-wasm-memory-out-of-bound : FAIL
32-
test-wasm-simple : FAIL
33-
test-wasm-web-api : FAIL
34-
test-typescript : FAIL
35-
test-typescript-eval : FAIL
36-
test-typescript-commonjs : FAIL
37-
test-typescript-module : FAIL
38-
3924
# Unclassified
4025
test-require-module-tla : SKIP
4126

‎graal-nodejs/test/parallel/parallel.status‎

Lines changed: 7 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ test-finalization-registry-shutdown: SKIP
6767
# Uses v8 extension (--expose_externalize_string flag that exposes two additional functions)
6868
test-fs-write: FAIL
6969

70+
# loads inspector/promises that attempts to extend inspector.Session
71+
# (which is a foreign object when chromeinspector is used)
72+
test-process-get-builtin: SKIP
73+
7074
# uses V8 internal methods (%HaveSameMap, %CollectGarbage, %DebugPrint)
7175
test-http-same-map: FAIL
7276
test-v8-flags: FAIL
@@ -91,11 +95,13 @@ test-inspector-network-http: FAIL
9195

9296
# missing support for ModifyCodeGenerationFromStringsCallback
9397
test-source-map-api: FAIL
98+
test-vm-codegen: FAIL
9499

95100
# missing support for script.sourceMapURL
96101
test-module-strip-types: FAIL
97102
test-node-output-sourcemaps: FAIL
98103
test-source-map-cjs-require-cache: FAIL
104+
test-util-getcallsites: FAIL
99105
test-vm-source-map-url: FAIL
100106

101107
# checks v8-specific asm-related warning
@@ -147,83 +153,6 @@ test-vm-context: FAIL
147153
test-vm-proxy-failure-CP: FAIL
148154
test-vm-set-property-proxy: SKIP
149155

150-
# WebAssembly is not enabled by default
151-
test-abortsignal-cloneable: FAIL
152-
test-blob: FAIL
153-
test-blocklist-clone: FAIL
154-
test-crypto-x509: FAIL
155-
test-debugger-invalid-json: FAIL
156-
test-diagnostics-channel-module-import: FAIL
157-
test-eventsource: FAIL
158-
test-fetch: FAIL
159-
test-fetch-disabled: FAIL
160-
test-fetch-mock: FAIL
161-
test-http-import-websocket: FAIL
162-
test-http-response-setheaders: FAIL
163-
test-messageevent-brandcheck: FAIL
164-
test-messaging-marktransfermode: FAIL
165-
test-perf-hooks-histogram: FAIL
166-
test-process-get-builtin: FAIL
167-
test-repl-colors: FAIL
168-
test-repl-context: FAIL
169-
test-repl-definecommand: FAIL
170-
test-repl-empty: FAIL
171-
test-repl-domain: FAIL
172-
test-repl-end-emits-exit: FAIL
173-
test-repl-editor: FAIL
174-
test-repl-eval: FAIL
175-
test-repl-function-definition-edge-case: FAIL
176-
test-repl-load-multiline-no-trailing-newline: FAIL
177-
test-repl-mode: FAIL
178-
test-repl-load-multiline: FAIL
179-
test-repl-multiline: FAIL
180-
test-repl-no-terminal: FAIL
181-
test-repl-null: FAIL
182-
test-repl-null-thrown: FAIL
183-
test-repl-options: FAIL
184-
test-repl-pretty-stack-custom-writer: FAIL
185-
test-repl-preview-without-inspector: FAIL
186-
test-repl-programmatic-history: FAIL
187-
test-repl-recoverable: FAIL
188-
test-repl-require-cache: FAIL
189-
test-repl-require: FAIL
190-
test-repl-reset-event: FAIL
191-
test-repl-save-load: FAIL
192-
test-repl-tab: FAIL
193-
test-repl-syntax-error-stack: FAIL
194-
test-repl-setprompt: FAIL
195-
test-repl-tab-complete-crash: FAIL
196-
test-repl-tab-complete-no-warn: FAIL
197-
test-repl-throw-null-or-undefined: FAIL
198-
test-repl-tab-complete-on-editor-mode: FAIL
199-
test-repl-uncaught-exception: FAIL
200-
test-repl-uncaught-exception-async: FAIL
201-
test-repl-uncaught-exception-evalcallback: FAIL
202-
test-repl-tab-complete-import: FAIL
203-
test-repl-underscore: FAIL
204-
test-repl-use-global: FAIL
205-
test-repl-tab-complete: FAIL
206-
test-runner-cli: FAIL
207-
test-socketaddress: FAIL
208-
test-structuredClone-global: FAIL
209-
test-util-getcallsites: FAIL
210-
test-vm-codegen: FAIL
211-
test-websocket: FAIL
212-
test-webstreams-clone-unref: FAIL
213-
test-webstream-structured-clone-no-leftovers: FAIL
214-
test-whatwg-webstreams-transfer: FAIL
215-
test-worker-broadcastchannel-wpt: FAIL
216-
test-worker-broadcastchannel: FAIL
217-
test-worker-eval-typescript: FAIL
218-
test-worker-message-event: FAIL
219-
test-worker-message-mark-as-uncloneable: FAIL
220-
test-worker-message-port: FAIL
221-
test-worker-message-port-transfer-self: FAIL
222-
test-worker-message-port-wasm-module: FAIL
223-
test-worker-message-port-wasm-threads: FAIL
224-
test-worker-messaging: FAIL
225-
test-worker-onmessage: SKIP
226-
227156
# Custom MicrotaskQueue is not supported
228157
test-vm-timeout-escape-promise: FAIL
229158
test-vm-timeout-escape-promise-module: FAIL
@@ -334,6 +263,7 @@ test-vm-syntax-error-stderr: FAIL
334263
test-worker-cleanexit-with-js: SKIP
335264
test-worker-cleanexit-with-moduleload: SKIP
336265
test-worker-error-stack-getter-throws: FAIL
266+
test-worker-messaging: SKIP
337267
test-worker-messaging-errors-handler: SKIP
338268
test-worker-messaging-errors-timeout: SKIP
339269
test-worker-stack-overflow-stack-size: SKIP

‎graal-nodejs/test/parallel/test-bootstrap-modules.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ expected.beforePreExec = new Set([
111111

112112
expected.atRunTime = new Set([
113113
'Internal Binding worker',
114+
'NativeModule internal/graal/wasm',
114115
'NativeModule internal/modules/run_main',
115116
'NativeModule internal/net',
116117
'NativeModule internal/dns/utils',

0 commit comments

Comments
 (0)