Skip to content

Commit 73438fc

Browse files
committed
[GR-48041] Prepare 23.1.
PullRequest: js/2902
2 parents 0d157c2 + 49c76b5 commit 73438fc

File tree

17 files changed

+226
-113
lines changed

17 files changed

+226
-113
lines changed

ci.jsonnet

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ local graalNodeJs = import 'graal-nodejs/ci.jsonnet';
4848
] else [],
4949
using_artifact:: false,
5050
build_standalones:: false,
51+
build_dependencies:: if self.build_standalones then ['ALL_GRAALVM_ARTIFACTS'] else ['GRAALVM'],
5152
setup+: self.graalvm.setup,
5253
run+: []
5354
+ self.export_envvars
@@ -121,10 +122,8 @@ local graalNodeJs = import 'graal-nodejs/ci.jsonnet';
121122
run+: [
122123
mx_base_cmd + ["sversions"],
123124
mx_base_cmd + ["graalvm-show"],
124-
mx_base_cmd + ["build"],
125-
] + (if build.build_standalones then [
126-
mx_base_cmd + ["build", "--dependencies", "GRAALVM_STANDALONES"],
127-
] else []),
125+
mx_base_cmd + ["build", "--dependencies", std.join(',', build.build_dependencies)],
126+
],
128127
publishArtifacts+: [
129128
{
130129
name: artifactName,

common.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"Jsonnet files should not include this file directly but use ci/common.jsonnet instead."
55
],
66

7-
"mx_version": "6.41.0",
7+
"mx_version": "6.42.0",
88

99
"COMMENT.jdks": "When adding or removing JDKs keep in sync with JDKs in ci/common.jsonnet",
1010
"jdks": {

graal-js/ci.jsonnet

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ local ci = import '../ci.jsonnet';
4141
nativeimages+:: ['lib:jsvm', 'lib:jvmcicompiler'],
4242
extraimagebuilderarguments+:: ['-H:+ReportExceptionStackTraces'],
4343
run+: [
44-
['mx', 'build'],
45-
['mx', 'build', '--dependencies', 'GRAALVM_STANDALONES'],
44+
['mx', 'build', '--dependencies', 'ALL_GRAALVM_ARTIFACTS'],
4645
['set-export', 'GRAALVM_HOME', ['mx', '--quiet', 'graalvm-home']],
4746
['${GRAALVM_HOME}/bin/js', '--native', '-e', "print('hello:' + Array.from(new Array(10), (x,i) => i*i ).join('|'))"],
4847
['${GRAALVM_HOME}/bin/js', '--native', '../../js-benchmarks/harness.js', '--', '../../js-benchmarks/octane-richards.js', '--show-warmup'],

graal-js/mx.graal-js/mx_graal_js.py

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
import mx_graal_js_benchmark
3333
import mx, mx_sdk, mx_urlrewrites
3434
from mx_gate import Tags, Task, add_gate_runner, prepend_gate_runner
35+
36+
import mx_unittest
3537
from mx_unittest import unittest
3638

3739
_suite = mx.suite('graal-js')
@@ -50,11 +52,15 @@
5052

5153
def get_jdk(forBuild=False):
5254
# Graal.nodejs requires a JDK at build time, to be passed as argument to `./configure`.
55+
# GraalVMJDKConfig (`tag='graalvm'`) is not available until all the components are built.
5356
# GraalJVMCIJDKConfig (`tag='jvmci'`) is not available until all required jars are built.
54-
if not forBuild and mx.suite('compiler', fatalIfMissing=False):
55-
return mx.get_jdk(tag='jvmci')
56-
else:
57-
return mx.get_jdk()
57+
if not forBuild:
58+
jdk = mx.get_jdk(tag='graalvm')
59+
if exists(jdk.home):
60+
return jdk
61+
elif mx.suite('compiler', fatalIfMissing=False):
62+
return mx.get_jdk(tag='jvmci')
63+
return mx.get_jdk()
5864

5965
class GraalJsDefaultTags:
6066
default = 'default'
@@ -135,6 +141,15 @@ def _graal_js_gate_runner(args, tasks):
135141
finally:
136142
os.unlink(jsonResultsFile)
137143

144+
def _unittest_config_participant(config):
145+
(vmArgs, mainClass, mainClassArgs) = config
146+
vmArgs += ['-Dpolyglotimpl.DisableClassPathIsolation=true']
147+
mainClassArgs += ['-JUnitOpenPackages', 'org.graalvm.js/*=com.oracle.truffle.js.test']
148+
mainClassArgs += ['-JUnitOpenPackages', 'org.graalvm.js/*=com.oracle.truffle.js.snapshot']
149+
mainClassArgs += ['-JUnitOpenPackages', 'org.graalvm.js/*=ALL-UNNAMED']
150+
return (vmArgs, mainClass, mainClassArgs)
151+
152+
mx_unittest.add_config_participant(_unittest_config_participant)
138153
prepend_gate_runner(_suite, _graal_js_pre_gate_runner)
139154
add_gate_runner(_suite, _graal_js_gate_runner)
140155

@@ -244,10 +259,12 @@ def _get_lib_path(_lib_name):
244259
def _run_test_suite(custom_args, default_vm_args, max_heap, stack_size, main_class, nonZeroIsFatal, cwd):
245260
_vm_args, _prog_args = parse_js_args(custom_args)
246261
_vm_args = _append_default_js_vm_args(vm_args=_vm_args, max_heap=max_heap, stack_size=stack_size)
247-
_cp = mx.classpath(['TRUFFLE_JS_TESTS']
262+
_mp = mx.classpath(['TRUFFLE_JS_TESTS']
248263
+ (['tools:CHROMEINSPECTOR', 'tools:TRUFFLE_PROFILER'] if mx.suite('tools', fatalIfMissing=False) is not None else [])
249264
+ (['wasm:WASM'] if mx.suite('wasm', fatalIfMissing=False) is not None else []))
250-
_vm_args = ['-ea', '-esa', '-cp', _cp] + default_vm_args + _vm_args
265+
_cp = mx.classpath(['NASHORN_INTERNAL_TESTS'])
266+
_exports = ['--add-exports', 'org.graalvm.js/com.oracle.truffle.js.runtime=com.oracle.truffle.js.test']
267+
_vm_args = ['-ea', '-esa', '--module-path', _mp, '-cp', _cp] + _exports + default_vm_args + _vm_args
251268
return mx.run_java(_vm_args + [main_class] + _prog_args, nonZeroIsFatal=nonZeroIsFatal, cwd=cwd, jdk=get_jdk())
252269

253270
def test262(args, nonZeroIsFatal=True):

graal-js/mx.graal-js/suite.py

Lines changed: 66 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
{
2525
"name" : "regex",
2626
"subdir" : True,
27-
"version" : "87e0f80b1b3c1621e1e0c9f4a3b0f27816b0142f",
27+
"version" : "ce7e2791bb11eee493e6c332efe73f589e289e5f",
2828
"urls" : [
2929
{"url" : "https://github.com/oracle/graal.git", "kind" : "git"},
3030
]
@@ -73,30 +73,33 @@
7373
},
7474

7575
"JACKSON_CORE" : {
76-
"sha1" : "2ef7b1cc34de149600f5e75bc2d5bf40de894e60",
76+
"sha1" : "a6fe1836469a69b3ff66037c324d75fc66ef137c",
7777
"maven" : {
7878
"groupId" : "com.fasterxml.jackson.core",
7979
"artifactId" : "jackson-core",
80-
"version" : "2.8.6",
80+
"version" : "2.15.2",
8181
},
82+
"moduleName" : "com.fasterxml.jackson.core",
8283
},
8384

8485
"JACKSON_ANNOTATIONS" : {
85-
"sha1" : "9577018f9ce3636a2e1cb0a0c7fe915e5098ded5",
86+
"sha1" : "4724a65ac8e8d156a24898d50fd5dbd3642870b8",
8687
"maven" : {
8788
"groupId" : "com.fasterxml.jackson.core",
8889
"artifactId" : "jackson-annotations",
89-
"version" : "2.8.6",
90+
"version" : "2.15.2",
9091
},
92+
"moduleName" : "com.fasterxml.jackson.annotation",
9193
},
9294

9395
"JACKSON_DATABIND" : {
94-
"sha1" : "c43de61f74ecc61322ef8f402837ba65b0aa2bf4",
96+
"sha1" : "9353b021f10c307c00328f52090de2bdb4b6ff9c",
9597
"maven" : {
9698
"groupId" : "com.fasterxml.jackson.core",
9799
"artifactId" : "jackson-databind",
98-
"version" : "2.8.6",
100+
"version" : "2.15.2",
99101
},
102+
"moduleName" : "com.fasterxml.jackson.databind",
100103
},
101104
},
102105

@@ -254,7 +257,6 @@
254257
"sdk:GRAAL_SDK",
255258
"mx:JUNIT",
256259
"GRAALJS",
257-
"truffle:TRUFFLE_TCK",
258260
"com.oracle.truffle.js.snapshot",
259261
],
260262
"requires" : [
@@ -269,6 +271,24 @@
269271
"testProject" : True,
270272
},
271273

274+
"com.oracle.truffle.js.test.debug" : {
275+
"subDir" : "src",
276+
"sourceDirs" : ["src"],
277+
"dependencies" : [
278+
"sdk:GRAAL_SDK",
279+
"mx:JUNIT",
280+
"GRAALJS",
281+
"TRUFFLE_JS_TESTS",
282+
"truffle:TRUFFLE_TCK",
283+
],
284+
"annotationProcessors" : ["truffle:TRUFFLE_DSL_PROCESSOR"],
285+
"checkstyle" : "com.oracle.truffle.js",
286+
"spotbugs" : "true",
287+
"javaCompliance" : "17+",
288+
"workingSets" : "Truffle,JavaScript",
289+
"testProject" : True,
290+
},
291+
272292
"com.oracle.truffle.js.test.instrumentation" : {
273293
"subDir" : "src",
274294
"sourceDirs" : ["src"],
@@ -379,7 +399,6 @@
379399
"JACKSON_CORE",
380400
"JACKSON_ANNOTATIONS",
381401
"JACKSON_DATABIND",
382-
"NASHORN_INTERNAL_TESTS",
383402
"TRUFFLE_JS_SNAPSHOT_TOOL",
384403
],
385404
"annotationProcessors" : ["truffle:TRUFFLE_DSL_PROCESSOR"],
@@ -412,6 +431,7 @@
412431
"name" : "org.graalvm.js",
413432
"exports" : [
414433
"com.oracle.truffle.js.lang to org.graalvm.truffle",
434+
"com.oracle.js.parser to org.graalvm.nodejs",
415435
"com.oracle.js.parser.ir to org.graalvm.nodejs",
416436
"com.oracle.truffle.js.builtins to org.graalvm.nodejs",
417437
"com.oracle.truffle.js.builtins.helper to org.graalvm.nodejs",
@@ -454,6 +474,7 @@
454474
"MIT", # JONI regexp engine
455475
],
456476
"allowsJavadocWarnings": True,
477+
"useModulePath": True,
457478
},
458479

459480
"JS_COMMUNITY" : {
@@ -529,6 +550,12 @@
529550
},
530551

531552
"TRUFFLE_JS_SNAPSHOT_TOOL" : {
553+
"moduleInfo" : {
554+
"name" : "com.oracle.truffle.js.snapshot",
555+
"exports" : [
556+
"com.oracle.truffle.js.snapshot",
557+
],
558+
},
532559
"subDir" : "src",
533560
"dependencies" : ["com.oracle.truffle.js.snapshot"],
534561
"mainClass" : "com.oracle.truffle.js.snapshot.SnapshotTool",
@@ -563,6 +590,16 @@
563590
},
564591

565592
"TRUFFLE_JS_TESTS" : {
593+
"moduleInfo" : {
594+
"name" : "com.oracle.truffle.js.test",
595+
"exports" : [
596+
# Export everything to junit and dependent test distributions.
597+
"com.oracle.truffle.js.test*",
598+
],
599+
"opens" : [
600+
"com.oracle.truffle.js.test.external.suite to com.fasterxml.jackson.databind",
601+
],
602+
},
566603
"dependencies" : [
567604
"com.oracle.truffle.js.test",
568605
"com.oracle.truffle.js.test.external",
@@ -576,11 +613,9 @@
576613
"JACKSON_CORE",
577614
"JACKSON_ANNOTATIONS",
578615
"JACKSON_DATABIND",
579-
"NASHORN_INTERNAL_TESTS",
580616
],
581617
"distDependencies" : [
582618
"GRAALJS",
583-
"truffle:TRUFFLE_TCK",
584619
"TRUFFLE_JS_SNAPSHOT_TOOL",
585620
],
586621
"license": [
@@ -589,6 +624,26 @@
589624
"maven" : False,
590625
"description" : "Graal JavaScript Tests",
591626
"allowsJavadocWarnings": True,
627+
"useModulePath": True,
628+
},
629+
630+
"JS_DEBUG_TESTS" : {
631+
"subDir" : "src",
632+
"javaCompliance" : "17+",
633+
"dependencies" : [
634+
"com.oracle.truffle.js.test.debug",
635+
],
636+
"exclude" : [
637+
"mx:HAMCREST",
638+
"mx:JUNIT",
639+
],
640+
"distDependencies" : [
641+
"GRAALJS",
642+
"TRUFFLE_JS_TESTS",
643+
"sdk:POLYGLOT_TCK",
644+
"truffle:TRUFFLE_TCK",
645+
],
646+
"maven" : False
592647
},
593648

594649
"SDK_JS_TESTS" : {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0

graal-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/debug/JSDebugTest.java renamed to graal-js/src/com.oracle.truffle.js.test.debug/src/com/oracle/truffle/js/test/debug/JSDebugTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2017, 2022, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2017, 2023, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0

graal-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/debug/RealmTest.java renamed to graal-js/src/com.oracle.truffle.js.test.debug/src/com/oracle/truffle/js/test/debug/RealmTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2017, 2023, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0

graal-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/debug/TestScope.java renamed to graal-js/src/com.oracle.truffle.js.test.debug/src/com/oracle/truffle/js/test/debug/TestScope.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2017, 2022, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2017, 2023, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0

0 commit comments

Comments
 (0)