[GR-24666] Implementation of v8::Object::SetIntegrityLevel() and v8::V8::FromJustIsNothing().

PullRequest: js/1570

Author: iamstolis

graal-nodejs/deps/v8/src/graal/graal_isolate.cc

@@ -649,6 +649,7 @@ GraalIsolate::GraalIsolate(JavaVM* jvm, JNIEnv* env, v8::Isolate::CreateParams c
     ACCESS_METHOD(GraalAccessMethod::object_creation_context, "objectCreationContext", "(Ljava/lang/Object;)Ljava/lang/Object;")
     ACCESS_METHOD(GraalAccessMethod::object_define_property, "objectDefineProperty", "(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;ZZZZZZ)Z")
     ACCESS_METHOD(GraalAccessMethod::object_preview_entries, "objectPreviewEntries", "(Ljava/lang/Object;)Ljava/lang/Object;")
+    ACCESS_METHOD(GraalAccessMethod::object_set_integrity_level, "objectSetIntegrityLevel", "(Ljava/lang/Object;Z)V")
     ACCESS_METHOD(GraalAccessMethod::array_new, "arrayNew", "(Ljava/lang/Object;I)Ljava/lang/Object;")
     ACCESS_METHOD(GraalAccessMethod::array_length, "arrayLength", "(Ljava/lang/Object;)J")
     ACCESS_METHOD(GraalAccessMethod::array_buffer_new, "arrayBufferNew", "(Ljava/lang/Object;I)Ljava/lang/Object;")

graal-nodejs/deps/v8/src/graal/graal_isolate.h

@@ -149,6 +149,7 @@ enum GraalAccessMethod {
     object_creation_context,
     object_define_property,
     object_preview_entries,
+    object_set_integrity_level,
     array_new,
     array_length,
     array_buffer_new,

graal-nodejs/deps/v8/src/graal/graal_object.cc

@@ -353,4 +353,11 @@ v8::MaybeLocal<v8::Array> GraalObject::PreviewEntries(bool* is_key_value) {
         v8::Local<v8::Array> v8_entries = reinterpret_cast<v8::Array*> (graal_entries);
         return v8_entries;
     }
-}
+}
+
+v8::Maybe<bool> GraalObject::SetIntegrityLevel(v8::Local<v8::Context> context, v8::IntegrityLevel level) {
+    GraalIsolate* graal_isolate = Isolate();
+    jboolean freeze = (level == v8::IntegrityLevel::kFrozen);
+    JNI_CALL_VOID(graal_isolate, GraalAccessMethod::object_set_integrity_level, GetJavaObject(), freeze);
+    return graal_isolate->GetJNIEnv()->ExceptionCheck() ? v8::Nothing<bool>() : v8::Just<bool>(true);
+}

graal-nodejs/deps/v8/src/graal/graal_object.h

@@ -87,6 +87,7 @@ class GraalObject : public GraalValue {
     v8::MaybeLocal<v8::Value> GetOwnPropertyDescriptor(v8::Local<v8::Context> context, v8::Local<v8::Name> key);
     v8::Maybe<bool> DefineProperty(v8::Local<v8::Context> context, v8::Local<v8::Name> key, v8::PropertyDescriptor& descriptor);
     v8::MaybeLocal<v8::Array> PreviewEntries(bool* is_key_value);
+    v8::Maybe<bool> SetIntegrityLevel(v8::Local<v8::Context> context, v8::IntegrityLevel level);
 protected:
     GraalHandleContent* CopyImpl(jobject java_object_copy) override;
 private:

graal-nodejs/deps/v8/src/graal/v8.cc

@@ -1035,7 +1035,7 @@ namespace v8 {
     }
 
     void V8::FromJustIsNothing() {
-        TRACE
+        reinterpret_cast<GraalIsolate*> (GraalIsolate::GetCurrent())->ReportAPIFailure("v8::FromJust", "Maybe value is Nothing.");
     }
 
     const char* V8::GetVersion() {
@@ -2254,8 +2254,7 @@ namespace v8 {
     }
 
     Maybe<bool> Object::SetIntegrityLevel(Local<Context> context, IntegrityLevel level) {
-        TRACE
-        return Nothing<bool>();
+        return reinterpret_cast<GraalObject*> (this)->SetIntegrityLevel(context, level);
     }
 
     ScriptOrigin Message::GetScriptOrigin() const {

graal-nodejs/mx.graal-nodejs/com.oracle.truffle.trufflenode/src/com/oracle/truffle/trufflenode/GraalJSAccess.java

@@ -1144,6 +1144,12 @@ private Object objectCreationContextFromConstructor(DynamicObject object) {
         throw new IllegalArgumentException("Cannot get creation context for this object");
     }
 
+    public void objectSetIntegrityLevel(Object object, boolean freeze) {
+        if (JSObject.isJSObject(object)) {
+            JSObject.setIntegrityLevel((DynamicObject) object, freeze, true);
+        }
+    }
+
     public Object arrayNew(Object context, int length) {
         return JSArray.createConstantEmptyArray(((JSRealm) context).getContext(), length);
     }

graal-nodejs/mx.graal-nodejs/com.oracle.truffle.trufflenode/src/svmnodejs.jniconfig

@@ -156,6 +156,7 @@
       { "name": "objectSetAccessor" },
       { "name": "objectSetAlignedPointerInInternalField" },
       { "name": "objectSetIndex" },
+      { "name": "objectSetIntegrityLevel" },
       { "name": "objectSetPrivate" },
       { "name": "objectSetPrototype" },
       { "name": "objectSlowGetAlignedPointerFromInternalField" },

graal-nodejs/test/graal/unit/object.cc

@@ -241,4 +241,17 @@ EXPORT_TO_JS(GetRealNamedPropertyAttributes) {
     args.GetReturnValue().Set(result);
 }
 
+EXPORT_TO_JS(SetIntegrityLevel) {
+    Local<Context> context = args.GetIsolate()->GetCurrentContext();
+    Local<Object> obj = args[0].As<Object>();
+    bool freeze = args[1].As<Boolean>()->Value();
+
+    IntegrityLevel level = freeze ? IntegrityLevel::kFrozen : IntegrityLevel::kSealed;
+    Maybe<bool> result = obj->SetIntegrityLevel(context, level);
+
+    if (result.IsJust()) {
+        args.GetReturnValue().Set(result.FromJust());
+    }
+}
+
 #undef SUITE

graal-nodejs/test/graal/unit/object.js

@@ -455,4 +455,56 @@ describe('Object', function () {
             assert.strictEqual(module.Object_GetRealNamedPropertyAttributes(o, "accessor"), 6 /* DontEnum | DontDelete */);
         });
     });
+    describe('SetIntegrityLevel', function () {
+        it('should freeze the object', function () {
+            var o = {
+                bar: 42
+            };
+            assert.strictEqual(module.Object_SetIntegrityLevel(o, true), true);
+            assert.throws(function () {
+                "use strict";
+                o.bar = 211;
+            }, TypeError);
+            assert.throws(function () {
+                "use strict";
+                o.foo = 42;
+            }, TypeError);
+        });
+        it('should seal the object', function () {
+            var o = {
+                bar: 42
+            };
+            assert.strictEqual(module.Object_SetIntegrityLevel(o, false), true);
+            o.bar = 211; // value of an existing property can be modified
+            assert.strictEqual(o.bar, 211);
+            assert.throws(function () {
+                "use strict";
+                o.foo = 42;
+            }, TypeError);
+        });
+        var proxy = new Proxy({}, {
+            preventExtensions: function () {
+                return false;
+            }
+        });
+        it('should throw for a Proxy refusing to prevent extensions (freeze)', function () {
+            assert.throws(function () {
+                module.Object_SetIntegrityLevel(proxy, true);
+            }, TypeError);
+        });
+        it('should throw for a Proxy refusing to prevent extensions (seal)', function () {
+            assert.throws(function () {
+                module.Object_SetIntegrityLevel(proxy, false);
+            }, TypeError);
+        });
+        if (typeof java === 'object') {
+            var point = new java.awt.Point();
+            it('should not crash for foreign objects (freeze)', function () {
+                assert.strictEqual(module.Object_SetIntegrityLevel(point, true), true);
+            });
+            it('should not crash for foreign objects (seal)', function () {
+                assert.strictEqual(module.Object_SetIntegrityLevel(point, false), true);
+            });
+        }
+    });
 });