Merge tag '3c6724cce4483db67669638e7d278102aea36778' into GR-37528

2022-03-17 Node.js v16.14.2 'Gallium' (LTS) Release
Git-EVTag-v0-SHA512: 1f602e0502b402dcaa967a16fedf3f0d4ce34fe82e46cde34613be93467c6ffc5a4dc73feaac5513f8d95ee0215bafdcea890ff3cb3146124a3d671d88d81699

Author: iamstolis

graal-nodejs/.eslintrc.js

@@ -15,6 +15,7 @@ NodePlugin.RULES_DIR = path.resolve(__dirname, 'tools', 'eslint-rules');
 const ModuleFindPath = Module._findPath;
 const hacks = [
   'eslint-plugin-node-core',
+  'eslint-plugin-jsdoc',
   'eslint-plugin-markdown',
   '@babel/eslint-parser',
   '@babel/plugin-syntax-import-assertions',
@@ -34,7 +35,8 @@ Module._findPath = (request, paths, isMain) => {
 
 module.exports = {
   root: true,
-  plugins: ['markdown', 'node-core'],
+  extends: ['eslint:recommended', 'plugin:jsdoc/recommended'],
+  plugins: ['jsdoc', 'markdown', 'node-core'],
   parser: '@babel/eslint-parser',
   parserOptions: {
     babelOptions: {
@@ -140,17 +142,14 @@ module.exports = {
     'comma-spacing': 'error',
     'comma-style': 'error',
     'computed-property-spacing': 'error',
-    'constructor-super': 'error',
     'default-case-last': 'error',
     'dot-location': ['error', 'property'],
     'dot-notation': 'error',
     'eol-last': 'error',
     'eqeqeq': ['error', 'smart'],
-    'for-direction': 'error',
     'func-call-spacing': 'error',
     'func-name-matching': 'error',
     'func-style': ['error', 'declaration', { allowArrowFunctions: true }],
-    'getter-return': 'error',
     'indent': ['error', 2, {
       ArrayExpression: 'first',
       CallExpression: { arguments: 'first' },
@@ -164,55 +163,29 @@ module.exports = {
     'keyword-spacing': 'error',
     'linebreak-style': ['error', 'unix'],
     'max-len': ['error', {
-      code: 80,
+      code: 120,
       ignorePattern: '^// Flags:',
       ignoreRegExpLiterals: true,
       ignoreTemplateLiterals: true,
       ignoreUrls: true,
       tabWidth: 2,
     }],
     'new-parens': 'error',
-    'no-async-promise-executor': 'error',
-    'no-class-assign': 'error',
     'no-confusing-arrow': 'error',
-    'no-const-assign': 'error',
+    'no-constant-condition': ['error', { checkLoops: false }],
     'no-constructor-return': 'error',
-    'no-control-regex': 'error',
-    'no-debugger': 'error',
-    'no-delete-var': 'error',
-    'no-dupe-args': 'error',
-    'no-dupe-class-members': 'error',
-    'no-dupe-keys': 'error',
-    'no-dupe-else-if': 'error',
-    'no-duplicate-case': 'error',
     'no-duplicate-imports': 'error',
     'no-else-return': ['error', { allowElseIf: true }],
-    'no-empty-character-class': 'error',
-    'no-ex-assign': 'error',
-    'no-extra-boolean-cast': 'error',
     'no-extra-parens': ['error', 'functions'],
-    'no-extra-semi': 'error',
-    'no-fallthrough': 'error',
-    'no-func-assign': 'error',
-    'no-global-assign': 'error',
-    'no-invalid-regexp': 'error',
-    'no-irregular-whitespace': 'error',
     'no-lonely-if': 'error',
-    'no-misleading-character-class': 'error',
     'no-mixed-requires': 'error',
-    'no-mixed-spaces-and-tabs': 'error',
     'no-multi-spaces': ['error', { ignoreEOLComments: true }],
     'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }],
     'no-new-require': 'error',
-    'no-new-symbol': 'error',
-    'no-nonoctal-decimal-escape': 'error',
-    'no-obj-calls': 'error',
-    'no-octal': 'error',
     'no-path-concat': 'error',
     'no-proto': 'error',
     'no-redeclare': ['error', { 'builtinGlobals': false }],
     'no-restricted-modules': ['error', 'sys'],
-    /* eslint-disable max-len */
     'no-restricted-properties': [
       'error',
       {
@@ -265,42 +238,27 @@ module.exports = {
         message: 'Use Number.isNaN() instead of the global isNaN() function.',
       },
     ],
-    /* eslint-enable max-len */
     'no-return-await': 'error',
-    'no-self-assign': 'error',
     'no-self-compare': 'error',
-    'no-setter-return': 'error',
-    'no-shadow-restricted-names': 'error',
     'no-tabs': 'error',
     'no-template-curly-in-string': 'error',
-    'no-this-before-super': 'error',
     'no-throw-literal': 'error',
     'no-trailing-spaces': 'error',
     'no-undef': ['error', { typeof: true }],
     'no-undef-init': 'error',
-    'no-unexpected-multiline': 'error',
-    'no-unreachable': 'error',
-    'no-unsafe-finally': 'error',
-    'no-unsafe-negation': 'error',
-    'no-unsafe-optional-chaining': 'error',
     'no-unused-expressions': ['error', { allowShortCircuit: true }],
-    'no-unused-labels': 'error',
     'no-unused-vars': ['error', { args: 'none', caughtErrors: 'all' }],
     'no-use-before-define': ['error', {
       classes: true,
       functions: false,
       variables: false,
     }],
-    'no-useless-backreference': 'error',
     'no-useless-call': 'error',
-    'no-useless-catch': 'error',
     'no-useless-concat': 'error',
     'no-useless-constructor': 'error',
-    'no-useless-escape': 'error',
     'no-useless-return': 'error',
     'no-void': 'error',
     'no-whitespace-before-property': 'error',
-    'no-with': 'error',
     'object-curly-newline': 'error',
     'object-curly-spacing': ['error', 'always'],
     'one-var': ['error', { initialized: 'never' }],
@@ -311,6 +269,7 @@ module.exports = {
       { blankLine: 'always', prev: 'function', next: 'function' },
     ],
     'prefer-const': ['error', { ignoreReadBeforeAssign: true }],
+    'prefer-object-has-own': 'error',
     'quotes': ['error', 'single', { avoidEscape: true }],
     'quote-props': ['error', 'consistent'],
     'rest-spread-spacing': 'error',
@@ -333,9 +292,25 @@ module.exports = {
     'symbol-description': 'error',
     'template-curly-spacing': 'error',
     'unicode-bom': 'error',
-    'use-isnan': 'error',
     'valid-typeof': ['error', { requireStringLiterals: true }],
 
+    // ESLint recommended rules that we disable
+    'no-inner-declarations': 'off',
+
+    // JSDoc recommended rules that we disable
+    'jsdoc/require-jsdoc': 'off',
+    'jsdoc/require-param-description': 'off',
+    'jsdoc/newline-after-description': 'off',
+    'jsdoc/require-returns-description': 'off',
+    'jsdoc/valid-types': 'off',
+    'jsdoc/no-undefined-types': 'off',
+    'jsdoc/require-param': 'off',
+    'jsdoc/check-tag-names': 'off',
+    'jsdoc/require-returns': 'off',
+    'jsdoc/require-property-description': 'off',
+    'jsdoc/check-param-names': 'off',
+    'jsdoc/tag-lines': 'off',
+
     // Custom rules from eslint-plugin-node-core
     'node-core/no-unescaped-regexp-dot': 'error',
     'node-core/no-duplicate-requires': 'error',

graal-nodejs/.github/CODEOWNERS

@@ -5,23 +5,15 @@
 # 3. PRs touching any code with a codeowner must be signed off by at least one
 #    person on the code owner team.
 
-# tsc & commcomm
+# tsc
 
 /.github/CODEOWNERS @nodejs/tsc
 /GOVERNANCE.md @nodejs/tsc
 /onboarding.md @nodejs/tsc
-/CODE_OF_CONDUCT.md @nodejs/tsc @nodejs/community-committee
-/CONTRIBUTING.md @nodejs/tsc @nodejs/community-committee
-/LICENSE @nodejs/tsc @nodejs/community-committee
-/doc/guides/contributing/code-of-conduct.md @nodejs/tsc @nodejs/community-committee
-# TODO(mmarchini): the bot doens't have a notion of precedence, that might
-# change when move the codeowners code to an Action, at which point we can
-# uncomment the line below
-# /doc/guides/contributing/*.md @nodejs/tsc
-/doc/guides/contributing/issues.md @nodejs/tsc
-/doc/guides/contributing/pull-requests.md @nodejs/tsc
-/doc/guides/collaborator-guide.md @nodejs/tsc
-/doc/guides/offboarding.md @nodejs/tsc
+/CODE_OF_CONDUCT.md @nodejs/tsc
+/CONTRIBUTING.md @nodejs/tsc
+/LICENSE @nodejs/tsc
+/doc/contributing/*.md @nodejs/tsc
 
 # streams
 
@@ -90,12 +82,12 @@
 /lib/internal/bootstrap/loaders.js @nodejs/modules
 /src/module_wrap* @nodejs/modules @nodejs/vm
 
-# N-API
+# Node-API
 
-/src/node_api* @nodejs/n-api
-/src/js_native_api* @nodejs/n-api
-/doc/guides/adding-new-napi-api.md @nodejs/n-api
-/doc/api/n-api.md @nodejs/n-api
+/src/node_api* @nodejs/node-api
+/src/js_native_api* @nodejs/node-api
+/doc/contributing/adding-new-napi-api.md @nodejs/node-api
+/doc/api/n-api.md @nodejs/node-api
 
 # gyp
 

graal-nodejs/.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -9,7 +9,7 @@ body:
         This issue tracker is for bugs and issues found within Node.js core.
         If you require more general support please file an issue on our help repo. https://github.com/nodejs/help
 
-        Please fill in as much of the form below as you're able.
+        Please fill in as much of the following form as you're able.
   - type: input
     attributes:
       label: Version
@@ -39,6 +39,8 @@ body:
     attributes:
       label: What do you see instead?
       description: If possible please provide textual output instead of screenshots.
+    validations:
+      required: true
   - type: textarea
     attributes:
       label: Additional information

graal-nodejs/.github/ISSUE_TEMPLATE/2-feature-request.md

@@ -0,0 +1,26 @@
+name: "\U0001F680 Feature request"
+description: Suggest an idea for this project
+labels: ["feature request"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for suggesting an idea to make Node.js better.
+
+        Please fill in as much of the following form as you're able.
+
+        For more information on how the project manages feature
+        requests, see [Feature request management](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md).
+  - type: textarea
+    attributes:
+      label: What is the problem this feature will solve?
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: What is the feature you are proposing to solve the problem?
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: What alternatives have you considered?

graal-nodejs/.github/ISSUE_TEMPLATE/2-feature-request.yml

@@ -0,0 +1,18 @@
+name: "\U0001F4D7 Open an issue regarding the Node.js API reference docs"
+description: Let us know about any problematic API reference documents
+labels: ["doc"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for wanting to make nodejs.org better!
+
+        Please fill in as much of the following form as you're able.
+  - type: input
+    attributes:
+      label: Affected URL(s)
+  - type: textarea
+    attributes:
+      label: Description of the problem
+    validations:
+      required: true

graal-nodejs/.github/ISSUE_TEMPLATE/3-api-ref-docs-problem.md

@@ -1,6 +1,5 @@
 name: Report a flaky test
 description: Report a flaky test in our CI
-title: "Investigate flaky test - "
 labels: ["flaky-test"]
 body:
   - type: markdown

graal-nodejs/.github/ISSUE_TEMPLATE/3-api-ref-docs-problem.yml

@@ -3,7 +3,7 @@ Before submitting a pull request, please read
 https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.
 
 Commit message formatting guidelines:
-https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines
+https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
 
 For code changes:
 1. Include tests for any bug fixes or new features.