[GR-22188] Fixing an incorrect cast of lastIndex in RegExp.prototype[Symbol.replace].

PullRequest: js/1447

Author: iamstolis

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/RegExpPrototypeBuiltins.java

@@ -1183,8 +1183,13 @@ private String replaceAccordingToSpec(DynamicObject rx, String s, Object replace
                 }
                 if (global) {
                     if (matchLength == 0) {
-                        int lastI = (int) toLength(getLastIndex(rx));
-                        setLastIndex(rx, fullUnicode ? advanceStringIndexUnicode(s, lastI) : lastI + 1);
+                        long lastI = toLength(getLastIndex(rx));
+                        long nextIndex = lastI + 1;
+                        if (JSRuntime.longIsRepresentableAsInt(nextIndex)) {
+                            setLastIndex(rx, fullUnicode ? advanceStringIndexUnicode(s, (int) lastI) : (int) nextIndex);
+                        } else {
+                            setLastIndex(rx, (double) nextIndex);
+                        }
                     }
                 } else {
                     break;

graal-js/test/test262.json

@@ -1623,10 +1623,6 @@
     "filePath" : "built-ins/RegExp/property-escapes/generated/XID_Start.js",
     "status" : "SKIP",
     "comment" : "Long-running generated Unicode tests."
-  }, {
-    "filePath" : "built-ins/RegExp/prototype/Symbol.replace/coerce-lastindex.js",
-    "status" : "FAIL",
-    "comment" : "new failures update 2020-04-01"
   }, {
     "filePath" : "built-ins/String/prototype/toLowerCase/Final_Sigma_U180E.js",
     "status" : "FAIL",

graal-js/test/testV8.json

@@ -1442,10 +1442,6 @@
     "filePath" : "mjsunit/regress/regress-798.js",
     "status" : "SKIP",
     "comment" : "spurious failures\njava.lang.IllegalStateException: This node cannot be replaced, because it does not yet have a parent. at com.oracle.truffle.api.nodes.Node.replaceHelper(Node.java:293), com.oracle.truffle.api.nodes.NodeUtil.nonAtomicReplace(NodeUtil.java:207), com.oracle.truffle.api.dsl.internal.SpecializationNode.insertAt(SpecializationNode.java:537), com.oracle.truffle.api.dsl.internal.SpecializationNode$InsertionEvent1.call(SpecializationNode.java:663), com.oracle.truffle.api.dsl.internal.SpecializationNode$InsertionEvent1.call(SpecializationNode.java:647)"
-  }, {
-    "filePath" : "mjsunit/regress/regress-799813.js",
-    "status" : "FAIL",
-    "comment" : "TODO: evaluate (V8 tests update 2018-10-29)"
   }, {
     "filePath" : "mjsunit/regress/regress-8033.js",
     "status" : "FAIL",