[GR-28112] Backport: Allow parsing of legacy dates without time-zone offset as being in local time.

PullRequest: js/1816

Author: iamstolis

graal-js/src/com.oracle.truffle.js.parser/src/com/oracle/truffle/js/parser/date/DateParser.java

@@ -50,6 +50,7 @@
 import java.util.HashMap;
 import java.util.Locale;
 
+import com.oracle.truffle.js.runtime.JSContext;
 import com.oracle.truffle.js.runtime.JSRealm;
 
 // @formatter:off
@@ -679,7 +680,8 @@ private boolean patchResult(final boolean strict) {
         if (isSet(HOUR) && !isSet(MINUTE)) {
             return false;
         }
-        if (realm.getContext().isOptionV8CompatibilityMode()) {
+        JSContext context = realm.getContext();
+        if (context.isOptionV8CompatibilityMode()) {
             if (!isSet(YEAR) && !isSet(DAY) && !isSet(MONTH)) {
                 return false;
             }
@@ -688,7 +690,7 @@ private boolean patchResult(final boolean strict) {
         // fill in default values for unset fields except timezone
         for (int field = YEAR; field <= TIMEZONE; field++) {
             if (get(field) == null) {
-                if (field == TIMEZONE && !dateOnly) {
+                if (field == TIMEZONE && !isUTCDefaultTimezone(context, dateOnly, strict)) {
                     // When the UTC offset representation is absent,
                     // date-only forms are interpreted as a UTC time and
                     // date-time forms are interpreted as a local time (= empty TIMEZONE).
@@ -737,6 +739,10 @@ private boolean patchResult(final boolean strict) {
         return true;
     }
 
+    private static boolean isUTCDefaultTimezone(JSContext context, boolean dateOnly, boolean strict) {
+        return (strict || context.getContextOptions().shouldUseUTCForLegacyDates()) && dateOnly;
+    }
+
     private static void addName(final String str, final int type, final int value) {
         final Name name = new Name(str, type, value);
         names.put(name.key, name);

graal-js/src/com.oracle.truffle.js.test/js/without-utc-offset1.js

@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2020, 2020, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+ */
+
+/**
+ * This test is an extension of
+ * https://github.com/tc39/test262/blob/main/test/built-ins/Date/parse/without-utc-offset.js
+ * This extension checks also the desired behaviour for legacy dates
+ * (that are not covered by the specification).
+ */
+
+load('assert.js');
+
+const timezoneOffsetMS = new Date(0).getTimezoneOffset() * 60000;
+
+function check(string, expected) {
+    assertSame(expected, Date.parse(string));
+    assertSame(expected, new Date(string).getTime());
+}
+
+check('1970-01-01T00:00:00', timezoneOffsetMS);
+check('1970-01-01', 0);
+check('1970-01', 0);
+check('1970', 0);
+
+// Legacy format
+check('1-1-1970', 0);
+check('1-1-1970 00:00:00', timezoneOffsetMS);
+check('1/1/1970', 0);
+check('1/1/1970 00:00:00', timezoneOffsetMS);
+check('1970-01-1', 0);
+check('1970-1-01', 0);
+check('1970-1-1', 0);
+check('1970-1', 0);
+
+true;

graal-js/src/com.oracle.truffle.js.test/js/without-utc-offset2.js

@@ -0,0 +1,41 @@
+/*
+ * Copyright (c) 2020, 2020, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+ */
+
+/**
+ * This test is an extension of
+ * https://github.com/tc39/test262/blob/main/test/built-ins/Date/parse/without-utc-offset.js
+ * This extension checks also the desired behaviour for legacy dates
+ * (that are not covered by the specification).
+ * 
+ * @option use-utc-for-legacy-dates=false
+ */
+
+load('assert.js');
+
+const timezoneOffsetMS = new Date(0).getTimezoneOffset() * 60000;
+
+function check(string, expected) {
+    assertSame(expected, Date.parse(string));
+    assertSame(expected, new Date(string).getTime());
+}
+
+check('1970-01-01T00:00:00', timezoneOffsetMS);
+check('1970-01-01', 0);
+check('1970-01', 0);
+check('1970', 0);
+
+// Legacy format
+check('1-1-1970', timezoneOffsetMS);
+check('1-1-1970 00:00:00', timezoneOffsetMS);
+check('1/1/1970', timezoneOffsetMS);
+check('1/1/1970 00:00:00', timezoneOffsetMS);
+check('1970-01-1', timezoneOffsetMS);
+check('1970-1-01', timezoneOffsetMS);
+check('1970-1-1', timezoneOffsetMS);
+check('1970-1', timezoneOffsetMS);
+
+true;

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSContextOptions.java

@@ -487,6 +487,11 @@ public Map<String, String> apply(String value) {
     protected static final OptionKey<Boolean> TOP_LEVEL_AWAIT = new OptionKey<>(false);
     @CompilationFinal private boolean topLevelAwait;
 
+    public static final String USE_UTC_FOR_LEGACY_DATES_NAME = JS_OPTION_PREFIX + "use-utc-for-legacy-dates";
+    @Option(name = USE_UTC_FOR_LEGACY_DATES_NAME, category = OptionCategory.EXPERT, stability = OptionStability.STABLE, help = "Determines what time zone (UTC or local time zone) should be used when UTC offset is absent in a parsed date.") //
+    public static final OptionKey<Boolean> USE_UTC_FOR_LEGACY_DATES = new OptionKey<>(true);
+    @CompilationFinal private boolean useUTCForLegacyDates;
+
     JSContextOptions(JSParserOptions parserOptions, OptionValues optionValues) {
         this.parserOptions = parserOptions;
         this.optionValues = optionValues;
@@ -571,6 +576,7 @@ private void cacheOptions() {
         this.maxPrototypeChainLength = readIntegerOption(MAX_PROTOTYPE_CHAIN_LENGTH);
         this.asyncStackTraces = readBooleanOption(ASYNC_STACK_TRACES);
         this.topLevelAwait = TOP_LEVEL_AWAIT.hasBeenSet(optionValues) ? readBooleanOption(TOP_LEVEL_AWAIT) : getEcmaScriptVersion() >= JSConfig.ECMAScript2022;
+        this.useUTCForLegacyDates = USE_UTC_FOR_LEGACY_DATES.hasBeenSet(optionValues) ? readBooleanOption(USE_UTC_FOR_LEGACY_DATES) : !v8CompatibilityMode;
 
         this.propertyCacheLimit = readIntegerOption(PROPERTY_CACHE_LIMIT);
         this.functionCacheLimit = readIntegerOption(FUNCTION_CACHE_LIMIT);
@@ -925,6 +931,10 @@ public boolean isAsyncStackTraces() {
         return asyncStackTraces;
     }
 
+    public boolean shouldUseUTCForLegacyDates() {
+        return useUTCForLegacyDates;
+    }
+
     @Override
     public int hashCode() {
         int hash = 5;
@@ -973,6 +983,7 @@ public int hashCode() {
         hash = 53 * hash + this.propertyCacheLimit;
         hash = 53 * hash + this.functionCacheLimit;
         hash = 53 * hash + (this.topLevelAwait ? 1 : 0);
+        hash = 53 * hash + (this.useUTCForLegacyDates ? 1 : 0);
         return hash;
     }
 
@@ -1120,6 +1131,9 @@ public boolean equals(Object obj) {
         if (this.topLevelAwait != other.topLevelAwait) {
             return false;
         }
+        if (this.useUTCForLegacyDates != other.useUTCForLegacyDates) {
+            return false;
+        }
         return Objects.equals(this.parserOptions, other.parserOptions);
     }
 }