Testing own keys of object templates with empty enumerators.

Author: iamstolis

graal-nodejs/test/graal/unit/object_template.cc

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -45,6 +45,7 @@
 
 void SimpleAccessorGetter(Local<Name> property, const PropertyCallbackInfo<Value>& info);
 void SimpleAccessorSetter(Local<Name> property, Local<Value> value, const PropertyCallbackInfo<void>& info);
+void EmptyPropertyEnumeratorCallback(const PropertyCallbackInfo<Array>& info) {};
 
 #endif
 
@@ -128,4 +129,38 @@ EXPORT_TO_JS(CheckNamedHandlerWithInternalFields) {
     args.GetReturnValue().Set(expectedCount == actualCount);
 }
 
+EXPORT_TO_JS(CreateWithEmptyIndexedEnumerator) {
+    Isolate* isolate = args.GetIsolate();
+    Local<ObjectTemplate> objectTemplate = ObjectTemplate::New(isolate);
+    IndexedPropertyHandlerConfiguration handler(
+            nullptr, // getter
+            nullptr, // setter
+            nullptr, // query
+            nullptr, // deleter
+            EmptyPropertyEnumeratorCallback // enumerator
+    );
+    objectTemplate->SetHandler(handler);
+
+    Local<Context> context = isolate->GetCurrentContext();
+    Local<Object> instance = objectTemplate->NewInstance(context).ToLocalChecked();
+    args.GetReturnValue().Set(instance);
+}
+
+EXPORT_TO_JS(CreateWithEmptyNamedEnumerator) {
+    Isolate* isolate = args.GetIsolate();
+    Local<ObjectTemplate> objectTemplate = ObjectTemplate::New(isolate);
+    NamedPropertyHandlerConfiguration handler(
+            nullptr, // getter
+            nullptr, // setter
+            nullptr, // query
+            nullptr, // deleter
+            EmptyPropertyEnumeratorCallback // enumerator
+    );
+    objectTemplate->SetHandler(handler);
+
+    Local<Context> context = isolate->GetCurrentContext();
+    Local<Object> instance = objectTemplate->NewInstance(context).ToLocalChecked();
+    args.GetReturnValue().Set(instance);
+}
+
 #undef SUITE

graal-nodejs/test/graal/unit/object_template.js

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -83,6 +83,14 @@ describe('ObjectTemplate', function () {
         it('should create object with the specified internal field count', function () {
             var result = module.ObjectTemplate_CheckNamedHandlerWithInternalFields();
             assert.ok(result);
-        });        
+        });
+        it('should not crash with an empty named enumerator', function () {
+            var obj = module.ObjectTemplate_CreateWithEmptyNamedEnumerator();
+            assert.strictEqual(Object.keys(obj).length, 0);
+        });
+        it('should not crash with an empty indexed enumerator', function () {
+            var obj = module.ObjectTemplate_CreateWithEmptyIndexedEnumerator();
+            assert.strictEqual(Object.keys(obj).length, 0);
+        });
     });
 });