[GR-52466] Backport to 24.0: Upgrading the underlying Node.js to version 18.19.1.

PullRequest: js/3084

Author: iamstolis

3rd_party_licenses.txt

@@ -512,7 +512,7 @@ THE POSSIBILITY OF SUCH DAMAGE.
 
 ================================================================================
 
-Node.js 18.18.2
+Node.js 18.19.1
 
 Node.js is licensed for use as follows:
 
@@ -594,19 +594,30 @@ The externally maintained libraries used by Node.js are:
 
 - c-ares, located at deps/cares, is licensed as follows:
   """
-    Copyright (c) 2007 - 2018, Daniel Stenberg with many contributors, see AUTHORS
+    MIT License
+
+    Copyright (c) 1998 Massachusetts Institute of Technology
+    Copyright (c) 2007 - 2023 Daniel Stenberg with many contributors, see AUTHORS
     file.
 
-    Copyright 1998 by the Massachusetts Institute of Technology.
+    Permission is hereby granted, free of charge, to any person obtaining a copy of
+    this software and associated documentation files (the "Software"), to deal in
+    the Software without restriction, including without limitation the rights to
+    use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+    the Software, and to permit persons to whom the Software is furnished to do so,
+    subject to the following conditions:
+
+    The above copyright notice and this permission notice (including the next
+    paragraph) shall be included in all copies or substantial portions of the
+    Software.
 
-    Permission to use, copy, modify, and distribute this software and its
-    documentation for any purpose and without fee is hereby granted, provided that
-    the above copyright notice appear in all copies and that both that copyright
-    notice and this permission notice appear in supporting documentation, and that
-    the name of M.I.T. not be used in advertising or publicity pertaining to
-    distribution of the software without specific, written prior permission.
-    M.I.T. makes no representations about the suitability of this software for any
-    purpose.  It is provided "as is" without express or implied warranty.
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+    SOFTWARE.
   """
 
 - cjs-module-lexer, located at deps/cjs-module-lexer, is licensed as follows:
@@ -1845,7 +1856,7 @@ The externally maintained libraries used by Node.js are:
 
 - ada, located at deps/ada, is licensed as follows:
   """
-    Copyright 2023 Ada authors
+    Copyright 2023 Yagiz Nizipli and Daniel Lemire
 
     Permission is hereby granted, free of charge, to any person obtaining a copy of
     this software and associated documentation files (the "Software"), to deal in

CHANGELOG.md

@@ -5,6 +5,9 @@ The main focus is on user-observable behavior of the engine.
 Changelog may include unreleased versions.
 See [release calendar](https://www.graalvm.org/release-calendar/) for release dates.
 
+## Version 24.0.1
+* Updated Node.js to version 18.19.1.
+
 ## Version 24.0.0
 * Implemented the [WebAssembly threads](https://github.com/WebAssembly/threads) proposal.
 * Implemented the [Promise.withResolvers](https://github.com/tc39/proposal-promise-with-resolvers) proposal. It is available in ECMAScript staging mode (`--js.ecmascript-version=staging`).

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/AtomicsBuiltins.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -125,6 +125,7 @@
 public final class AtomicsBuiltins extends JSBuiltinsContainer.SwitchEnum<AtomicsBuiltins.Atomics> {
 
     public static final JSBuiltinsContainer BUILTINS = new AtomicsBuiltins();
+    public static final JSBuiltinsContainer WAIT_ASYNC_BUILTINS = new WaitAsyncBuiltins();
 
     protected AtomicsBuiltins() {
         super(JSRealm.ATOMICS_CLASS_NAME, Atomics.class);
@@ -143,10 +144,7 @@ public enum Atomics implements BuiltinEnum<Atomics> {
         wait(4),
         isLockFree(1),
 
-        notify(3), // ES2019
-
-        // Stage 3
-        waitAsync(4);
+        notify(3);
 
         private final int length;
 
@@ -163,8 +161,6 @@ public int getLength() {
         public int getECMAScriptVersion() {
             if (this.equals(notify)) {
                 return JSConfig.ECMAScript2019;
-            } else if (this.equals(waitAsync)) {
-                return JSConfig.StagingECMAScriptVersion;
             }
             return JSConfig.ECMAScript2017;
         }
@@ -198,12 +194,41 @@ protected Object createNode(JSContext context, JSBuiltin builtin, boolean constr
                 return AtomicsWaitNodeGen.create(context, builtin, args().fixedArgs(4).createArgumentNodes(context));
             case isLockFree:
                 return AtomicsIsLockFreeNodeGen.create(context, builtin, args().fixedArgs(1).createArgumentNodes(context));
-            case waitAsync:
-                return AtomicsWaitAsyncNodeGen.create(context, builtin, args().fixedArgs(4).createArgumentNodes(context));
         }
         return null;
     }
 
+    public static final class WaitAsyncBuiltins extends JSBuiltinsContainer.SwitchEnum<WaitAsyncBuiltins.WaitAsync> {
+
+        protected WaitAsyncBuiltins() {
+            super(WaitAsync.class);
+        }
+
+        public enum WaitAsync implements BuiltinEnum<WaitAsync> {
+            waitAsync(4);
+
+            private final int length;
+
+            WaitAsync(int length) {
+                this.length = length;
+            }
+
+            @Override
+            public int getLength() {
+                return length;
+            }
+        }
+
+        @Override
+        protected Object createNode(JSContext context, JSBuiltin builtin, boolean construct, boolean newTarget, WaitAsync builtinEnum) {
+            return switch (builtinEnum) {
+                case waitAsync -> AtomicsWaitAsyncNodeGen.create(context, builtin, args().fixedArgs(4).createArgumentNodes(context));
+                default -> null;
+            };
+        }
+
+    }
+
     @ImportStatic(JSArrayBufferView.class)
     public abstract static class AtomicsOperationNode extends JSBuiltinNode {
 

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/GraalJSException.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -255,6 +255,11 @@ public void setJSStackTrace(JSStackTraceElement[] jsStackTrace) {
     @TruffleBoundary
     public static JSStackTraceElement[] getJSStackTrace(Node originatingNode) {
         int stackTraceLimit = JavaScriptLanguage.get(originatingNode).getJSContext().getLanguageOptions().stackTraceLimit();
+        return getJSStackTrace(originatingNode, stackTraceLimit);
+    }
+
+    @TruffleBoundary
+    public static JSStackTraceElement[] getJSStackTrace(Node originatingNode, int stackTraceLimit) {
         return UserScriptException.createCapture("", originatingNode, stackTraceLimit).getJSStackTrace();
     }
 

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSContextOptions.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -549,6 +549,11 @@ public Map<String, String> apply(String value) {
     public static final OptionKey<Boolean> NEW_SET_METHODS = new OptionKey<>(false);
     @CompilationFinal private boolean newSetMethods;
 
+    public static final String ATOMICS_WAIT_ASYNC_NAME = JS_OPTION_PREFIX + "atomics-wait-async";
+    @Option(name = ATOMICS_WAIT_ASYNC_NAME, category = OptionCategory.EXPERT, help = "Enable Atomics.waitAsync.") //
+    public static final OptionKey<Boolean> ATOMICS_WAIT_ASYNC = new OptionKey<>(false);
+    @CompilationFinal private boolean atomicsWaitAsync;
+
     public static final String TEMPORAL_NAME = JS_OPTION_PREFIX + "temporal";
     @Option(name = TEMPORAL_NAME, category = OptionCategory.EXPERT, help = "Enable JavaScript Temporal API.") //
     public static final OptionKey<Boolean> TEMPORAL = new OptionKey<>(false);
@@ -746,6 +751,7 @@ private void cacheOptions(SandboxPolicy sandboxPolicy) {
         this.webAssembly = readBooleanOption(WEBASSEMBLY);
         this.unhandledRejectionsMode = readUnhandledRejectionsMode();
         this.newSetMethods = readBooleanOption(NEW_SET_METHODS);
+        this.atomicsWaitAsync = ATOMICS_WAIT_ASYNC.hasBeenSet(optionValues) ? readBooleanOption(ATOMICS_WAIT_ASYNC) : getEcmaScriptVersion() >= JSConfig.ECMAScript2024;
         this.asyncIteratorHelpers = getEcmaScriptVersion() >= JSConfig.ECMAScript2018 && readBooleanOption(ASYNC_ITERATOR_HELPERS);
         this.iteratorHelpers = getEcmaScriptVersion() >= JSConfig.ECMAScript2018 && (this.asyncIteratorHelpers || readBooleanOption(ITERATOR_HELPERS));
         this.shadowRealm = getEcmaScriptVersion() >= JSConfig.ECMAScript2015 && readBooleanOption(SHADOW_REALM);
@@ -1139,6 +1145,10 @@ public boolean isNewSetMethods() {
         return newSetMethods;
     }
 
+    public boolean isAtomicsWaitAsync() {
+        return atomicsWaitAsync;
+    }
+
     public boolean isIteratorHelpers() {
         return iteratorHelpers;
     }

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSRealm.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -2402,6 +2402,9 @@ private JSDynamicObject createAtomics() {
         JSObject obj = JSObjectUtil.createOrdinaryPrototypeObject(this, this.getObjectPrototype());
         JSObjectUtil.putToStringTag(obj, ATOMICS_CLASS_NAME);
         JSObjectUtil.putFunctionsFromContainer(this, obj, AtomicsBuiltins.BUILTINS);
+        if (getContextOptions().isAtomicsWaitAsync()) {
+            JSObjectUtil.putFunctionsFromContainer(this, obj, AtomicsBuiltins.WAIT_ASYNC_BUILTINS);
+        }
         return obj;
     }
 

graal-nodejs/.eslintignore

@@ -8,5 +8,7 @@ tools/lint-md/lint-md.mjs
 benchmark/tmp
 benchmark/fixtures
 doc/**/*.js
+doc/changelogs/CHANGELOG_v1*.md
+!doc/changelogs/CHANGELOG_v18.md
 !doc/api_assets/*.js
 !.eslintrc.js

graal-nodejs/.eslintrc.js

@@ -18,7 +18,7 @@ const hacks = [
   'eslint-plugin-jsdoc',
   'eslint-plugin-markdown',
   '@babel/eslint-parser',
-  '@babel/plugin-syntax-import-assertions',
+  '@babel/plugin-syntax-import-attributes',
 ];
 Module._findPath = (request, paths, isMain) => {
   const r = ModuleFindPath(request, paths, isMain);
@@ -44,7 +44,10 @@ module.exports = {
   parserOptions: {
     babelOptions: {
       plugins: [
-        Module._findPath('@babel/plugin-syntax-import-assertions'),
+        [
+          Module._findPath('@babel/plugin-syntax-import-attributes'),
+          { deprecatedAssertSyntax: true },
+        ],
       ],
     },
     requireConfigFile: false,
@@ -53,10 +56,10 @@ module.exports = {
   overrides: [
     {
       files: [
-        'test/es-module/test-esm-type-flag.js',
-        'test/es-module/test-esm-type-flag-alias.js',
         '*.mjs',
         'test/es-module/test-esm-example-loader.js',
+        'test/es-module/test-esm-type-flag.js',
+        'test/es-module/test-esm-type-flag-alias.js',
       ],
       parserOptions: { sourceType: 'module' },
     },
@@ -111,6 +114,22 @@ module.exports = {
         },
       ] },
     },
+    {
+      files: [
+        'lib/internal/modules/**/*.js',
+      ],
+      rules: {
+        'curly': 'error',
+      },
+    },
+    {
+      files: [
+        'lib/internal/test_runner/**/*.js',
+      ],
+      rules: {
+        'node-core/set-proto-to-null-in-object': 'error',
+      },
+    },
   ],
   rules: {
     // ESLint built-in rules

graal-nodejs/.github/CODEOWNERS

@@ -11,17 +11,19 @@
 # tsc
 
 /.github/CODEOWNERS @nodejs/tsc
+/.github/PULL_REQUEST_TEMPLATE.md @nodejs/tsc
+/.github/ISSUE_TEMPLATE/* @nodejs/tsc
 /CODE_OF_CONDUCT.md @nodejs/tsc
 /CONTRIBUTING.md @nodejs/tsc
 /doc/contributing/*.md @nodejs/tsc
 /GOVERNANCE.md @nodejs/tsc
 /LICENSE @nodejs/tsc
 /onboarding.md @nodejs/tsc
 
-# website
-/doc/api_assets @nodejs/website
-/doc/template.html @nodejs/website
-/tools/doc @nodejs/website
+# nodejs.org website
+/doc/api_assets @nodejs/nodejs-website
+/doc/template.html @nodejs/nodejs-website
+/tools/doc @nodejs/web-infra
 
 # streams
 
@@ -85,16 +87,16 @@
 
 # modules, including loaders
 
-/doc/api/esm.md @nodejs/modules @nodejs/loaders
-/doc/api/module.md @nodejs/modules @nodejs/loaders
-/doc/api/modules.md @nodejs/modules @nodejs/loaders
-/doc/api/packages.md @nodejs/modules @nodejs/loaders
-/lib/internal/bootstrap/loaders.js @nodejs/modules @nodejs/loaders
-/lib/internal/modules/* @nodejs/modules @nodejs/loaders
-/lib/internal/process/esm_loader.js @nodejs/modules @nodejs/loaders
-/lib/internal/process/execution.js @nodejs/modules @nodejs/loaders
-/lib/module.js @nodejs/modules @nodejs/loaders
-/src/module_wrap* @nodejs/modules @nodejs/loaders @nodejs/vm
+/doc/api/esm.md @nodejs/loaders
+/doc/api/module.md @nodejs/loaders
+/doc/api/modules.md @nodejs/loaders
+/doc/api/packages.md @nodejs/loaders
+/lib/internal/bootstrap/realm.js @nodejs/loaders
+/lib/internal/modules/* @nodejs/loaders
+/lib/internal/process/esm_loader.js @nodejs/loaders
+/lib/internal/process/execution.js @nodejs/loaders
+/lib/module.js @nodejs/loaders
+/src/module_wrap* @nodejs/loaders @nodejs/vm
 
 # Node-API
 
@@ -146,6 +148,7 @@
 /lib/internal/main/test_runner.js @nodejs/test_runner
 /lib/internal/test_runner/* @nodejs/test_runner
 /lib/test.js @nodejs/test_runner
+/lib/test/reporters.js @nodejs/test_runner
 /test/parallel/test-runner-* @nodejs/test_runner
 
 # Single Executable Applications

graal-nodejs/.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,18 @@
 <!--
-Before submitting a pull request, please read
-https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.
+Before submitting a pull request, please read:
 
-Commit message formatting guidelines:
-https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
+- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
+- the commit message formatting guidelines at
+  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
 
 For code changes:
 1. Include tests for any bug fixes or new features.
 2. Update documentation if relevant.
 3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.
 
+If you believe this PR should be highlighted in the Node.js CHANGELOG
+please add the `notable-change` label.
+
 Developer's Certificate of Origin 1.1
 
 By making a contribution to this project, I certify that: