[GR-63022] Make source phase imports stable.

PullRequest: js/3542

Author: woess

CHANGELOG.md

@@ -12,6 +12,7 @@ See [release calendar](https://www.graalvm.org/release-calendar/) for release da
 * Made option `js.text-encoding` stable and allowed in `SandboxPolicy.CONSTRAINED`.
 * Implemented the [`import defer`](https://github.com/tc39/proposal-defer-import-eval) proposal. It is available in ECMAScript staging mode (`--js.ecmascript-version=staging`).
 * Implemented the [`Upsert`](https://github.com/tc39/proposal-upsert) proposal. It is available in ECMAScript staging mode (`--js.ecmascript-version=staging`).
+* Enabled source phase imports from WebAssembly modules (`import source mod from "./mod.wasm"`) by default if the `js.webassembly` option is enabled and the `js.source-phase-imports` option is not explicitly set to `false`.
 
 ## Version 24.2.0
 * Updated Node.js to version 22.13.1.

graal-js/src/com.oracle.truffle.js.test/wasm/source-phase-import-default.mjs

@@ -0,0 +1,16 @@
+/*
+ * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+ */
+
+/**
+ * Tests that source phase imports are enabled by default if js.webassembly=true.
+ *
+ * @option webassembly=true
+ * @option unhandled-rejections=throw
+ */
+
+import "./source-phase-import.mjs";
+import "./source-phase-import-dynamic.mjs";

graal-js/src/com.oracle.truffle.js.test/wasm/source-phase-import-disabled.mjs

@@ -0,0 +1,31 @@
+/*
+ * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+ */
+
+/**
+ * Tests that source phase imports can be disabled explicitly.
+ *
+ * @option webassembly=true
+ * @option source-phase-imports=false
+ * @option unhandled-rejections=throw
+ */
+
+try {
+    await import("./source-phase-import.mjs");
+    throw new Error("should have thrown a SyntaxError");
+} catch (e) {
+    if (!(e instanceof SyntaxError)) {
+        throw e;
+    }
+}
+try {
+    await import("./source-phase-import-dynamic.mjs");
+    throw new Error("should have thrown a SyntaxError");
+} catch (e) {
+    if (!(e instanceof SyntaxError)) {
+        throw e;
+    }
+}

graal-js/src/com.oracle.truffle.js.test/wasm/source-phase-import-dynamic.mjs

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
@@ -8,8 +8,9 @@
 /**
  * Test source phase imports.
  *
- * @option webassembly
- * @option source-phase-imports
+ * @option webassembly=true
+ * @option source-phase-imports=true
+ * @option unhandled-rejections=throw
  */
 
 const wasmModule = await import.source("./source-phase-import.wasm");

graal-js/src/com.oracle.truffle.js.test/wasm/source-phase-import.mjs

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
@@ -8,8 +8,8 @@
 /**
  * Test source phase imports.
  *
- * @option webassembly
- * @option source-phase-imports
+ * @option webassembly=true
+ * @option source-phase-imports=true
  */
 
 import source wasmModule from "./source-phase-import.wasm";

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSContextOptions.java

@@ -664,7 +664,10 @@ public String toString() {
     @CompilationFinal private boolean jsonModules;
 
     public static final String SOURCE_PHASE_IMPORTS_NAME = JS_OPTION_PREFIX + "source-phase-imports";
-    @Option(name = SOURCE_PHASE_IMPORTS_NAME, category = OptionCategory.USER, help = "Enable source phase imports proposal") //
+    @Option(name = SOURCE_PHASE_IMPORTS_NAME, category = OptionCategory.USER, help = "" +
+                    "Enable source phase imports (`import source` and `import.source()`). " +
+                    "If this option is not set and " + WEBASSEMBLY_NAME + "=true, " +
+                    "source phase imports from WebAssembly modules are enabled by default.") //
     public static final OptionKey<Boolean> SOURCE_PHASE_IMPORTS = new OptionKey<>(false);
     @CompilationFinal private boolean sourcePhaseImports;
 
@@ -821,7 +824,7 @@ private void cacheOptions(SandboxPolicy sandboxPolicy) {
         this.importAttributes = readBooleanOption(IMPORT_ATTRIBUTES, JSConfig.ECMAScript2025);
         this.importAssertions = readBooleanOption(IMPORT_ASSERTIONS);
         this.jsonModules = readBooleanOption(JSON_MODULES, JSConfig.ECMAScript2025);
-        this.sourcePhaseImports = readBooleanOption(SOURCE_PHASE_IMPORTS);
+        this.sourcePhaseImports = SOURCE_PHASE_IMPORTS.hasBeenSet(optionValues) ? readBooleanOption(SOURCE_PHASE_IMPORTS) : webAssembly;
         this.wasmBigInt = readBooleanOption(WASM_BIG_INT);
         this.esmEvalReturnsExports = readBooleanOption(ESM_EVAL_RETURNS_EXPORTS);
         this.printNoNewline = readBooleanOption(PRINT_NO_NEWLINE);