Avoiding a potential AssertionError from array hole counting.

iamstolis · woess · commit da76bcfe905a · 2023-09-11T14:11:05.000+02:00
diff --git a/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/array/dyn/AbstractWritableArray.java b/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/array/dyn/AbstractWritableArray.java
@@ -684,8 +684,8 @@ ScriptArray addRangeImplContiguous(JSDynamicObject object, long offset, int size
                     if (isHolesType()) {
                         arraySetHoleCount(object, arrayGetHoleCount(object) + size);
                     }
+                    arraySetUsedLength(object, usedLength + size);
                 }
-                arraySetUsedLength(object, usedLength + size);
                 return this;
             } else {
                 return addRangeGrow(object, array, arrayLength, usedLength, lengthInt(object), (int) (offset - indexOffset), size, arrayOffset, indexOffset);

Original file line number	Diff line number	Diff line change
`@@ -684,8 +684,8 @@ ScriptArray addRangeImplContiguous(JSDynamicObject object, long offset, int size`
`684`	`684`	`if (isHolesType()) {`
`685`	`685`	`arraySetHoleCount(object, arrayGetHoleCount(object) + size);`
`686`	`686`	`}`
	`687`	`+ arraySetUsedLength(object, usedLength + size);`
`687`	`688`	`}`
`688`		`- arraySetUsedLength(object, usedLength + size);`
`689`	`689`	`return this;`
`690`	`690`	`} else {`
`691`	`691`	`return addRangeGrow(object, array, arrayLength, usedLength, lengthInt(object), (int) (offset - indexOffset), size, arrayOffset, indexOffset);`