[GR-37536] PropertySetNode with setOwnProperty should behave like CreateDataProperty.

PullRequest: js/2379

Author: iamstolis

graal-js/src/com.oracle.truffle.js.test/js/GR-37536.js

@@ -0,0 +1,14 @@
+/*
+ * Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+ */
+
+load('assert.js');
+
+class C { static name = 'foo'; }
+assertSame('foo', C.name);
+
+class D { static length = 42; }
+assertSame(42, D.length);

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/access/PropertySetNode.java

@@ -1033,6 +1033,13 @@ private SetCacheNode createCachedPropertyNodeJSObject(Property property, JSDynam
         Shape cacheShape = thisObj.getShape();
         AbstractShapeCheckNode shapeCheck = createShapeCheckNode(cacheShape, thisObj, depth, false, false);
 
+        // isOwnProperty() means CreateDataProperty, i.e., we must redefine
+        // the property when the current flags do not match data property and
+        // when it is possible to do so (i.e. when it is configurable)
+        if (isOwnProperty() && JSAttributes.isConfigurable(property.getFlags()) && JSAttributes.configurableEnumerableWritable() != property.getFlags()) {
+            return new DataPropertyPutWithFlagsNode(key, shapeCheck);
+        }
+
         if (JSProperty.isData(property)) {
             return createCachedDataPropertyNodeJSObject(thisObj, depth, value, shapeCheck, property);
         } else {