[GR-51016] Enable WebAssembly by default in Node.js.

PullRequest: js/3013

Author: woess

CHANGELOG.md

@@ -12,6 +12,7 @@ See [release calendar](https://www.graalvm.org/release-calendar/) for release da
 * Implemented the [Well-Formed Unicode Strings](https://github.com/tc39/proposal-is-usv-string) proposal. It is available in ECMAScript staging mode (`--js.ecmascript-version=staging`).
 * Implemented the [JSON.parse source text access](https://github.com/tc39/proposal-json-parse-with-source) proposal. It is available in ECMAScript staging mode (`--js.ecmascript-version=staging`).
 * Updated Node.js to version 18.18.2.
+* WebAssembly support in Node.js has been enabled by default. It can be disabled using the experimental option `--js.webassembly=false`.
 * `--js.import-assertions` option has been replaced by `--js.import-attributes` option because [the corresponding proposal](https://github.com/tc39/proposal-import-attributes) has migrated from the usage of assertions to the usage of attributes.
 
 ## Version 23.1.0

graal-nodejs/mx.graal-nodejs/com.oracle.truffle.trufflenode/src/com/oracle/truffle/trufflenode/Options.java

@@ -40,12 +40,11 @@
  */
 package com.oracle.truffle.trufflenode;
 
+import java.io.OutputStream;
 import java.net.URL;
 import java.net.URLClassLoader;
 import java.nio.file.Path;
 import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
@@ -119,20 +118,22 @@ public static class OptionsParser extends AbstractLanguageLauncher implements Fu
         private static final String INSPECT = "inspect";
         private static final String INSPECT_SUSPEND = "inspect.Suspend";
         private static final String INSPECT_WAIT_ATTACHED = "inspect.WaitAttached";
+        private static final String WASM_LANGUAGE_ID = "wasm";
 
         private Context.Builder contextBuilder;
         private boolean exposeGC;
         private boolean polyglot;
         private boolean unsafeWasmMemory;
         private boolean auxEngineCacheMode;
+        private boolean wasmEnabled;
 
-        private static final Set<String> AUX_CACHE_OPTIONS = new HashSet<>(Arrays.asList("engine.Cache",
+        private static final Set<String> AUX_CACHE_OPTIONS = Set.of("engine.Cache",
                         "engine.CacheLoad",
-                        "engine.CacheStore"));
+                        "engine.CacheStore");
 
         // Options that should not be passed to polyglot engine (they are processed
         // elsewhere or can be ignored without almost any harm).
-        private static final Set<String> IGNORED_OPTIONS = new HashSet<>(Arrays.asList(new String[]{
+        private static final Set<String> IGNORED_OPTIONS = Set.of(new String[]{
                         "debug-code",
                         "es-staging",
                         "experimental-modules",
@@ -158,7 +159,7 @@ public static class OptionsParser extends AbstractLanguageLauncher implements Fu
                         "nouse-idle-notification",
                         "stack-size",
                         "use-idle-notification"
-        }));
+        });
 
         @Override
         public Object[] apply(String[] args) {
@@ -189,7 +190,7 @@ protected List<String> preprocessArguments(List<String> arguments, Map<String, S
             polyglotOptions.put("js.string-length-limit", Integer.toString((1 << 29) - 24)); // v8::String::kMaxLength
 
             List<String> unprocessedArguments = new ArrayList<>();
-            boolean optWebAssembly = false;
+            Boolean optWebAssembly = null;
             Boolean optUnsafeWasmMemory = null;
             for (String arg : arguments) {
                 String key = "";
@@ -298,10 +299,18 @@ protected List<String> preprocessArguments(List<String> arguments, Map<String, S
                 }
                 unprocessedArguments.add(arg);
             }
-            if (optWebAssembly) {
-                if (optUnsafeWasmMemory == null && polyglot && isLanguageAvailable("wasm")) {
-                    optUnsafeWasmMemory = Boolean.TRUE;
-                    polyglotOptions.put("wasm.UseUnsafeMemory", "true");
+            if (optWebAssembly != Boolean.FALSE) {
+                // WebAssembly is enabled by default, if available.
+                if (isWasmAvailable()) {
+                    wasmEnabled = true;
+                    if (optWebAssembly == null) {
+                        optWebAssembly = Boolean.TRUE;
+                        polyglotOptions.put("js.webassembly", "true");
+                    }
+                    if (optWebAssembly && optUnsafeWasmMemory == null) {
+                        optUnsafeWasmMemory = Boolean.TRUE;
+                        polyglotOptions.put("wasm.UseUnsafeMemory", "true");
+                    }
                 }
                 if (optUnsafeWasmMemory == Boolean.TRUE) {
                     unsafeWasmMemory = true;
@@ -339,14 +348,15 @@ protected void printHelp(OptionCategory maxCategory) {
             System.out.println();
             System.out.println("Usage: node [options] [ -e script | script.js ] [arguments]\n");
             System.out.println("Basic Options:");
-            printOption("-v, --version",         "print version");
-            printOption("-e, --eval script",     "evaluate script");
-            printOption("-p, --print",           "evaluate script and print result");
+            printOption("-v, --version",         "print Node.js version");
+            printOption("-e, --eval=...",        "evaluate script");
+            printOption("-p, --print [...]",     "evaluate script and print result");
             printOption("-c, --check",           "syntax check script without executing");
             printOption("-i, --interactive",     "always enter the REPL even if stdin does not appear to be a terminal");
-            printOption("-r, --require",         "module to preload (option can be repeated)");
+            printOption("-r, --require=...",     "CommonJS module to preload (option can be repeated)");
             printOption("--inspect[=port]",      "activate inspector on port (overrides options of Chrome Inspector)");
             printOption("--inspect-brk[=port]",  "activate inspector on port and break at start of user script (overrides options of Chrome Inspector)");
+            // @formatter:on
         }
 
         private static void printOption(String option, String description) {
@@ -362,11 +372,26 @@ private static void printOption(String option, String description) {
 
         @Override
         protected String[] getDefaultLanguages() {
-            return polyglot ? new String[0] : super.getDefaultLanguages();
+            if (polyglot) {
+                return new String[0];
+            } else if (wasmEnabled) {
+                assert isWasmAvailable() : "wasm not available";
+                return new String[]{getLanguageId(), WASM_LANGUAGE_ID};
+            } else {
+                return super.getDefaultLanguages();
+            }
+        }
+
+        private static boolean isWasmAvailable() {
+            return isLanguageAvailable(WASM_LANGUAGE_ID);
         }
 
-         static boolean isLanguageAvailable(String languageId) {
-            try (Engine tempEngine = Engine.newBuilder().useSystemProperties(false).build()) {
+        private static boolean isLanguageAvailable(String languageId) {
+            try (Engine tempEngine = Engine.newBuilder().useSystemProperties(false).//
+                            out(OutputStream.nullOutputStream()).//
+                            err(OutputStream.nullOutputStream()).//
+                            option("engine.WarnInterpreterOnly", "false").//
+                            build()) {
                 return tempEngine.getLanguages().containsKey(languageId);
             }
         }

graal-nodejs/mx.graal-nodejs/mx_graal_nodejs.py

@@ -71,9 +71,6 @@ def _graal_nodejs_post_gate_runner(args, tasks):
                 npm(['--scripts-prepend-node-path=auto', 'test'] + commonArgs + testArgs, cwd=unitTestDir)
                 if mx.suite('wasm', fatalIfMissing=False):
                     npm(['--scripts-prepend-node-path=auto', 'run', 'testwasm'] + commonArgs + testArgs, cwd=unitTestDir)
-                    # test that WebAssembly can be enabled using env. variables
-                    _setEnvVar('NODE_OPTIONS', '--polyglot')
-                    _setEnvVar('NODE_POLYGLOT_OPTIONS', '--js.webassembly --experimental-options')
                     node(commonArgs + ['-e', 'console.log(WebAssembly)'])
                     # check that fetch API is available when WebAssembly is available
                     node(commonArgs + ['-e', 'FormData'])
@@ -88,8 +85,17 @@ def _graal_nodejs_post_gate_runner(args, tasks):
                     ]
                     for test in wasm_tests:
                         node(commonArgs + [join(_suite.dir, 'test', 'parallel', test)])
-                    _setEnvVar('NODE_OPTIONS', '')
+
+                    # test that WebAssembly can be disabled using env. variables
+                    _setEnvVar('NODE_POLYGLOT_OPTIONS', '--js.webassembly=false --experimental-options')
+                    out = mx.OutputCapture()
+                    node(commonArgs + ['-p', 'try { WebAssembly; } catch (e) { e.toString(); }'], out=out)
+                    assert out.data.strip() == "ReferenceError: WebAssembly is not defined", out.data
                     _setEnvVar('NODE_POLYGLOT_OPTIONS', '')
+                else:
+                    out = mx.OutputCapture()
+                    node(commonArgs + ['-p', 'try { WebAssembly; } catch (e) { e.toString(); }'], out=out)
+                    assert out.data.strip() == "ReferenceError: WebAssembly is not defined", out.data
 
                 mx_gate.make_test_report(jsonResultsFile, task=t.title)
             finally:

graal-nodejs/test/graal/package.json

@@ -10,6 +10,6 @@
   "scripts": {
     "install": "node-gyp rebuild",
     "test": "node --expose-gc index.js",
-    "testwasm": "node --experimental-options --polyglot --js.webassembly=true --expose-gc index.js"
+    "testwasm": "node --experimental-options --js.webassembly=true --expose-gc index.js"
   }
 }