All implementations of incrementHolesCount are the same.

Author: woess

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/array/dyn/AbstractWritableArray.java

@@ -204,8 +204,9 @@ protected final int prepareSupportedHoles(JSDynamicObject object, int index, Nod
     }
 
     @SuppressWarnings("unused")
-    protected void incrementHolesCount(JSDynamicObject object, int offset) {
-        throw Errors.shouldNotReachHere();
+    protected final void incrementHolesCount(JSDynamicObject object, int offset) {
+        assert isHolesType();
+        arraySetHoleCount(object, arrayGetHoleCount(object) + offset);
     }
 
     protected abstract void setHoleValue(JSDynamicObject object, int index);

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/array/dyn/HolesDoubleArray.java

@@ -143,11 +143,6 @@ public AbstractDoubleArray toNonHoles(JSDynamicObject object, long index, Object
         return newArray;
     }
 
-    @Override
-    protected void incrementHolesCount(JSDynamicObject object, int offset) {
-        arraySetHoleCount(object, arrayGetHoleCount(object) + offset);
-    }
-
     @Override
     public boolean isSupported(JSDynamicObject object, long index) {
         return isSupportedHoles(object, index);

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/array/dyn/HolesIntArray.java

@@ -161,11 +161,6 @@ public Object getInBoundsFast(JSDynamicObject object, int index) {
         return value;
     }
 
-    @Override
-    protected void incrementHolesCount(JSDynamicObject object, int offset) {
-        arraySetHoleCount(object, arrayGetHoleCount(object) + offset);
-    }
-
     @Override
     public HolesIntArray toHoles(JSDynamicObject object, long index, Object value) {
         return this;

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/array/dyn/HolesJSObjectArray.java

@@ -154,11 +154,6 @@ public AbstractWritableArray toObject(JSDynamicObject object, long index, Object
         return newArray;
     }
 
-    @Override
-    protected void incrementHolesCount(JSDynamicObject object, int offset) {
-        arraySetHoleCount(object, arrayGetHoleCount(object) + offset);
-    }
-
     @Override
     public int prepareInBounds(JSDynamicObject object, int index, Node node, SetSupportedProfileAccess profile) {
         return prepareInBoundsHoles(object, index, node, profile);

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/array/dyn/HolesObjectArray.java

@@ -136,11 +136,6 @@ public AbstractObjectArray toNonHoles(JSDynamicObject object, long index, Object
         return newArray;
     }
 
-    @Override
-    protected void incrementHolesCount(JSDynamicObject object, int offset) {
-        arraySetHoleCount(object, arrayGetHoleCount(object) + offset);
-    }
-
     @Override
     public int prepareInBounds(JSDynamicObject object, int index, Node node, SetSupportedProfileAccess profile) {
         return prepareInBoundsHoles(object, index, node, profile);