Do not return nullptr from v8::HeapProfiler::TakeHeapSnapshot().

iamstolis · iamstolis · commit f7fdbe96a813 · 2024-04-21T15:49:59.000+02:00
diff --git a/graal-nodejs/deps/v8/src/graal/v8.cc b/graal-nodejs/deps/v8/src/graal/v8.cc
@@ -475,7 +475,7 @@ namespace v8 {
 
     const HeapSnapshot* HeapProfiler::TakeHeapSnapshot(ActivityControl* control, ObjectNameResolver* global_object_name_resolver, bool treat_global_objects_as_roots, bool capture_numeric_value) {
         TRACE
-        return nullptr;
+        return new HeapSnapshot();
     }
 
     SnapshotObjectId HeapProfiler::GetHeapStats(OutputStream* stream, int64_t* timestamp_us) {

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ namespace v8 {`
`475`	`475`
`476`	`476`	`const HeapSnapshot* HeapProfiler::TakeHeapSnapshot(ActivityControl* control, ObjectNameResolver* global_object_name_resolver, bool treat_global_objects_as_roots, bool capture_numeric_value) {`
`477`	`477`	`TRACE`
`478`		`- return nullptr;`
	`478`	`+ return new HeapSnapshot();`
`479`	`479`	`}`
`480`	`480`
`481`	`481`	`SnapshotObjectId HeapProfiler::GetHeapStats(OutputStream* stream, int64_t* timestamp_us) {`