Skip to content

Commit fa4d932

Browse files
committed
Adding HandleScope also for the primary weak callback.
1 parent f34735d commit fa4d932

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

graal-nodejs/deps/v8/src/graal/callbacks.cc

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,10 @@ void GraalWeakCallback(JNIEnv* env, jclass nativeAccess, jlong callback, jlong d
622622
v8::WeakCallbackInfo<void>::Callback second_callback = nullptr;
623623
v8::Isolate* isolate = v8::Isolate::GetCurrent();
624624
v8::WeakCallbackInfo<void> callback_info = v8::WeakCallbackInfo<void>(isolate, (void*) data, internalFields, &second_callback);
625-
v8_callback(callback_info);
625+
{
626+
v8::HandleScope scope(isolate);
627+
v8_callback(callback_info);
628+
}
626629
if (second_callback) {
627630
v8::HandleScope scope(isolate);
628631
second_callback(callback_info);
@@ -633,7 +636,10 @@ void GraalWeakCallback(JNIEnv* env, jclass nativeAccess, jlong callback, jlong d
633636
v8::WeakCallbackInfo<void>::Callback second_callback = nullptr;
634637
v8::Isolate* isolate = v8::Isolate::GetCurrent();
635638
v8::WeakCallbackInfo<void> callback_info = v8::WeakCallbackInfo<void>(isolate, internalFields[v8::kInternalFieldsInWeakCallback], internalFields, &second_callback);
636-
v8_callback(callback_info);
639+
{
640+
v8::HandleScope scope(isolate);
641+
v8_callback(callback_info);
642+
}
637643
if (second_callback) {
638644
v8::HandleScope scope(isolate);
639645
second_callback(callback_info);

0 commit comments

Comments
 (0)