convert Temporal.Duration asDuration(), and test

Author: wirthi

graal-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/interop/TemporalInteropToJavaTest.java

@@ -43,6 +43,7 @@
 
 import static com.oracle.truffle.js.lang.JavaScriptLanguage.ID;
 
+import java.time.Duration;
 import java.time.Instant;
 import java.time.LocalDate;
 import java.time.LocalTime;
@@ -63,8 +64,7 @@ private static Context getJSContext() {
         return JSTest.newContextBuilder(ID).option("js.temporal", "true").build();
     }
 
-    // Calendar, Duration, PlainMonthDay, PlainYearMonth cannot be converted to Instant, Date or
-    // Time
+    // Calendar, PlainMonthDay, PlainYearMonth cannot be converted to Instant, Date or Time
 
     @Test
     public void testInstant() {
@@ -198,4 +198,30 @@ public void testZonedDateTime() {
             Assert.assertEquals("Europe/Vienna", zid.getId());
         }
     }
+
+    @Test
+    public void testDuration() {
+        try (Context ctx = getJSContext()) {
+            Value val = ctx.eval(ID, "Temporal.Duration.from('PT2H3M4.987654321S');");
+            Duration dur = val.asDuration();
+
+            long expectedSeconds = 2 * 60 * 60 + 3 * 60 + 4;
+            long expectedNanos = 987654321;
+            Assert.assertEquals(0, dur.toDays());
+            Assert.assertEquals(4, dur.toSecondsPart());
+            Assert.assertEquals(expectedSeconds, dur.toSeconds());
+            Assert.assertEquals(expectedNanos, dur.toNanosPart());
+            Assert.assertEquals(expectedSeconds * 1_000_000_000 + expectedNanos, dur.toNanos());
+
+            // invalid duration; java.time.Duration does not accept units larger or equals to DAY
+            val = ctx.eval(ID, "Temporal.Duration.from('P1Y');");
+            Assert.assertFalse(val.isDuration());
+            val = ctx.eval(ID, "Temporal.Duration.from('P2M');");
+            Assert.assertFalse(val.isDuration());
+            val = ctx.eval(ID, "Temporal.Duration.from('P3W');");
+            Assert.assertFalse(val.isDuration());
+            val = ctx.eval(ID, "Temporal.Duration.from('P4D');");
+            Assert.assertFalse(val.isDuration());
+        }
+    }
 }

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/temporal/JSTemporalDurationObject.java

@@ -40,9 +40,18 @@
  */
 package com.oracle.truffle.js.runtime.builtins.temporal;
 
+import java.time.Duration;
+
+import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
+import com.oracle.truffle.api.interop.InteropLibrary;
+import com.oracle.truffle.api.interop.UnsupportedMessageException;
+import com.oracle.truffle.api.library.ExportLibrary;
+import com.oracle.truffle.api.library.ExportMessage;
 import com.oracle.truffle.api.object.Shape;
+import com.oracle.truffle.js.runtime.JSRuntime;
 import com.oracle.truffle.js.runtime.objects.JSNonProxyObject;
 
+@ExportLibrary(InteropLibrary.class)
 public class JSTemporalDurationObject extends JSNonProxyObject {
 
     private final double years;
@@ -110,4 +119,31 @@ public double getMicroseconds() {
     public double getNanoseconds() {
         return nanoseconds;
     }
+
+    @ExportMessage
+    final boolean isDuration() {
+        // note: java.time.Duration only considers DAYS, while JS Temporal also has W, M, Y.
+        // due to vague DAYS support in Java, we disallow conversion when any of D, W, M, Y is != 0.
+        return years == 0 && months == 0 && weeks == 0 && days == 0 && JSRuntime.doubleIsRepresentableAsLong(calcSeconds()) && JSRuntime.doubleIsRepresentableAsLong(calcNanoseconds());
+    }
+
+    @ExportMessage
+    @TruffleBoundary
+    final Duration asDuration() throws UnsupportedMessageException {
+        if (!isDuration()) {
+            throw UnsupportedMessageException.create();
+        }
+        double sec = calcSeconds();
+        double nanos = calcNanoseconds();
+        Duration dur = Duration.ofSeconds((long) sec, (long) nanos);
+        return dur;
+    }
+
+    private double calcNanoseconds() {
+        return nanoseconds + microseconds * 1_000 + milliseconds * 1_000_000;
+    }
+
+    private double calcSeconds() {
+        return seconds + minutes * 60 + hours * 60 * 60;
+    }
 }