Store BuiltinMethodDescriptor in PBuiltinFunction to make AreSameCallable checks faster

Author: steve-s

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/BuiltinMethodDescriptor.java

@@ -177,8 +177,7 @@ public final <T extends NodeFactory<? extends PythonBuiltinBaseNode>> boolean is
     }
 
     public final boolean isDescriptorOf(PBuiltinFunction fun) {
-        assert fun.getEnclosingType() instanceof PythonBuiltinClassType;
-        return fun.getName().equals(name) && fun.getBuiltinNodeFactory() == getFactory() && fun.getEnclosingType() == type;
+        return fun.getDescriptor() == this;
     }
 
     public final PythonBuiltinClassType getEnclosingType() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/PBuiltinFunction.java

@@ -62,6 +62,7 @@ public final class PBuiltinFunction extends PythonBuiltinObject implements Bound
     private final RootCallTarget callTarget;
     private final Signature signature;
     private final int flags;
+    private BuiltinMethodDescriptor descriptor;
     @CompilationFinal(dimensions = 1) private final Object[] defaults;
     @CompilationFinal(dimensions = 1) private final PKeyword[] kwDefaults;
 
@@ -228,4 +229,12 @@ boolean hasExecutableName() {
     String getExecutableName() {
         return getName();
     }
+
+    public void setDescriptor(BuiltinMethodDescriptor descriptor) {
+        this.descriptor = descriptor;
+    }
+
+    public BuiltinMethodDescriptor getDescriptor() {
+        return descriptor;
+    }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/SpecialMethodSlot.java

@@ -140,6 +140,7 @@
 import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.NodeFactory;
+import com.oracle.truffle.api.memory.MemoryFence;
 import com.oracle.truffle.api.object.DynamicObject;
 import com.oracle.truffle.api.object.DynamicObjectLibrary;
 
@@ -650,9 +651,19 @@ private static void fixupSpecialMethodInSubClasses(java.util.Set<PythonAbstractC
 
     private static Object asSlotValue(SpecialMethodSlot slot, Object value, PythonLanguage language) {
         if (value instanceof PBuiltinFunction && slot.allowsBuiltinDescriptors) {
-            BuiltinMethodDescriptor info = BuiltinMethodDescriptor.get((PBuiltinFunction) value);
+            PBuiltinFunction builtinFun = (PBuiltinFunction) value;
+            BuiltinMethodDescriptor info = BuiltinMethodDescriptor.get(builtinFun);
             if (info != null) {
-                language.registerBuiltinDescriptorCallTarget(info, ((PBuiltinFunction) value).getCallTarget());
+                if (builtinFun.getDescriptor() == null) {
+                    // Note: number of all builtins >> number of builtins used in slots, so it is
+                    // better to do this lazily
+                    language.registerBuiltinDescriptorCallTarget(info, builtinFun.getCallTarget());
+                    // Only make sure that info is fully initialized, otherwise it is fine if it is
+                    // set multiple times from different threads, all of them should set the same
+                    // value
+                    MemoryFence.storeStore();
+                    builtinFun.setDescriptor(info);
+                }
                 return info;
             }
         }