Skip to content

Commit 05c02cd

Browse files
lukasstadlerfangerer
authored andcommitted
disable test_dict_version - exposes implementation detail
1 parent b4a2eb1 commit 05c02cd

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

graalpython/com.oracle.graal.python.cext/modules/_testcapi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5007,7 +5007,8 @@ dict_get_version(PyObject *self, PyObject *args)
50075007
if (!PyArg_ParseTuple(args, "O!", &PyDict_Type, &dict))
50085008
return NULL;
50095009

5010-
version = dict->ma_version_tag;
5010+
// version = dict->ma_version_tag;
5011+
version = 0; // GraalPy: dict versions is an implementation detail
50115012

50125013
Py_BUILD_ASSERT(sizeof(unsigned long long) >= sizeof(version));
50135014
return PyLong_FromUnsignedLongLong((unsigned long long)version);
Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +0,0 @@
1-
*graalpython.lib-python.3.test.test_dict_version.DictSubtypeVersionTests.test_clear
2-
*graalpython.lib-python.3.test.test_dict_version.DictSubtypeVersionTests.test_delitem
3-
*graalpython.lib-python.3.test.test_dict_version.DictSubtypeVersionTests.test_pop
4-
*graalpython.lib-python.3.test.test_dict_version.DictSubtypeVersionTests.test_popitem
5-
*graalpython.lib-python.3.test.test_dict_version.DictSubtypeVersionTests.test_setdefault
6-
*graalpython.lib-python.3.test.test_dict_version.DictVersionTests.test_clear
7-
*graalpython.lib-python.3.test.test_dict_version.DictVersionTests.test_delitem
8-
*graalpython.lib-python.3.test.test_dict_version.DictVersionTests.test_pop
9-
*graalpython.lib-python.3.test.test_dict_version.DictVersionTests.test_popitem
10-
*graalpython.lib-python.3.test.test_dict_version.DictVersionTests.test_setdefault

0 commit comments

Comments
 (0)