Skip to content

Commit 0650ac4

Browse files
committed
remove illegal use of stream api
- style fixes
1 parent 53ab3bb commit 0650ac4

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/code/CodeBuiltins.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ protected Object get(PCode self) {
150150
@GenerateNodeFactory
151151
public abstract static class GetFlagsNode extends PythonBuiltinNode {
152152
@Specialization
153-
protected Object get(PCode self) {
153+
protected Object get(@SuppressWarnings("unused") PCode self) {
154154
return PNotImplemented.NOT_IMPLEMENTED;
155155
}
156156
}
@@ -159,7 +159,7 @@ protected Object get(PCode self) {
159159
@GenerateNodeFactory
160160
public abstract static class GetCodeNode extends PythonBuiltinNode {
161161
@Specialization
162-
protected Object get(PCode self) {
162+
protected Object get(@SuppressWarnings("unused") PCode self) {
163163
return PNotImplemented.NOT_IMPLEMENTED;
164164
}
165165
}
@@ -168,7 +168,7 @@ protected Object get(PCode self) {
168168
@GenerateNodeFactory
169169
public abstract static class GetConstsNode extends PythonBuiltinNode {
170170
@Specialization
171-
protected Object get(PCode self) {
171+
protected Object get(@SuppressWarnings("unused") PCode self) {
172172
return PNotImplemented.NOT_IMPLEMENTED;
173173
}
174174
}
@@ -177,7 +177,7 @@ protected Object get(PCode self) {
177177
@GenerateNodeFactory
178178
public abstract static class GetNamesNode extends PythonBuiltinNode {
179179
@Specialization
180-
protected Object get(PCode self) {
180+
protected Object get(@SuppressWarnings("unused") PCode self) {
181181
return PNotImplemented.NOT_IMPLEMENTED;
182182
}
183183
}
@@ -199,7 +199,7 @@ protected Object get(PCode self) {
199199
@GenerateNodeFactory
200200
public abstract static class GetLNoTabNode extends PythonBuiltinNode {
201201
@Specialization
202-
protected Object get(PCode self) {
202+
protected Object get(@SuppressWarnings("unused") PCode self) {
203203
return PNotImplemented.NOT_IMPLEMENTED;
204204
}
205205
}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/code/PCode.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import java.util.HashSet;
4545
import java.util.List;
4646
import java.util.Set;
47-
import java.util.stream.Collectors;
4847

4948
import com.oracle.graal.python.builtins.objects.object.PythonBuiltinObject;
5049
import com.oracle.graal.python.builtins.objects.type.PythonClass;
@@ -195,6 +194,14 @@ private static String getName(RootNode rootNode) {
195194
return name;
196195
}
197196

197+
private static Set<String> getKeywordArgumentNames(List<ReadKeywordNode> readKeywordNodes) {
198+
Set<String> kwArgNames = new HashSet<>();
199+
for (ReadKeywordNode node : readKeywordNodes) {
200+
kwArgNames.add(node.getName());
201+
}
202+
return kwArgNames;
203+
}
204+
198205
private static Set<String> getArgumentNames(List<ReadIndexedArgumentNode> readIndexedArgumentNodes) {
199206
Set<String> argNames = new HashSet<>();
200207
for (ReadIndexedArgumentNode node : readIndexedArgumentNodes) {
@@ -236,7 +243,7 @@ private static ArgStats getArgStats(RootNode rootNode, PythonCore core) {
236243
List<ReadKeywordNode> readKeywordNodes = NodeUtil.findAllNodeInstances(rootNode, ReadKeywordNode.class);
237244
List<ReadIndexedArgumentNode> readIndexedArgumentNodes = NodeUtil.findAllNodeInstances(rootNode, ReadIndexedArgumentNode.class);
238245

239-
Set<String> kwNames = readKeywordNodes.stream().map(ReadKeywordNode::getName).collect(Collectors.toSet());
246+
Set<String> kwNames = getKeywordArgumentNames(readKeywordNodes);
240247
Set<String> argNames = getArgumentNames(readIndexedArgumentNodes);
241248

242249
Set<String> allArgNames = new HashSet<>();

0 commit comments

Comments
 (0)