when we need to generalize in a slice-set, use the indicative value of the insertion sequence as generalization value

timfel · timfel · commit 0c2d9f2cbf2a · 2018-12-06T17:39:10.000+01:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/SequenceStorageNodes.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/SequenceStorageNodes.java
@@ -1064,7 +1064,7 @@ void setSlice(SequenceStorage store, SliceInfo sinfo, SequenceStorage sequence,
 
         @Specialization(guards = "!compatibleAssign(self, sequence)")
         void doError(@SuppressWarnings("unused") SequenceStorage self, @SuppressWarnings("unused") SliceInfo info, SequenceStorage sequence) {
-            throw new SequenceStoreException(sequence);
+            throw new SequenceStoreException(sequence.getIndicativeValue());
         }
 
         protected static boolean isValidReplacement(Class<? extends SequenceStorage> cachedClass, SequenceStorage s, SliceInfo info) {

Original file line number	Diff line number	Diff line change
`@@ -1064,7 +1064,7 @@ void setSlice(SequenceStorage store, SliceInfo sinfo, SequenceStorage sequence,`
`1064`	`1064`
`1065`	`1065`	`@Specialization(guards = "!compatibleAssign(self, sequence)")`
`1066`	`1066`	`void doError(@SuppressWarnings("unused") SequenceStorage self, @SuppressWarnings("unused") SliceInfo info, SequenceStorage sequence) {`
`1067`		`- throw new SequenceStoreException(sequence);`
	`1067`	`+ throw new SequenceStoreException(sequence.getIndicativeValue());`
`1068`	`1068`	`}`
`1069`	`1069`
`1070`	`1070`	`protected static boolean isValidReplacement(Class<? extends SequenceStorage> cachedClass, SequenceStorage s, SliceInfo info) {`