Release GIL for isatty, lseek, fstat, openat, ftruncate

Author: fangerer

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixModuleBuiltins.java

@@ -822,11 +822,17 @@ protected ArgumentClinicProvider getArgumentClinic() {
         PNone ftruncate(VirtualFrame frame, int fd, long length,
                         @CachedLibrary("getPosixSupport()") PosixSupportLibrary posixLib,
                         @Cached SysModuleBuiltins.AuditNode auditNode,
+                        @Cached GilNode gil,
                         @Cached BranchProfile errorProfile) {
             auditNode.audit("os.truncate", fd, length);
             while (true) {
                 try {
-                    posixLib.ftruncate(getPosixSupport(), fd, length);
+                    gil.release(true);
+                    try {
+                        posixLib.ftruncate(getPosixSupport(), fd, length);
+                    } finally {
+                        gil.acquire();
+                    }
                     return PNone.NONE;
                 } catch (PosixException e) {
                     errorProfile.enter();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/io/BufferedWriterBuiltins.java

@@ -51,6 +51,7 @@
 import com.oracle.graal.python.builtins.modules.io.IOBaseBuiltins.CheckWritableNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
 import com.oracle.graal.python.nodes.object.GetClassNode;
+import com.oracle.graal.python.runtime.GilNode;
 import com.oracle.graal.python.runtime.PosixSupportLibrary;
 import com.oracle.graal.python.runtime.object.PythonObjectFactory;
 import com.oracle.truffle.api.dsl.Cached;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/io/FileIOBuiltins.java

@@ -222,14 +222,20 @@ private static void errorCleanup(VirtualFrame frame, PFileIO self, boolean fdIsO
         private int open(VirtualFrame frame, String name, int flags, int mode,
                         PythonContext ctxt,
                         PosixSupportLibrary posixLib,
+                        GilNode gil,
                         BranchProfile errorProfile) {
             Object path = posixLib.createPathFromString(ctxt.getPosixSupport(), name);
             if (path == null) {
                 throw raise(ValueError, EMBEDDED_NULL_BYTE);
             }
             while (true) {
                 try {
-                    return posixLib.openat(ctxt.getPosixSupport(), AT_FDCWD.value, path, flags, mode);
+                    gil.release(true);
+                    try {
+                        return posixLib.openat(ctxt.getPosixSupport(), AT_FDCWD.value, path, flags, mode);
+                    } finally {
+                        gil.acquire();
+                    }
                 } catch (PosixException e) {
                     errorProfile.enter();
                     if (e.getErrorCode() == OSErrorEnum.EINTR.getNumber()) {
@@ -303,7 +309,8 @@ void doInit(VirtualFrame frame, PFileIO self, Object nameobj, IONodes.IOMode mod
                         @Cached SetAttributeNode.Dynamic setAttr,
                         @Cached SysModuleBuiltins.AuditNode auditNode,
                         @Cached BranchProfile exceptionProfile,
-                        @Cached ConditionProfile errorProfile) {
+                        @Cached ConditionProfile errorProfile,
+                        @Cached GilNode gil) {
             if (self.getFD() >= 0) {
                 if (self.isCloseFD()) {
                     /* Have to close the existing file first. */
@@ -337,7 +344,7 @@ void doInit(VirtualFrame frame, PFileIO self, Object nameobj, IONodes.IOMode mod
                     }
 
                     if (opener instanceof PNone) {
-                        self.setFD(open(frame, name, flags, 0666, ctxt, posixLib, exceptionProfile), ctxt);
+                        self.setFD(open(frame, name, flags, 0666, ctxt, posixLib, gil, exceptionProfile), ctxt);
                     } else {
                         Object fdobj = callOpener.execute(frame, opener, nameobj, flags);
                         if (!indexCheckNode.execute(fdobj)) {
@@ -363,7 +370,13 @@ void doInit(VirtualFrame frame, PFileIO self, Object nameobj, IONodes.IOMode mod
                 }
                 self.setBlksize(DEFAULT_BUFFER_SIZE);
                 try {
-                    long[] fstatResult = posixLib.fstat(ctxt.getPosixSupport(), self.getFD());
+                    long[] fstatResult;
+                    gil.release(true);
+                    try {
+                        fstatResult = posixLib.fstat(ctxt.getPosixSupport(), self.getFD());
+                    } finally {
+                        gil.acquire();
+                    }
                     /*
                      * On Unix, open will succeed for directories. In Python, there should be no
                      * file objects referring to directories, so we need a check.
@@ -396,8 +409,13 @@ void doInit(VirtualFrame frame, PFileIO self, Object nameobj, IONodes.IOMode mod
                      * it might be done only on the first write()).
                      */
                     try {
-                        long res = posixLib.lseek(ctxt.getPosixSupport(), self.getFD(), 0, mapPythonSeekWhenceToPosix(SEEK_END));
-                        self.setSeekable(res >= 0 ? 1 : 0);
+                        gil.release(true);
+                        try {
+                            long res = posixLib.lseek(ctxt.getPosixSupport(), self.getFD(), 0, mapPythonSeekWhenceToPosix(SEEK_END));
+                            self.setSeekable(res >= 0 ? 1 : 0);
+                        } finally {
+                            gil.acquire();
+                        }
                     } catch (PosixException e) {
                         exceptionProfile.enter();
                         if (self.getSeekable() < 0) {
@@ -744,9 +762,15 @@ protected ArgumentClinicProvider getArgumentClinic() {
         @Specialization(guards = "!self.isClosed()")
         Object seek(VirtualFrame frame, PFileIO self, long pos, int whence,
                         @CachedLibrary("getPosixSupport()") PosixSupportLibrary posixLib,
+                        @Cached GilNode gil,
                         @Cached BranchProfile exceptionProfile) {
             try {
-                return internalSeek(self, pos, whence, getPosixSupport(), posixLib);
+                gil.release(true);
+                try {
+                    return internalSeek(self, pos, whence, getPosixSupport(), posixLib);
+                } finally {
+                    gil.acquire();
+                }
             } catch (PosixException e) {
                 exceptionProfile.enter();
                 throw raiseOSErrorFromPosixException(frame, e);
@@ -985,8 +1009,14 @@ Object closedError(@SuppressWarnings("unused") PFileIO self) {
     abstract static class IsattyNode extends PythonUnaryBuiltinNode {
         @Specialization(guards = "!self.isClosed()")
         boolean isatty(@SuppressWarnings("unused") PFileIO self,
-                        @CachedLibrary("getPosixSupport()") PosixSupportLibrary posixLib) {
-            return posixLib.isatty(getPosixSupport(), self.getFD());
+                        @CachedLibrary("getPosixSupport()") PosixSupportLibrary posixLib,
+                        @Cached GilNode gil) {
+            gil.release(true);
+            try {
+                return posixLib.isatty(getPosixSupport(), self.getFD());
+            } finally {
+                gil.acquire();
+            }
         }
 
         @Specialization(guards = "self.isClosed()")