do not use Paths.get() for URIs

Author: tomasstupka

graalpython/com.oracle.graal.python.test.integration/src/org/graalvm/python/embedding/utils/test/VirtualFileSystemTest.java

@@ -188,19 +188,21 @@ public void toAbsolutePath() throws Exception {
 
     @Test
     public void parseStringPath() throws Exception {
-        parseStringPath(VirtualFileSystemTest::parseStringPath);
+        parsePath(VirtualFileSystemTest::parseStringPath);
     }
 
     @Test
     public void parseURIPath() throws Exception {
-        parseStringPath(VirtualFileSystemTest::parseURIPath);
+        parsePath(VirtualFileSystemTest::parseURIPath);
 
         for (FileSystem fs : new FileSystem[]{rwHostIOVFS, rHostIOVFS, noHostIOVFS}) {
             checkException(UnsupportedOperationException.class, () -> fs.parsePath(URI.create("http://testvfs.org")), "only file uri is supported");
+            checkException(UnsupportedOperationException.class, () -> fs.parsePath(URI.create("http:/" + VFS_MOUNT_POINT + File.separator + "dir1")), "only file uri is supported");
+            checkException(UnsupportedOperationException.class, () -> fs.parsePath(URI.create("http://" + VFS_MOUNT_POINT + File.separator + "dir1")), "only file uri is supported");
         }
     }
 
-    public void parseStringPath(BiFunction<FileSystem, String, Path> parsePath) throws Exception {
+    public void parsePath(BiFunction<FileSystem, String, Path> parsePath) throws Exception {
         // from VFS
         for (FileSystem fs : new FileSystem[]{rwHostIOVFS, rHostIOVFS, noHostIOVFS}) {
             // check regular resource dir

graalpython/org.graalvm.python.embedding/src/org/graalvm/python/embedding/utils/VirtualFileSystem.java

@@ -694,7 +694,9 @@ void extractResources(Path resourcesDirectory) throws IOException {
     @Deprecated
     public Path parsePath(URI uri) {
         if (uri.getScheme().equals("file")) {
-            Path ret = Paths.get(uri);
+            // rather do not use Paths.get(URI) as it looks up the file system provider
+            // by scheme and can use a non default file system provider
+            Path ret = Paths.get(uri.getPath());
             if (!pathIsInVfs(ret)) {
                 if (delegate != null) {
                     ret = delegate.parsePath(uri);
@@ -705,14 +707,17 @@ public Path parsePath(URI uri) {
             finest("VFS.parsePath '%s' -> '%s'", uri, ret);
             return ret;
         } else {
-            finer("VFS.parsePath: Not supported yet '%s'", uri);
-            throw new UnsupportedOperationException("Not supported yet.");
+            String msg = "Unsupported URI scheme '%s'";
+            finer(msg, uri.getScheme());
+            throw new UnsupportedOperationException(String.format(msg, uri.getScheme()));
         }
     }
 
     @Override
     @Deprecated
     public Path parsePath(String path) {
+        // It's safe to use the Paths.get(String)
+        // as it always uses the default file system.
         Path p = Paths.get(path);
         if (!pathIsInVfs(p)) {
             if (delegate != null) {