Fix: throw correct error type for invalid maxlen

Author: fangerer

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/deque/DequeBuiltins.java

@@ -42,6 +42,7 @@
 
 import static com.oracle.graal.python.builtins.PythonBuiltinClassType.IndexError;
 import static com.oracle.graal.python.builtins.PythonBuiltinClassType.MemoryError;
+import static com.oracle.graal.python.builtins.PythonBuiltinClassType.OverflowError;
 import static com.oracle.graal.python.builtins.PythonBuiltinClassType.RuntimeError;
 import static com.oracle.graal.python.builtins.PythonBuiltinClassType.StopIteration;
 import static com.oracle.graal.python.builtins.PythonBuiltinClassType.TypeError;
@@ -179,6 +180,7 @@ PNone doGeneric(VirtualFrame frame, PDeque self, Object iterable, Object maxlenO
                         @Cached CastToJavaIntExactNode castToIntNode,
                         @CachedLibrary(limit = "1") PythonObjectLibrary lib,
                         @Cached GetNextNode getNextNode,
+                        @Cached IsBuiltinClassProfile isTypeErrorProfile,
                         @Cached IsBuiltinClassProfile isStopIterationProfile) {
             if (!PGuards.isPNone(maxlenObj)) {
                 try {
@@ -187,6 +189,10 @@ PNone doGeneric(VirtualFrame frame, PDeque self, Object iterable, Object maxlenO
                         throw raise(ValueError, "maxlen must be non-negative");
                     }
                     self.setMaxLength(maxlen);
+                } catch (PException e) {
+                    // CastToJavaIntExactNode will throw a TypeError; we need to convert to OverflowError
+                    e.expect(TypeError, isTypeErrorProfile);
+                    throw raise(OverflowError, ErrorMessages.PYTHON_INT_TOO_LARGE_TO_CONV_TO, "int");
                 } catch (CannotCastException e) {
                     throw raise(TypeError, ErrorMessages.INTEGER_REQUIRED);
                 }