Use argument clinic in AsIntegerRatio

Author: fangerer

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/floats/FloatBuiltins.java

@@ -83,6 +83,7 @@
 import com.oracle.graal.python.builtins.objects.cext.capi.CExtNodes.FromNativeSubclassNode;
 import com.oracle.graal.python.builtins.objects.cext.PythonNativeObject;
 import com.oracle.graal.python.builtins.objects.common.FormatNodeBase;
+import com.oracle.graal.python.builtins.objects.floats.FloatBuiltinsClinicProviders.AsIntegerRatioClinicProviderGen;
 import com.oracle.graal.python.builtins.objects.floats.FloatBuiltinsClinicProviders.FormatNodeClinicProviderGen;
 import com.oracle.graal.python.builtins.objects.ints.PInt;
 import com.oracle.graal.python.builtins.objects.object.PythonObjectLibrary;
@@ -95,6 +96,7 @@
 import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
+import com.oracle.graal.python.nodes.function.builtins.PythonClinicBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonTernaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.clinic.ArgumentClinicProvider;
@@ -1511,20 +1513,19 @@ abstract static class ImagNode extends PythonBuiltinNode {
     }
 
     @GenerateNodeFactory
-    @Builtin(name = "as_integer_ratio", minNumOfPositionalArgs = 1)
-    abstract static class AsIntegerRatio extends PythonUnaryBuiltinNode {
+    @Builtin(name = "as_integer_ratio", parameterNames = "x")
+    @ArgumentClinic(name = "x", defaultValue = "0.0", conversion = ClinicConversion.Double)
+    abstract static class AsIntegerRatio extends PythonClinicBuiltinNode {
 
-        @Specialization
-        PTuple getPFloat(PFloat self,
-                        @Shared("nanProfile") @Cached ConditionProfile nanProfile,
-                        @Shared("infProfile") @Cached ConditionProfile infProfile) {
-            return get(self.getValue(), nanProfile, infProfile);
+        @Override
+        protected ArgumentClinicProvider getArgumentClinic() {
+            return AsIntegerRatioClinicProviderGen.INSTANCE;
         }
 
         @Specialization
         PTuple get(double self,
-                        @Shared("nanProfile") @Cached ConditionProfile nanProfile,
-                        @Shared("infProfile") @Cached ConditionProfile infProfile) {
+                        @Cached ConditionProfile nanProfile,
+                        @Cached ConditionProfile infProfile) {
             if (nanProfile.profile(Double.isNaN(self))) {
                 throw raise(PythonErrorType.ValueError, ErrorMessages.CANNOT_CONVERT_S_TO_INT_RATIO, "NaN");
             }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/function/builtins/clinic/JavaDoubleConversionNode.java

@@ -55,7 +55,7 @@
 public abstract class JavaDoubleConversionNode extends ArgumentCastNode {
 
     private final double defaultValue;
-    private final boolean useDefaultForNone;
+    final boolean useDefaultForNone;
 
     protected JavaDoubleConversionNode(double defaultValue, boolean useDefaultForNone) {
         this.defaultValue = defaultValue;
@@ -90,8 +90,7 @@ static double doPFloat(PFloat l) {
 
     @ClinicConverterFactory(shortCircuitPrimitive = PrimitiveType.Double)
     public static JavaDoubleConversionNode create(@DefaultValue double defaultValue, @UseDefaultForNone boolean useDefaultForNone) {
-        //return JavaIntConversionNodeGen.create(defaultValue, useDefaultForNone);
-        return null;
+        return JavaDoubleConversionNodeGen.create(defaultValue, useDefaultForNone);
     }
 
     protected boolean isHandledPNone(Object value) {