Skip to content

Commit 1417313

Browse files
committed
cleanup warnings
1 parent de82377 commit 1417313

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/TruffleCextBuiltins.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import static com.oracle.graal.python.builtins.PythonBuiltinClassType.SystemError;
4545
import static com.oracle.graal.python.nodes.SpecialMethodNames.__GETITEM__;
4646
import static com.oracle.graal.python.runtime.exception.PythonErrorType.OverflowError;
47-
import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
4847

4948
import java.math.BigInteger;
5049
import java.nio.ByteBuffer;
@@ -82,8 +81,8 @@
8281
import com.oracle.graal.python.builtins.objects.cext.CExtNodesFactory.MayRaiseTernaryNodeGen;
8382
import com.oracle.graal.python.builtins.objects.cext.CExtNodesFactory.MayRaiseUnaryNodeGen;
8483
import com.oracle.graal.python.builtins.objects.cext.HandleCache;
85-
import com.oracle.graal.python.builtins.objects.cext.NativeWrappers.PrimitiveNativeWrapper;
8684
import com.oracle.graal.python.builtins.objects.cext.NativeMemberNames;
85+
import com.oracle.graal.python.builtins.objects.cext.NativeWrappers.PrimitiveNativeWrapper;
8786
import com.oracle.graal.python.builtins.objects.cext.NativeWrappers.PySequenceArrayWrapper;
8887
import com.oracle.graal.python.builtins.objects.cext.NativeWrappers.PythonClassInitNativeWrapper;
8988
import com.oracle.graal.python.builtins.objects.cext.NativeWrappers.PythonClassNativeWrapper;
@@ -2005,7 +2004,7 @@ private static BigInteger convertToBigInteger(long n) {
20052004
@Specialization
20062005
Object doPointer(PythonNativeObject n, @SuppressWarnings("unused") int signed,
20072006
@Cached("create()") CExtNodes.ToSulongNode toSulongNode) {
2008-
return toSulongNode.execute(factory().createNativeVoidPtr((TruffleObject) n.object));
2007+
return toSulongNode.execute(factory().createNativeVoidPtr(n.object));
20092008
}
20102009
}
20112010

@@ -2145,10 +2144,7 @@ abstract static class PyBytes_FromStringAndSize extends NativeBuiltin {
21452144

21462145
@Specialization
21472146
PBytes doGeneric(PythonNativeObject object) {
2148-
if (object.object instanceof TruffleObject) {
2149-
return factory().createBytes(getByteArray((TruffleObject) object.object));
2150-
}
2151-
throw raise(TypeError, "invalid pointer: %s", object.object);
2147+
return factory().createBytes(getByteArray(object.object));
21522148
}
21532149
}
21542150

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/PythonObjectNativeWrapperMR.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ Object doMemoryview(PMemoryView object, String key,
672672
Object delegateObj = readAttrNode.execute(object, "__c_memoryview");
673673
if (isNativeObject.profile(delegateObj instanceof PythonNativeObject)) {
674674
try {
675-
return ForeignAccess.sendRead(readNode, (TruffleObject) ((PythonNativeObject) delegateObj).object, key);
675+
return ForeignAccess.sendRead(readNode, ((PythonNativeObject) delegateObj).object, key);
676676
} catch (UnsupportedMessageException | UnknownIdentifierException e) {
677677
throw e.raise();
678678
}
@@ -858,7 +858,7 @@ Object doMemoryview(PMemoryView object, String key, Object value,
858858
Object delegateObj = readAttrNode.execute(object, "__c_memoryview");
859859
if (isNativeObject.profile(delegateObj instanceof PythonNativeObject)) {
860860
try {
861-
return ForeignAccess.sendWrite(writeNode, (TruffleObject) ((PythonNativeObject) delegateObj).object, key, value);
861+
return ForeignAccess.sendWrite(writeNode, ((PythonNativeObject) delegateObj).object, key, value);
862862
} catch (UnsupportedMessageException | UnknownIdentifierException | UnsupportedTypeException e) {
863863
throw e.raise();
864864
}

0 commit comments

Comments
 (0)