Skip to content

Commit 1488ac7

Browse files
committed
Rename PThreadState.getThreadState to getOrCreateNativeThreadState
1 parent b9feeba commit 1488ac7

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextCEvalBuiltins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ abstract static class PyEval_SaveThread extends CApiNullaryBuiltinNode {
9595
@Specialization
9696
static Object save(@Cached GilNode gil) {
9797
PythonContext context = PythonContext.get(gil);
98-
Object threadState = PThreadState.getThreadState(PythonLanguage.get(gil), context);
98+
Object threadState = PThreadState.getOrCreateNativeThreadState(PythonLanguage.get(gil), context);
9999
LOGGER.fine("C extension releases GIL");
100100
gil.release(context, true);
101101
return threadState;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextPyStateBuiltins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Object get(Object tstateCurrentPtr,
110110
if (!lib.isNull(tstateCurrentPtr)) {
111111
pythonThreadState.setNativeThreadLocalVarPointer(tstateCurrentPtr);
112112
}
113-
return PThreadState.getThreadState(pythonThreadState);
113+
return PThreadState.getOrCreateNativeThreadState(pythonThreadState);
114114
}
115115
}
116116

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/PThreadState.java

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@
6060
* <p>
6161
* This wrapper does intentionally not implement {@link InteropLibrary#isPointer(Object)},
6262
* {@link InteropLibrary#asPointer(Object)}, and {@link InteropLibrary#toNative(Object)} because the
63-
* factory method {@link #getThreadState(PythonLanguage, PythonContext)} will already return the
64-
* appropriate pointer object that implements that.
63+
* factory method {@link #getOrCreateNativeThreadState(PythonLanguage, PythonContext)} will already
64+
* return the appropriate pointer object that implements that.
6565
* </p>
6666
*/
6767
public final class PThreadState extends PythonStructNativeWrapper {
@@ -73,11 +73,11 @@ private PThreadState(PythonThreadState threadState) {
7373
replacement = registerReplacement(allocateCLayout(threadState), false, InteropLibrary.getUncached());
7474
}
7575

76-
public static Object getThreadState(PythonLanguage language, PythonContext context) {
77-
return getThreadState(context.getThreadState(language));
76+
public static Object getOrCreateNativeThreadState(PythonLanguage language, PythonContext context) {
77+
return getOrCreateNativeThreadState(context.getThreadState(language));
7878
}
7979

80-
public static Object getThreadState(PythonThreadState threadState) {
80+
public static Object getOrCreateNativeThreadState(PythonThreadState threadState) {
8181
PThreadState nativeWrapper = threadState.getNativeWrapper();
8282
if (CompilerDirectives.injectBranchProbability(CompilerDirectives.SLOWPATH_PROBABILITY, nativeWrapper == null)) {
8383
nativeWrapper = new PThreadState(threadState);
@@ -86,6 +86,14 @@ public static Object getThreadState(PythonThreadState threadState) {
8686
return nativeWrapper.replacement;
8787
}
8888

89+
public static Object getNativeThreadState(PythonThreadState threadState) {
90+
PThreadState nativeWrapper = threadState.getNativeWrapper();
91+
if (nativeWrapper != null) {
92+
return nativeWrapper.replacement;
93+
}
94+
return null;
95+
}
96+
8997
public PythonThreadState getThreadState() {
9098
return (PythonThreadState) getDelegate();
9199
}

0 commit comments

Comments
 (0)