Removed obsolete isExecutableAccessAllowed checks, use ConcurrentHashMap for emulated environ, remove redundant PGuard method

Author: otethal

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixModuleBuiltins.java

@@ -400,7 +400,7 @@ Object execvArgsTuple(VirtualFrame frame, PosixPath path, PTuple argv,
             throw CompilerDirectives.shouldNotReachHere("execv should not return normally");
         }
 
-        @Specialization(guards = {"!isList(argv)", "!isTuple(argv)"})
+        @Specialization(guards = {"!isList(argv)", "!isPTuple(argv)"})
         @SuppressWarnings("unused")
         Object execvInvalidArgs(VirtualFrame frame, PosixPath path, Object argv) {
             throw raise(TypeError, ErrorMessages.ARG_D_MUST_BE_S, "execv()", 2, "tuple or list");

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/PGuards.java

@@ -233,10 +233,6 @@ public static boolean isList(Object o) {
         return o instanceof PList;
     }
 
-    public static boolean isTuple(Object o) {
-        return o instanceof PTuple;
-    }
-
     public static boolean isObjectStorageIterator(PSequenceIterator iterator) {
         if (!iterator.isPSequence()) {
             return false;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/EmulatedPosixSupport.java

@@ -94,6 +94,7 @@
 import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.TimeUnit;
 import java.util.logging.Level;
 
@@ -243,7 +244,7 @@ public final class EmulatedPosixSupport extends PosixResources {
     private static final int S_IFREG = 0100000;
 
     private final PythonContext context;
-    private final Map<String, String> environ = new HashMap<>();
+    private final ConcurrentHashMap<String, String> environ = new ConcurrentHashMap<>();
     private int currentUmask = 0022;
     private boolean hasDefaultUmask = true;
 
@@ -1606,9 +1607,13 @@ public String ctermid() {
 
     @ExportMessage
     @TruffleBoundary
-    public synchronized void setenv(Object name, Object value, boolean overwrite) {
-        if (overwrite || !environ.containsKey(name)) {
-            environ.put((String) name, (String) value);
+    public void setenv(Object name, Object value, boolean overwrite) {
+        String nameStr = pathToJavaStr(name);
+        String valueStr = pathToJavaStr(value);
+        if (overwrite) {
+            environ.put(nameStr, valueStr);
+        } else {
+            environ.putIfAbsent(nameStr, valueStr);
         }
     }
 
@@ -1620,12 +1625,6 @@ public int forkExec(Object[] executables, Object[] args, Object cwd, Object[] en
         // TODO there are a few arguments we ignore, we should throw an exception or report a
         // compatibility warning
 
-        if (!context.isExecutableAccessAllowed()) {
-            // TODO is this check relevant to NFI backend as well?
-            // TODO raise an exception instead of returning an invalid pid
-            return -1;
-        }
-
         // TODO do we need to do this check (and the isExecutable() check later)?
         TruffleFile cwdFile = cwd == null ? context.getEnv().getCurrentWorkingDirectory() : getTruffleFile(pathToJavaStr(cwd));
         if (!cwdFile.exists()) {
@@ -1782,9 +1781,6 @@ private void handleIOError(int errpipe_write, IOException e) {
     @ExportMessage
     public void execv(Object pathname, Object[] args) throws PosixException {
         assert args.length > 0;
-        if (!context.isExecutableAccessAllowed()) {
-            throw posixException(OSErrorEnum.EPERM);
-        }
         String[] cmd = new String[args.length];
         // ProcessBuilder does not accept separate executable name, we must overwrite the 0-th
         // argument
@@ -1834,9 +1830,6 @@ private void execvInternal(String[] cmd) throws IOException {
     @TruffleBoundary
     public int system(Object commandObj) {
         String cmd = pathToJavaStr(commandObj);
-        if (!context.isExecutableAccessAllowed()) {
-            return -1;
-        }
         LOGGER.fine(() -> "os.system: " + cmd);
 
         String[] command;