Skip to content

Commit 1a3dd16

Browse files
committed
don't check in generated antlr files anymore
1 parent 9b98ba5 commit 1a3dd16

File tree

10 files changed

+21
-12885
lines changed

10 files changed

+21
-12885
lines changed

graalpython/com.oracle.graal.python.parser.antlr/Makefile

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2018, Oracle and/or its affiliates.
1+
# Copyright (c) 2018, 2019, Oracle and/or its affiliates.
22
#
33
# The Universal Permissive License (UPL), Version 1.0
44
#
@@ -36,28 +36,33 @@
3636
# SOFTWARE.
3737

3838
QUIETLY$(MX_VERBOSE) = @
39-
TARGETS=${OUTPUT_PATH}/Python3BaseVisitor.java \
40-
${OUTPUT_PATH}/Python3Listener.java \
41-
${OUTPUT_PATH}/Python3BaseListener.java \
42-
${OUTPUT_PATH}/Python3Visitor.java \
43-
${OUTPUT_PATH}/Python3Parser.java \
44-
${OUTPUT_PATH}/Python3Lexer.java
39+
40+
# during clean, this isn't set
41+
PARSER_PATH ?= ../com.oracle.graal.python/src/com/oracle/graal/python/parser/antlr
42+
43+
TARGETS=${PARSER_PATH}/Python3BaseVisitor.java \
44+
${PARSER_PATH}/Python3Listener.java \
45+
${PARSER_PATH}/Python3BaseListener.java \
46+
${PARSER_PATH}/Python3Visitor.java \
47+
${PARSER_PATH}/Python3Parser.java \
48+
${PARSER_PATH}/Python3Lexer.java
4549

4650
SOURCE=${PARSER_PATH}/Python3.g4
47-
STAMP=${PARSER_PATH}/Python3.g4.stamp
4851

4952
.PHONY: default clean
50-
default: ${STAMP}
53+
default: ${TARGETS}
5154

5255
# postprocessing to make source compile without warnings
5356
define postprocess_file
5457
python ${POSTPROCESSOR} $(1)
5558
endef
5659

57-
${STAMP}: ${SOURCE}
58-
$(QUIETLY) touch $@
59-
$(QUIETLY) ${JAVA_HOME}/bin/java -cp ${ANTLR_JAR} org.antlr.v4.Tool -visitor -package ${PARSER_PKG} -o ${OUTPUT_PATH} ${SOURCE}
60-
$(foreach var,$(TARGETS),$(call postprocess_file,$(var));)
60+
${PARSER_PATH}/%.java: ${SOURCE}
61+
$(QUIETLY) ${JAVA_HOME}/bin/java -cp ${ANTLR_JAR} org.antlr.v4.Tool -visitor -package ${PARSER_PKG} -o ${PARSER_PATH} ${SOURCE}
62+
$(QUIETLY) $(call postprocess_file,$@)
6163

6264
clean:
63-
rm -f ${TARGETS}
65+
ifeq ($(wildcard ${SOURCE}),)
66+
$(error ${SOURCE} is not in the location I expected it to be, not cleaning antlr parser)
67+
endif
68+
$(QUIETLY) rm -f ${TARGETS}

0 commit comments

Comments
 (0)