Add TODO to remove overriding '__reduce__' method.

fangerer · fangerer · commit 1b0530ab48b0 · 2018-10-08T17:50:36.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/method/MethodBuiltins.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/method/MethodBuiltins.java
@@ -113,6 +113,8 @@ Object defaults(PMethod self,
     public abstract static class ReduceNode extends PythonUnaryBuiltinNode {
         @Specialization
         Object doGeneric(@SuppressWarnings("unused") Object obj) {
+            // TODO we should not override '__reduce__' but properly distinguish between heap/non
+            // heap types
             throw raise(TypeError, "can't pickle function objects");
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,8 @@ Object defaults(PMethod self,`
`113`	`113`	`public abstract static class ReduceNode extends PythonUnaryBuiltinNode {`
`114`	`114`	`@Specialization`
`115`	`115`	`Object doGeneric(@SuppressWarnings("unused") Object obj) {`
	`116`	`+ // TODO we should not override '__reduce__' but properly distinguish between heap/non`
	`117`	`+ // heap types`
`116`	`118`	`throw raise(TypeError, "can't pickle function objects");`
`117`	`119`	`}`
`118`	`120`	`}`