[GR-59404] PUnpicler.loadInst should throw exception if a class can't be found.

tomasstupka · tomasstupka · commit 2490656a3097 · 2024-10-29T16:03:07.000Z
PullRequest: graalpython/3538
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/pickle/PUnpickler.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/pickle/PUnpickler.java
@@ -1223,11 +1223,8 @@ private void loadInst(VirtualFrame frame, PythonContext ctx, PUnpickler self) {
                 if (s.length < 2) {
                     throw badReadLine();
                 }
-                try {
-                    Object className = decodeASCII(frame, s, s.length - 1, T_ERRORS_STRICT);
-                    cls = findClass(frame, ctx.getCore(), self, moduleName, className);
-                } catch (PException ignored) {
-                }
+                Object className = decodeASCII(frame, s, s.length - 1, T_ERRORS_STRICT);
+                cls = findClass(frame, ctx.getCore(), self, moduleName, className);
             }
 
             assert cls != null;

Original file line number	Diff line number	Diff line change
`@@ -1223,11 +1223,8 @@ private void loadInst(VirtualFrame frame, PythonContext ctx, PUnpickler self) {`
`1223`	`1223`	`if (s.length < 2) {`
`1224`	`1224`	`throw badReadLine();`
`1225`	`1225`	`}`
`1226`		`- try {`
`1227`		`- Object className = decodeASCII(frame, s, s.length - 1, T_ERRORS_STRICT);`
`1228`		`- cls = findClass(frame, ctx.getCore(), self, moduleName, className);`
`1229`		`- } catch (PException ignored) {`
`1230`		`- }`
	`1226`	`+ Object className = decodeASCII(frame, s, s.length - 1, T_ERRORS_STRICT);`
	`1227`	`+ cls = findClass(frame, ctx.getCore(), self, moduleName, className);`
`1231`	`1228`	`}`
`1232`	`1229`
`1233`	`1230`	`assert cls != null;`