[GR-66016] Launcher: enable JLine FFM provider.

PullRequest: graalpython/3841

Author: steve-s

graalpython/com.oracle.graal.python.test/src/tests/test_subprocess.py

@@ -100,12 +100,28 @@ def test_waitpid(self):
             p.kill()
             p.wait()
 
-    @unittest.skipIf(sys.platform == 'win32', "Posix-specific")
+    # @unittest.skipIf(sys.platform == 'win32', "Posix-specific")
+    # Skipped because of transient: GR-66709
+    @unittest.skip
     def test_waitpid_group_child(self):
         import os
-        p = subprocess.Popen([sys.executable, "-c", "import time; time.sleep(0.1); 42"])
+        p = subprocess.Popen([sys.executable, "-c", "import time; print('before'); time.sleep(0.1); print('after'); 42"],
+                             stdin=subprocess.PIPE, stdout=subprocess.PIPE,
+                             stderr=subprocess.PIPE)
+        ps_list = 'not available'
+        if sys.implementation.name == "graalpy" and \
+                __graalpython__.posix_module_backend != 'java' \
+                and sys.platform.startswith("linux"):
+            ps_list = subprocess.check_output("ps", shell=True, text=True)
         res = os.waitpid(0, 0)
-        assert res[1] == 0, res
+        msg = f"Spawned {p.pid=}, os.waitpid result={res}, output of ps:\n{ps_list}"
+        try:
+            stdout, stderr = p.communicate(timeout=5)
+        except subprocess.TimeoutExpired:
+            p.kill()
+            stdout, stderr = p.communicate()
+        msg += f"\n{stdout.decode().strip()=}, {stderr.decode().strip()=}"
+        assert res[1] == 0, msg
 
     # @unittest.skipIf(sys.platform == 'win32', "Posix-specific")
     # Skipped because of transient: https://jira.oci.oraclecorp.com/browse/GR-65714

mx.graalpython/mx_graalpython.py

@@ -2036,12 +2036,16 @@ def bytecode_dsl_build_args():
                 '-J-Xms14g', # GR-46399: libpythonvm needs more than the default minimum of 8 GB to be built
                 '-H:+DetectUserDirectoriesInImageHeap',
                 '-H:-CopyLanguageResources',
+                # Uncomment to disable JLine FFM provider at native image build time
+                # '-Dorg.graalvm.shadowed.org.jline.terminal.ffm.disable=true',
+                '--enable-native-access=org.graalvm.shadowed.jline',
                 '-Dpolyglot.python.PosixModuleBackend=native',
                 '-Dpolyglot.python.Sha3ModuleBackend=native',
             ] + bytecode_dsl_build_args(),
             language='python',
             default_vm_args=[
                 '--vm.Xss16777216', # request 16M of stack
+                '--vm.-enable-native-access=org.graalvm.shadowed.jline',
             ],
         ),
     ],

mx.graalpython/suite.py

@@ -823,6 +823,7 @@
             "liblang_relpath": "../lib/<lib:pythonvm>",
             "default_vm_args": [
                 "--vm.Xss16777216", # request 16M of stack
+                '--vm.-enable-native-access=org.graalvm.shadowed.jline',
             ],
         },
 
@@ -845,6 +846,9 @@
                 "-Dorg.graalvm.launcher.class=com.oracle.graal.python.shell.GraalPythonMain",
                 # GraalPy standalone specific flags
                 "-J-Xms14g", # GR-46399: libpythonvm needs more than the default minimum of 8 GB to be built
+                # uncomment to disable JLine FFM provider at native image build time
+                #'-Dorg.graalvm.shadowed.org.jline.terminal.ffm.disable=true',
+                 '--enable-native-access=org.graalvm.shadowed.jline',
                 "-Dpolyglot.python.PosixModuleBackend=native",
                 "-Dpolyglot.python.Sha3ModuleBackend=native",
             ],