Skip to content

Commit 286b87f

Browse files
committed
Don't compute lineno on materialization fast-path
1 parent 4a31953 commit 286b87f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/frame/PFrame.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,14 @@
4242

4343
import com.oracle.graal.python.PythonLanguage;
4444
import com.oracle.graal.python.builtins.PythonBuiltinClassType;
45-
import com.oracle.graal.python.builtins.objects.code.PCode;
4645
import com.oracle.graal.python.builtins.objects.code.CodeNodes.GetCodeRootNode;
46+
import com.oracle.graal.python.builtins.objects.code.PCode;
4747
import com.oracle.graal.python.builtins.objects.frame.FrameBuiltins.GetLocalsNode;
4848
import com.oracle.graal.python.builtins.objects.function.PArguments;
4949
import com.oracle.graal.python.builtins.objects.object.PythonBuiltinObject;
5050
import com.oracle.graal.python.builtins.objects.object.PythonObject;
5151
import com.oracle.graal.python.nodes.PRootNode;
52+
import com.oracle.graal.python.nodes.bytecode.PBytecodeRootNode;
5253
import com.oracle.graal.python.runtime.object.PythonObjectFactory;
5354
import com.oracle.graal.python.util.PythonUtils;
5455
import com.oracle.truffle.api.CompilerAsserts;
@@ -220,6 +221,8 @@ public int getLine() {
220221
if (line == -2) {
221222
if (location == null) {
222223
line = -1;
224+
} else if (location instanceof PBytecodeRootNode) {
225+
return ((PBytecodeRootNode) location).bciToLine(lasti);
223226
} else {
224227
SourceSection sourceSection = location.getEncapsulatingSourceSection();
225228
if (sourceSection == null) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/frame/MaterializeFrameNode.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@ private static void processBytecodeFrame(Frame frameToMaterialize, PFrame pyFram
178178
if (isBytecodeFrame(frameToMaterialize)) {
179179
FrameInfo info = (FrameInfo) frameToMaterialize.getFrameDescriptor().getInfo();
180180
pyFrame.setLasti(info.getBci(frameToMaterialize));
181-
pyFrame.setLine(info.getLineno(frameToMaterialize));
182181
pyFrame.setLocation(info.getRootNode());
183182
}
184183
}

0 commit comments

Comments
 (0)