[GR-46044] Fix peak regression after CreateArgumentsNode footprint optimization.

PullRequest: graalpython/2776

Author: steve-s

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/code/CodeNodes.java

@@ -48,6 +48,7 @@
 import com.oracle.graal.python.builtins.modules.MarshalModuleBuiltins;
 import com.oracle.graal.python.builtins.objects.code.CodeNodesFactory.GetCodeCallTargetNodeGen;
 import com.oracle.graal.python.builtins.objects.code.CodeNodesFactory.GetCodeRootNodeGen;
+import com.oracle.graal.python.builtins.objects.function.PFunction;
 import com.oracle.graal.python.builtins.objects.function.Signature;
 import com.oracle.graal.python.compiler.CodeUnit;
 import com.oracle.graal.python.nodes.IndirectCallNode;
@@ -233,6 +234,21 @@ static Signature doCached(Node inliningTarget, @SuppressWarnings("unused") PCode
             return getInSingleContextMode(inliningTarget, cachedCode, firstExecution);
         }
 
+        public static Signature getInSingleContextMode(Node inliningTarget, PFunction fun, InlinedBranchProfile firstExecution) {
+            assert isSingleContext(inliningTarget);
+            if (CompilerDirectives.inCompiledCode() && CompilerDirectives.isPartialEvaluationConstant(fun) && fun.getCodeStableAssumption().isValid()) {
+                getInSingleContextMode(inliningTarget, fun.getCode(), firstExecution);
+            }
+            PCode code = fun.getCode();
+            Signature signature = code.signature;
+            if (signature == null) {
+                firstExecution.enter(inliningTarget);
+                RootCallTarget ct = code.initializeCallTarget();
+                signature = code.initializeSignature(ct);
+            }
+            return signature;
+        }
+
         public static Signature getInSingleContextMode(Node inliningTarget, PCode code, InlinedBranchProfile firstExecution) {
             assert isSingleContext(inliningTarget);
             CompilerAsserts.partialEvaluationConstant(code);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/CreateArgumentsNode.java

@@ -167,7 +167,7 @@ Object[] doFunctionCached(PFunction callable, Object[] userArguments, PKeyword[]
                     @Cached(value = "callable", weak = true) @SuppressWarnings("unused") PFunction cachedCallable) {
 
         PCode code = callable.getCode();
-        Signature signature = CodeNodes.GetCodeSignatureNode.getInSingleContextMode(inliningTarget, code, firstExecution);
+        Signature signature = CodeNodes.GetCodeSignatureNode.getInSingleContextMode(inliningTarget, callable, firstExecution);
         Object[] defaults = cachedCallable.getDefaults();
         PKeyword[] kwdefaults = cachedCallable.getKwDefaults();
         return createAndCheckArgumentsNode.execute(inliningTarget, callable, userArguments, keywords, signature, null, null, defaults, kwdefaults, false);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/builtins/FunctionNodes.java

@@ -237,7 +237,7 @@ public static Signature getMethodSignatureSingleContext(PMethodBase method, Node
         public static Signature getFunctionSignatureSingleContext(Node inliningTarget, InlinedBranchProfile wasFirst, Object fun) {
             CompilerAsserts.partialEvaluationConstant(fun);
             if (fun instanceof PFunction f) {
-                return CodeNodes.GetCodeSignatureNode.getInSingleContextMode(inliningTarget, f.getCode(), wasFirst);
+                return CodeNodes.GetCodeSignatureNode.getInSingleContextMode(inliningTarget, f, wasFirst);
             } else if (fun instanceof PBuiltinFunction f) {
                 return f.getSignature();
             }