Skip to content

Commit 2d23fc0

Browse files
committed
Arity and ArityCheckNode style check: static methods
1 parent 756110d commit 2d23fc0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/Arity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ private int computeNumRequiredKeywordArgs() {
119119
return num;
120120
}
121121

122-
private int computeMinNumPositionalArgs(int value) {
122+
private static int computeMinNumPositionalArgs(int value) {
123123
return value < 0 ? 0 : value;
124124
}
125125

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/ArityCheckNode.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ private void checkKeywords(Arity arity, int numOfKeywordsDeclared, int numOfKeyw
174174
}
175175

176176
@ExplodeLoop
177-
private int countMissingPositionalParamIds(int numParameterIds, Object[] arguments) {
177+
private static int countMissingPositionalParamIds(int numParameterIds, Object[] arguments) {
178178
int cntMissingPositional = 0;
179179
for (int i = 0; i < numParameterIds; i++) {
180180
if (PArguments.getArgument(arguments, i) == null) {
@@ -216,7 +216,7 @@ private int checkKeyword(Arity arity, String keyword, int length) {
216216
}
217217

218218
@TruffleBoundary
219-
private String getMissingRequiredKeywordsErrorMessage(Arity arity, int cntGivenRequiredKeywords, String[] givenKeywords) {
219+
private static String getMissingRequiredKeywordsErrorMessage(Arity arity, int cntGivenRequiredKeywords, String[] givenKeywords) {
220220
int missingRequiredKeywords = arity.getNumOfRequiredKeywords() - cntGivenRequiredKeywords;
221221
Set<String> givenKeywordsSet = new HashSet<>(Arrays.asList(givenKeywords));
222222

@@ -249,7 +249,7 @@ private String getMissingRequiredKeywordsErrorMessage(Arity arity, int cntGivenR
249249
}
250250

251251
@TruffleBoundary
252-
private String getMissingPositionalArgsErrorMessage(Arity arity, Object[] arguments, int cntMissingPositional) {
252+
private static String getMissingPositionalArgsErrorMessage(Arity arity, Object[] arguments, int cntMissingPositional) {
253253
StringBuilder builder = new StringBuilder();
254254
String currentName = null;
255255
String[] parameterIds = arity.getParameterIds();
@@ -280,7 +280,7 @@ private String getMissingPositionalArgsErrorMessage(Arity arity, Object[] argume
280280
}
281281

282282
@TruffleBoundary
283-
private String getExtraPositionalArgsErrorMessage(Arity arity, int numOfArgs, String[] givenKeywords) {
283+
private static String getExtraPositionalArgsErrorMessage(Arity arity, int numOfArgs, String[] givenKeywords) {
284284
String givenCountMessage = (numOfArgs == 1) ? "was" : "were";
285285
Set<String> keywordsOnly = arity.getKeywordsOnlyArgs();
286286
int givenKeywordOnlyArgs = 0;

0 commit comments

Comments
 (0)