add isIterable node

- fixed style issues

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/NodeFactory.java

@@ -53,6 +53,7 @@
 import com.oracle.graal.python.nodes.control.WhileNode;
 import com.oracle.graal.python.nodes.datamodel.IsCallableNode;
 import com.oracle.graal.python.nodes.datamodel.IsContextManagerNode;
+import com.oracle.graal.python.nodes.datamodel.IsIterableNode;
 import com.oracle.graal.python.nodes.datamodel.IsMappingNode;
 import com.oracle.graal.python.nodes.datamodel.IsSequenceNode;
 import com.oracle.graal.python.nodes.datamodel.PDataModelEmulationNode;
@@ -529,4 +530,8 @@ public PDataModelEmulationNode createIsContextManager() {
     public PDataModelEmulationNode createIsCallable() {
         return IsCallableNode.create();
     }
+
+    public PDataModelEmulationNode createIsIterable() {
+        return IsIterableNode.create();
+    }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/attributes/HasInheritedAttributeNode.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, Oracle and/or its affiliates.
+ * Copyright (c) 2017, Oracle and/or its affiliates.
  *
  * The Universal Permissive License (UPL), Version 1.0
  *

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/datamodel/IsCallableNode.java

@@ -62,22 +62,22 @@ protected boolean isSpecialCallable(Object callable) {
     }
 
     @Specialization
-    protected boolean isMethod(PMethod callable) {
+    protected boolean isMethod(@SuppressWarnings("unused") PMethod callable) {
         return true;
     }
 
     @Specialization
-    protected boolean isBuiltinMethod(PBuiltinMethod callable) {
+    protected boolean isBuiltinMethod(@SuppressWarnings("unused") PBuiltinMethod callable) {
         return true;
     }
 
     @Specialization
-    protected boolean isFunctionCall(PFunction callable) {
+    protected boolean isFunctionCall(@SuppressWarnings("unused") PFunction callable) {
         return true;
     }
 
     @Specialization
-    protected boolean isBuiltinFunctionCall(PBuiltinFunction callable) {
+    protected boolean isBuiltinFunctionCall(@SuppressWarnings("unused") PBuiltinFunction callable) {
         return true;
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/datamodel/IsIterableNode.java

@@ -0,0 +1,117 @@
+/*
+ * Copyright (c) 2018, Oracle and/or its affiliates.
+ *
+ * The Universal Permissive License (UPL), Version 1.0
+ *
+ * Subject to the condition set forth below, permission is hereby granted to any
+ * person obtaining a copy of this software, associated documentation and/or data
+ * (collectively the "Software"), free of charge and under any and all copyright
+ * rights in the Software, and any and all patent rights owned or freely
+ * licensable by each licensor hereunder covering either (i) the unmodified
+ * Software as contributed to or provided by such licensor, or (ii) the Larger
+ * Works (as defined below), to deal in both
+ *
+ * (a) the Software, and
+ * (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
+ *     one is included with the Software (each a "Larger Work" to which the
+ *     Software is contributed by such licensors),
+ *
+ * without restriction, including without limitation the rights to copy, create
+ * derivative works of, display, perform, and distribute the Software and make,
+ * use, sell, offer for sale, import, export, have made, and have sold the
+ * Software and the Larger Work(s), and to sublicense the foregoing rights on
+ * either these or other terms.
+ *
+ * This license is subject to the following condition:
+ *
+ * The above copyright notice and either this complete permission notice or at a
+ * minimum a reference to the UPL must be included in all copies or substantial
+ * portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+package com.oracle.graal.python.nodes.datamodel;
+
+import static com.oracle.graal.python.nodes.SpecialMethodNames.__ITER__;
+import static com.oracle.graal.python.nodes.SpecialMethodNames.__NEXT__;
+
+import com.oracle.graal.python.builtins.objects.PNone;
+import com.oracle.graal.python.builtins.objects.array.PCharArray;
+import com.oracle.graal.python.builtins.objects.array.PDoubleArray;
+import com.oracle.graal.python.builtins.objects.array.PIntArray;
+import com.oracle.graal.python.builtins.objects.array.PLongArray;
+import com.oracle.graal.python.builtins.objects.iterator.PZip;
+import com.oracle.graal.python.builtins.objects.range.PRange;
+import com.oracle.graal.python.nodes.attributes.HasInheritedAttributeNode;
+import com.oracle.graal.python.nodes.attributes.LookupInheritedAttributeNode;
+import com.oracle.graal.python.runtime.sequence.PSequence;
+import com.oracle.truffle.api.dsl.Specialization;
+import com.oracle.truffle.api.profiles.ConditionProfile;
+
+public abstract class IsIterableNode extends PDataModelEmulationNode {
+    @Child private HasInheritedAttributeNode hasNextNode = HasInheritedAttributeNode.create(__NEXT__);
+    @Child private LookupInheritedAttributeNode getIterNode = LookupInheritedAttributeNode.create();
+
+    private final ConditionProfile profileIter = ConditionProfile.createBinaryProfile();
+    private final ConditionProfile profileNext = ConditionProfile.createBinaryProfile();
+
+    @Specialization
+    public boolean isIterable(@SuppressWarnings("unused") PRange range) {
+        return true;
+    }
+
+    @Specialization
+    public boolean isIterable(@SuppressWarnings("unused") PIntArray array) {
+        return true;
+    }
+
+    @Specialization
+    public boolean isIterable(@SuppressWarnings("unused") PLongArray array) {
+        return true;
+    }
+
+    @Specialization
+    public boolean isIterable(@SuppressWarnings("unused") PDoubleArray array) {
+        return true;
+    }
+
+    @Specialization
+    public boolean isIterable(@SuppressWarnings("unused") PCharArray array) {
+        return true;
+    }
+
+    @Specialization
+    public boolean isIterable(@SuppressWarnings("unused") PSequence sequence) {
+        return true;
+    }
+
+    @Specialization
+    public boolean isIterable(@SuppressWarnings("unused") String str) {
+        return true;
+    }
+
+    @Specialization
+    public boolean isIterable(@SuppressWarnings("unused") PZip zip) {
+        return true;
+    }
+
+    @Specialization
+    public boolean isIterable(Object object) {
+        Object iterMethod = getIterNode.execute(object, __ITER__);
+        if (profileIter.profile(iterMethod != PNone.NO_VALUE)) {
+            return iterMethod != PNone.NONE;
+        } else {
+            return profileNext.profile(hasNextNode.execute(object));
+        }
+    }
+
+    public static IsIterableNode create() {
+        return IsIterableNodeGen.create();
+    }
+}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/datamodel/IsMappingNode.java

@@ -58,8 +58,8 @@ public abstract class IsMappingNode extends PDataModelEmulationNode {
     public boolean isMapping(Object object) {
         if (isSequence.execute(object)) {
             return profile.profile((hasKeysNode.execute(object)) &&
-                    (hasItemsNode.execute(object)) &&
-                    (hasValuesNode.execute(object)));
+                            (hasItemsNode.execute(object)) &&
+                            (hasValuesNode.execute(object)));
         }
         return false;
     }