Skip to content

Commit 2ff3778

Browse files
committed
intrinsified PyFunc
1 parent f125a83 commit 2ff3778

File tree

4 files changed

+95
-7
lines changed

4 files changed

+95
-7
lines changed

graalpython/com.oracle.graal.python.test/src/tests/cpyext/test_functions.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ def compile_module(self, name):
7272
type,
7373
lambda: ([], 12, sys.modules)
7474
)
75-
75+
7676
# Below are the PyObject_* identifiers that we know are used in numpy
77-
77+
7878
def is_buffer(x):
7979
__breakpoint__()
8080
if (isinstance(x, bytes) or isinstance(x, bytearray) or isinstance(x, array.array)):
@@ -459,3 +459,14 @@ def _ref_hash_not_implemented(args):
459459
# )
460460
# test_PyObject_Init = CPyExtFunction(
461461
# )
462+
463+
test_PyStaticMethod_New = CPyExtFunction(
464+
lambda args: None,
465+
lambda: (
466+
(kw_fun,),
467+
),
468+
resultspec="O",
469+
arguments=["PyObject* func"],
470+
argspec="O",
471+
cmpfunc=lambda x, y: type(x) == staticmethod
472+
)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/Python3Core.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@
123123
import com.oracle.graal.python.builtins.modules.cext.PythonCextAbstractBuiltins;
124124
import com.oracle.graal.python.builtins.modules.cext.PythonCextErrBuiltins;
125125
import com.oracle.graal.python.builtins.modules.cext.PythonCextDescrBuiltins;
126+
import com.oracle.graal.python.builtins.modules.cext.PythonCextFuncBuiltins;
126127
import com.oracle.graal.python.builtins.modules.cext.PythonCextIterBuiltins;
127128
import com.oracle.graal.python.builtins.modules.cext.PythonCextModuleBuiltins;
128129
import com.oracle.graal.python.builtins.modules.cext.PythonCextNamespaceBuiltins;
@@ -498,6 +499,7 @@ private static PythonBuiltins[] initializeBuiltins(boolean nativeAccessAllowed)
498499
new PythonCextErrBuiltins(),
499500
new PythonCextFileBuiltins(),
500501
new PythonCextFloatBuiltins(),
502+
new PythonCextFuncBuiltins(),
501503
new PythonCextImportBuiltins(),
502504
new PythonCextIterBuiltins(),
503505
new PythonCextListBuiltins(),
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
/*
2+
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* The Universal Permissive License (UPL), Version 1.0
6+
*
7+
* Subject to the condition set forth below, permission is hereby granted to any
8+
* person obtaining a copy of this software, associated documentation and/or
9+
* data (collectively the "Software"), free of charge and under any and all
10+
* copyright rights in the Software, and any and all patent rights owned or
11+
* freely licensable by each licensor hereunder covering either (i) the
12+
* unmodified Software as contributed to or provided by such licensor, or (ii)
13+
* the Larger Works (as defined below), to deal in both
14+
*
15+
* (a) the Software, and
16+
*
17+
* (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
18+
* one is included with the Software each a "Larger Work" to which the Software
19+
* is contributed by such licensors),
20+
*
21+
* without restriction, including without limitation the rights to copy, create
22+
* derivative works of, display, perform, and distribute the Software and make,
23+
* use, sell, offer for sale, import, export, have made, and have sold the
24+
* Software and the Larger Work(s), and to sublicense the foregoing rights on
25+
* either these or other terms.
26+
*
27+
* This license is subject to the following condition:
28+
*
29+
* The above copyright notice and either this complete permission notice or at a
30+
* minimum a reference to the UPL must be included in all copies or substantial
31+
* portions of the Software.
32+
*
33+
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
34+
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
35+
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
36+
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
37+
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
38+
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
39+
* SOFTWARE.
40+
*/
41+
package com.oracle.graal.python.builtins.modules.cext;
42+
43+
import com.oracle.graal.python.builtins.Builtin;
44+
import java.util.List;
45+
import com.oracle.graal.python.builtins.CoreFunctions;
46+
import com.oracle.graal.python.builtins.Python3Core;
47+
import com.oracle.graal.python.builtins.PythonBuiltinClassType;
48+
import com.oracle.graal.python.builtins.PythonBuiltins;
49+
import com.oracle.graal.python.builtins.objects.method.PDecoratedMethod;
50+
import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
51+
import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
52+
import com.oracle.truffle.api.dsl.GenerateNodeFactory;
53+
import com.oracle.truffle.api.dsl.NodeFactory;
54+
import com.oracle.truffle.api.dsl.Specialization;
55+
56+
@CoreFunctions(extendsModule = PythonCextBuiltins.PYTHON_CEXT)
57+
@GenerateNodeFactory
58+
public final class PythonCextFuncBuiltins extends PythonBuiltins {
59+
60+
@Override
61+
protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFactories() {
62+
return PythonCextFuncBuiltinsFactory.getFactories();
63+
}
64+
65+
@Override
66+
public void initialize(Python3Core core) {
67+
super.initialize(core);
68+
}
69+
70+
@Builtin(name = "PyStaticMethod_New", minNumOfPositionalArgs = 1)
71+
@GenerateNodeFactory
72+
public abstract static class PyStaticMethodNewNode extends PythonUnaryBuiltinNode {
73+
@Specialization
74+
public Object staticmethod(Object func) {
75+
PDecoratedMethod res = factory().createStaticmethod(PythonBuiltinClassType.PStaticmethod);
76+
res.setCallable(func);
77+
return res;
78+
}
79+
}
80+
}

graalpython/lib-graalpython/python_cext.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,6 @@ def __repr__(self):
8585
def PyInstanceMethod_New(func):
8686
return instancemethod(func)
8787

88-
89-
@may_raise
90-
def PyStaticMethod_New(func):
91-
return staticmethod(func)
92-
9388
@may_raise
9489
def dict_from_list(lst):
9590
if len(lst) % 2 != 0:

0 commit comments

Comments
 (0)