[GR-25464] [GR-23214] [GR-23232] [GR-23205] Update less important tests and changelog for the release

PullRequest: graalpython/1343

Author: timfel

.mx_vcs_root

@@ -3,9 +3,23 @@
 This changelog summarizes major changes between GraalVM versions of the Python
 language runtime. The main focus is on user-observable behavior of the engine.
 
+## Version 20.3.0
+
+* Fix multiple memory leaks when running Python code in a shared engine.
+* Update language support target and standard library to 3.8.5
+* Hide internal catching frames from tracebacks
+* Update HPy support to the latest version with support for piconumpy
+* Many fixes to pass the unittests of standard library types and modules:
+  complex, bytes, bytearray, subclassing of special descriptors, type layouts,
+  float, generators, modules, argument passing corner cases, string literals and
+  encodings, import and importlib, decimal, glob, the builtin module, json,
+  math, operator, numeric tower, sys, warnings, random, f-strings, struct,
+  itertools
+
 ## Version 20.2.0
 
-* Escaping Unicode characters using the character names in strings like "\N{GREEK CAPITAL LETTER DELTA}".
+* Escaping Unicode characters using the character names in strings like
+  "\N{GREEK CAPITAL LETTER DELTA}".
 * When a `*.py` file is imported, `*.pyc` file is created. It contains binary data to speed up parsing.
 * Adding option `PyCachePrefix`, which is equivalent to PYTHONPYCACHEPREFIX environment variable, which is also accepted now. 
 * Adding optin `DontWriteBytecodeFlag`. Equivalent to the Python -B flag. Don't write bytecode files.

CHANGELOG.md

@@ -0,0 +1 @@
+*graalpython.lib-python.3.test.test_descrtut.TestMain.test_main

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_descrtut.txt

@@ -29,6 +29,7 @@
 import java.lang.management.ManagementFactory;
 import java.util.List;
 
+import com.oracle.graal.python.PythonLanguage;
 import com.oracle.graal.python.builtins.Builtin;
 import com.oracle.graal.python.builtins.CoreFunctions;
 import com.oracle.graal.python.builtins.PythonBuiltins;
@@ -38,8 +39,12 @@
 import com.oracle.graal.python.builtins.objects.list.PList;
 import com.oracle.graal.python.builtins.objects.tuple.PTuple;
 import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
+import com.oracle.graal.python.runtime.PythonContext;
+import com.oracle.graal.python.runtime.PythonCore;
+import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.CachedContext;
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateNodeFactory;
 import com.oracle.truffle.api.dsl.Specialization;
@@ -54,48 +59,70 @@ protected List<com.oracle.truffle.api.dsl.NodeFactory<? extends PythonBuiltinNod
         return GcModuleBuiltinsFactory.getFactories();
     }
 
+    @Override
+    public void initialize(PythonCore core) {
+        builtinConstants.put("DEBUG_LEAK", 0);
+        super.initialize(core);
+    }
+
     @Builtin(name = "collect", minNumOfPositionalArgs = 0, maxNumOfPositionalArgs = 1)
     @GenerateNodeFactory
     abstract static class GcCollectNode extends PythonBuiltinNode {
         @Specialization
         int collect(VirtualFrame frame, @SuppressWarnings("unused") Object level,
                         @Cached BranchProfile asyncProfile) {
-            doGc();
+            PythonUtils.forceFullGC();
             // collect some weak references now
             getContext().triggerAsyncActions(frame, asyncProfile);
             return 0;
         }
-
-        @TruffleBoundary
-        private static void doGc() {
-            System.gc();
-        }
     }
 
     @Builtin(name = "isenabled", minNumOfPositionalArgs = 0)
     @GenerateNodeFactory
     abstract static class GcIsEnabledNode extends PythonBuiltinNode {
         @Specialization
-        boolean isenabled() {
-            return true;
+        boolean isenabled(@CachedContext(PythonLanguage.class) PythonContext ctx) {
+            return ctx.isGcEnabled();
         }
     }
 
-    abstract static class StubNode extends PythonBuiltinNode {
+    @Builtin(name = "disable", minNumOfPositionalArgs = 0)
+    @GenerateNodeFactory
+    abstract static class DisableNode extends PythonBuiltinNode {
         @Specialization
-        PNone disable() {
+        PNone disable(@CachedContext(PythonLanguage.class) PythonContext ctx) {
+            ctx.setGcEnabled(false);
             return PNone.NONE;
         }
     }
 
-    @Builtin(name = "disable", minNumOfPositionalArgs = 0)
+    @Builtin(name = "enable", minNumOfPositionalArgs = 0)
+    @GenerateNodeFactory
+    abstract static class EnableNode extends PythonBuiltinNode {
+        @Specialization
+        PNone enable(@CachedContext(PythonLanguage.class) PythonContext ctx) {
+            ctx.setGcEnabled(true);
+            return PNone.NONE;
+        }
+    }
+
+    @Builtin(name = "get_debug", minNumOfPositionalArgs = 0)
     @GenerateNodeFactory
-    abstract static class DisableNode extends StubNode {
+    abstract static class GetDebugNode extends PythonBuiltinNode {
+        @Specialization
+        int getDebug() {
+            return 0;
+        }
     }
 
-    @Builtin(name = "enable", minNumOfPositionalArgs = 0)
+    @Builtin(name = "set_debug", minNumOfPositionalArgs = 1)
     @GenerateNodeFactory
-    abstract static class EnableNode extends StubNode {
+    abstract static class SetDebugNode extends PythonBuiltinNode {
+        @Specialization
+        PNone setDebug(@SuppressWarnings("unused") Object ignored) {
+            return PNone.NONE;
+        }
     }
 
     @Builtin(name = "get_count", minNumOfPositionalArgs = 0)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/GcModuleBuiltins.java

@@ -66,6 +66,7 @@
 import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
 import com.oracle.graal.python.nodes.object.IsBuiltinClassProfile;
 import com.oracle.graal.python.runtime.AsyncHandler;
+import com.oracle.graal.python.runtime.PythonContext;
 import com.oracle.graal.python.runtime.PythonCore;
 import com.oracle.graal.python.runtime.exception.PythonErrorType;
 import com.oracle.truffle.api.CompilerDirectives;
@@ -111,8 +112,11 @@ public void postInitialize(PythonCore core) {
         PythonModule weakrefModule = core.lookupBuiltinModule("_weakref");
         weakrefModule.setAttribute(weakRefQueueKey, weakRefQueue);
         core.lookupType(PythonBuiltinClassType.PReferenceType).setAttribute(weakRefQueueKey, weakRefQueue);
-
+        final PythonContext ctx = core.getContext();
         core.getContext().registerAsyncAction(() -> {
+            if (!ctx.isGcEnabled()) {
+                return null;
+            }
             Reference<? extends Object> reference = null;
             try {
                 reference = weakRefQueue.remove();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/WeakRefModuleBuiltins.java

@@ -387,7 +387,7 @@ public abstract static class AddNode extends PythonBinaryBuiltinNode {
 
         @Specialization
         public PBytesLike add(PBytesLike self, PBytesLike other,
-                        @Cached SequenceStorageNodes.ConcatNode concatNode,
+                        @Cached("createWithOverflowError()") SequenceStorageNodes.ConcatNode concatNode,
                         @Cached BytesNodes.CreateBytesNode create) {
             SequenceStorage res = concatNode.execute(self.getSequenceStorage(), other.getSequenceStorage());
             return create.execute(factory(), self, res);
@@ -396,7 +396,7 @@ public PBytesLike add(PBytesLike self, PBytesLike other,
         @Specialization(guards = "bufferLib.isBuffer(buffer)", limit = "3")
         public PBytesLike add(PBytesLike self, Object buffer,
                         @CachedLibrary("buffer") PythonObjectLibrary bufferLib,
-                        @Cached("create()") SequenceStorageNodes.ConcatNode concatNode,
+                        @Cached("createWithOverflowError()") SequenceStorageNodes.ConcatNode concatNode,
                         @Cached BytesNodes.CreateBytesNode create) {
             try {
                 byte[] bytes = bufferLib.getBufferBytes(buffer);
@@ -419,7 +419,7 @@ public Object add(Object self, Object other) {
     public abstract static class MulNode extends PythonBinaryBuiltinNode {
         @Specialization
         public PBytesLike mul(VirtualFrame frame, PBytesLike self, int times,
-                        @Cached("create()") SequenceStorageNodes.RepeatNode repeatNode,
+                        @Cached("createWithOverflowError()") SequenceStorageNodes.RepeatNode repeatNode,
                         @Cached BytesNodes.CreateBytesNode create) {
             SequenceStorage res = repeatNode.execute(frame, self.getSequenceStorage(), times);
             return create.execute(factory(), self, res);
@@ -428,7 +428,7 @@ public PBytesLike mul(VirtualFrame frame, PBytesLike self, int times,
         @Specialization(limit = "getCallSiteInlineCacheMaxDepth()")
         public PBytesLike mul(VirtualFrame frame, PBytesLike self, Object times,
                         @Cached("createBinaryProfile()") ConditionProfile hasFrame,
-                        @Cached("create()") SequenceStorageNodes.RepeatNode repeatNode,
+                        @Cached("createWithOverflowError()") SequenceStorageNodes.RepeatNode repeatNode,
                         @Cached BytesNodes.CreateBytesNode create,
                         @CachedLibrary("times") PythonObjectLibrary lib) {
             SequenceStorage res = repeatNode.execute(frame, self.getSequenceStorage(), getTimesInt(frame, times, hasFrame, lib));