Skip to content

Commit 329c973

Browse files
committed
Avoid slowpath in FillKwDefaultsNode
1 parent c24cb5c commit 329c973

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/CreateArgumentsNode.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,6 @@ protected final boolean isSingleContext() {
807807
return PythonLanguage.get(this).isSingleContext();
808808
}
809809

810-
@Idempotent // I think this is true, I would just like the assertion
811810
protected static boolean kwIsCorrect(PKeyword[] kwdefaults, TruffleString kwname, PKeyword result) {
812811
return doUncached(kwdefaults, kwname, TruffleString.EqualNode.getUncached()) == result;
813812
}
@@ -817,11 +816,12 @@ protected static TruffleString.EqualNode getUncachedEqualNode() {
817816
}
818817

819818
@SuppressWarnings("unused")
820-
@Specialization(guards = {"kwname == cachedKwName", "kwdefaults == cachedKwdefaults", "isSingleContext()", "kwIsCorrect(cachedKwdefaults, cachedKwName, result)"}, limit = "1")
819+
@Specialization(guards = {"kwname == cachedKwName", "kwdefaults == cachedKwdefaults", "isSingleContext()"}, limit = "1")
821820
PKeyword cachedSingle(PKeyword[] kwdefaults, TruffleString kwname,
822821
@Cached("kwname") TruffleString cachedKwName,
823822
@Cached(value = "kwdefaults", weak = true, dimensions = 0) PKeyword[] cachedKwdefaults,
824823
@Cached(value = "doUncached(kwdefaults, kwname, getUncachedEqualNode())", weak = true) PKeyword result) {
824+
assert kwIsCorrect(cachedKwdefaults, cachedKwName, result);
825825
return result;
826826
}
827827

0 commit comments

Comments
 (0)