Fix comparison order in the contains operation for sequences

steve-s · steve-s · commit 33393ded7b63 · 2020-11-20T17:03:19.000+01:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/SequenceStorageNodes.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/SequenceStorageNodes.java
@@ -2820,7 +2820,7 @@ static int doGeneric(VirtualFrame frame, SequenceStorage left, Object item,
             ThreadState threadState = PArguments.getThreadState(frame);
             for (int i = 0; i < lenNode.execute(left); i++) {
                 Object leftItem = getItemNode.execute(left, i);
-                if (lib.equalsWithState(leftItem, item, lib, threadState)) {
+                if (lib.equalsWithState(item, leftItem, lib, threadState)) {
                     return i;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -2820,7 +2820,7 @@ static int doGeneric(VirtualFrame frame, SequenceStorage left, Object item,`
`2820`	`2820`	`ThreadState threadState = PArguments.getThreadState(frame);`
`2821`	`2821`	`for (int i = 0; i < lenNode.execute(left); i++) {`
`2822`	`2822`	`Object leftItem = getItemNode.execute(left, i);`
`2823`		`- if (lib.equalsWithState(leftItem, item, lib, threadState)) {`
	`2823`	`+ if (lib.equalsWithState(item, leftItem, lib, threadState)) {`
`2824`	`2824`	`return i;`
`2825`	`2825`	`}`
`2826`	`2826`	`}`