Skip to content

Commit 36f948e

Browse files
committed
Don't release GIL around isMemberInvocable
1 parent 6609034 commit 36f948e

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/lib/PyObjectGetMethod.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
import com.oracle.graal.python.nodes.call.special.MaybeBindDescriptorNode;
6262
import com.oracle.graal.python.nodes.object.GetClassNode;
6363
import com.oracle.graal.python.nodes.object.IsForeignObjectNode;
64-
import com.oracle.graal.python.runtime.GilNode;
6564
import com.oracle.truffle.api.dsl.Bind;
6665
import com.oracle.truffle.api.dsl.Cached;
6766
import com.oracle.truffle.api.dsl.Cached.Shared;
@@ -212,17 +211,9 @@ Object getForeignMethod(VirtualFrame frame, Object receiver, TruffleString name,
212211
@SuppressWarnings("unused") @Cached IsForeignObjectNode isForeignObjectNode,
213212
@Cached TruffleString.ToJavaStringNode toJavaString,
214213
@CachedLibrary("receiver") InteropLibrary lib,
215-
@Cached PyObjectGetAttr getAttr,
216-
@Cached GilNode gil) {
214+
@Cached PyObjectGetAttr getAttr) {
217215
String jName = toJavaString.execute(name);
218-
boolean memberInvocable;
219-
gil.release(true);
220-
try {
221-
memberInvocable = lib.isMemberInvocable(receiver, jName);
222-
} finally {
223-
gil.acquire();
224-
}
225-
if (memberInvocable) {
216+
if (lib.isMemberInvocable(receiver, jName)) {
226217
return new BoundDescriptor(new ForeignMethod(receiver, jName));
227218
} else {
228219
return new BoundDescriptor(getAttr.execute(frame, receiver, name));

0 commit comments

Comments
 (0)