Refuse to start from multithreaded polyglot programs

msimacek · msimacek · commit 38293932834e · 2020-01-16T17:57:26.000+01:00
Avoids a NPE when being started from multithreaded polyglot programs. Since we don't have proper threading support, it just quits with a more appropriate error. Resolves #120
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/PythonLanguage.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/PythonLanguage.java
@@ -582,6 +582,9 @@ protected boolean isThreadAccessAllowed(Thread thread, boolean singleThreaded) {
         if (singleThreaded) {
             return super.isThreadAccessAllowed(thread, singleThreaded);
         }
+        if (isWithThread == null) {
+            isWithThread = false;
+        }
         return isWithThread;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -582,6 +582,9 @@ protected boolean isThreadAccessAllowed(Thread thread, boolean singleThreaded) {`
`582`	`582`	`if (singleThreaded) {`
`583`	`583`	`return super.isThreadAccessAllowed(thread, singleThreaded);`
`584`	`584`	`}`
	`585`	`+ if (isWithThread == null) {`
	`586`	`+ isWithThread = false;`
	`587`	`+ }`
`585`	`588`	`return isWithThread;`
`586`	`589`	`}`
`587`	`590`