Skip to content

Commit 3848c5b

Browse files
committed
Remove unnecessary @Cached(inline = false)
1 parent f510945 commit 3848c5b

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/common/CExtCommonNodes.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1352,7 +1352,7 @@ static Object doGeneric(Node inliningTarget, Object callable, NativeCExtSymbol d
13521352
@Shared @CachedLibrary(limit = "3") InteropLibrary lib,
13531353
@Shared @Cached UnwrapForeignPointerNode unwrapForeignPointerNode,
13541354
@Shared @CachedLibrary(limit = "1") SignatureLibrary signatureLib,
1355-
@Cached(inline = false) IndirectCallNode nfiSignatureFactory) {
1355+
@Cached IndirectCallNode nfiSignatureFactory) {
13561356
PythonContext pythonContext = PythonContext.get(inliningTarget);
13571357
if (!lib.isExecutable(callable)) {
13581358
if (!pythonContext.isNativeAccessAllowed()) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/generator/CommonGeneratorBuiltins.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ abstract static class ResumeGeneratorNode extends Node {
162162

163163
@Specialization(guards = {"!isBytecodeDSLInterpreter()", "sameCallTarget(self.getCurrentCallTarget(), callNode)"}, limit = "getCallSiteInlineCacheMaxDepth()")
164164
static Object cached(VirtualFrame frame, Node inliningTarget, PGenerator self, Object sendValue,
165-
@Cached(parameters = "self.getCurrentCallTarget()", inline = false) DirectCallNode callNode,
165+
@Cached(parameters = "self.getCurrentCallTarget()") DirectCallNode callNode,
166166
@Exclusive @Cached CallDispatchers.SimpleDirectInvokeNode invoke,
167167
@Exclusive @Cached InlinedBranchProfile returnProfile,
168168
@Exclusive @Cached IsBuiltinObjectProfile errorProfile,
@@ -188,7 +188,7 @@ static Object cached(VirtualFrame frame, Node inliningTarget, PGenerator self, O
188188

189189
@Specialization(guards = {"isBytecodeDSLInterpreter()", "sameCallTarget(self.getCurrentCallTarget(), callNode)"}, limit = "getCallSiteInlineCacheMaxDepth()")
190190
static Object cachedBytecodeDSL(VirtualFrame frame, Node inliningTarget, PGenerator self, Object sendValue,
191-
@Cached(parameters = "self.getCurrentCallTarget()", inline = false) DirectCallNode callNode,
191+
@Cached(parameters = "self.getCurrentCallTarget()") DirectCallNode callNode,
192192
@Exclusive @Cached CallDispatchers.SimpleDirectInvokeNode invoke,
193193
@Cached("self.getContinuation() == null") boolean firstCall,
194194
@Exclusive @Cached InlinedBranchProfile returnProfile,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/slots/TpSlotVarargs.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ abstract static class DispatchVarargsBuiltinFullDirectNode extends Node {
263263
@Specialization
264264
static Object call(VirtualFrame frame, Node inliningTarget, TpSlotVarargsBuiltin<?> slot, Object self, Object[] args, PKeyword[] keywords,
265265
@Cached CreateArgumentsNode createArgumentsNode,
266-
@Cached(value = "createDirectCallNode(slot)", inline = false) DirectCallNode callNode,
266+
@Cached("createDirectCallNode(slot)") DirectCallNode callNode,
267267
@Cached CallDispatchers.SimpleDirectInvokeNode invoke) {
268268
CompilerAsserts.partialEvaluationConstant(slot);
269269
Object[] arguments = createArgumentsNode.execute(inliningTarget, slot.getName(), args, keywords, slot.getSignature(), self, null, slot.getDefaults(), slot.getKwDefaults(), false);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/CallDispatchers.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ public static Object executeUncached(RootCallTarget callTarget, Object[] argumen
166166
static Object doDirect(VirtualFrame frame, Node inliningTarget, RootCallTarget callTarget, Object[] arguments,
167167
@Cached InlinedConditionProfile profileIsNullFrame,
168168
@Cached ExecutionContext.CallContext callContext,
169-
@Cached(inline = false) IndirectCallNode callNode) {
169+
@Cached IndirectCallNode callNode) {
170170
if (profileIsNullFrame.profile(inliningTarget, frame == null)) {
171171
PythonContext context = PythonContext.get(inliningTarget);
172172
PythonThreadState threadState = context.getThreadState(context.getLanguage(inliningTarget));

0 commit comments

Comments
 (0)