Skip to content

Commit 38e885e

Browse files
committed
Finally get rid of 'SequenceUtil'.
1 parent e6f5af3 commit 38e885e

File tree

8 files changed

+14
-96
lines changed

8 files changed

+14
-96
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinConstructors.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@
125125
import com.oracle.graal.python.runtime.exception.PException;
126126
import com.oracle.graal.python.runtime.exception.PythonErrorType;
127127
import com.oracle.graal.python.runtime.sequence.PSequence;
128-
import com.oracle.graal.python.runtime.sequence.SequenceUtil;
129128
import com.oracle.truffle.api.CompilerAsserts;
130129
import com.oracle.truffle.api.CompilerDirectives;
131130
import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
@@ -1984,17 +1983,17 @@ Object call(Object klsas, Object set, Object get, Object name, Object owner) {
19841983
public abstract static class CreateSliceNode extends PythonBuiltinNode {
19851984
@Specialization(guards = "isNoValue(second)")
19861985
Object sliceStop(PythonClass cls, int first, PNone second, PNone third) {
1987-
return factory().createSlice(SequenceUtil.MISSING_INDEX, first, SequenceUtil.MISSING_INDEX);
1986+
return factory().createSlice(PSlice.MISSING_INDEX, first, PSlice.MISSING_INDEX);
19881987
}
19891988

19901989
@Specialization(guards = "isNone(second)")
19911990
Object sliceStart(PythonClass cls, int first, PNone second, PNone third) {
1992-
return factory().createSlice(first, SequenceUtil.MISSING_INDEX, SequenceUtil.MISSING_INDEX);
1991+
return factory().createSlice(first, PSlice.MISSING_INDEX, PSlice.MISSING_INDEX);
19931992
}
19941993

19951994
@Specialization(guards = "isNoValue(third)")
19961995
Object slice(PythonClass cls, int first, int second, PNone third) {
1997-
return factory().createSlice(first, second, SequenceUtil.MISSING_INDEX);
1996+
return factory().createSlice(first, second, PSlice.MISSING_INDEX);
19981997
}
19991998

20001999
@Specialization

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/bytes/ByteArrayBuiltins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
package com.oracle.graal.python.builtins.objects.bytes;
2828

29+
import static com.oracle.graal.python.builtins.objects.slice.PSlice.MISSING_INDEX;
2930
import static com.oracle.graal.python.nodes.SpecialMethodNames.__ADD__;
3031
import static com.oracle.graal.python.nodes.SpecialMethodNames.__BOOL__;
3132
import static com.oracle.graal.python.nodes.SpecialMethodNames.__DELITEM__;
@@ -46,7 +47,6 @@
4647
import static com.oracle.graal.python.runtime.exception.PythonErrorType.SystemError;
4748
import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
4849
import static com.oracle.graal.python.runtime.exception.PythonErrorType.ValueError;
49-
import static com.oracle.graal.python.runtime.sequence.SequenceUtil.MISSING_INDEX;
5050

5151
import java.util.List;
5252

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/foreign/AccessForeignItemNodes.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
import com.oracle.graal.python.nodes.interop.PTypeToForeignNode;
6363
import com.oracle.graal.python.runtime.object.PythonObjectFactory;
6464
import com.oracle.graal.python.runtime.sequence.PSequence;
65-
import com.oracle.graal.python.runtime.sequence.SequenceUtil;
6665
import com.oracle.truffle.api.CompilerDirectives;
6766
import com.oracle.truffle.api.dsl.Cached;
6867
import com.oracle.truffle.api.dsl.ImportStatic;
@@ -100,15 +99,15 @@ protected SliceInfo materializeSlice(PSlice idxSlice, TruffleObject object, Node
10099
// determine start
101100
boolean isStartMissing = false;
102101
int start = idxSlice.getStart();
103-
if (start == SequenceUtil.MISSING_INDEX) {
102+
if (start == PSlice.MISSING_INDEX) {
104103
start = 0;
105104
isStartMissing = true;
106105
}
107106

108107
// determine stop
109108
int end = idxSlice.getStop();
110109
int foreignSize = -1;
111-
if (end == SequenceUtil.MISSING_INDEX) {
110+
if (end == PSlice.MISSING_INDEX) {
112111
foreignSize = getForeignSize(object, getSizeNode, foreign2PTypeNode);
113112
end = foreignSize;
114113
} else if (isStartMissing) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/range/RangeBuiltins.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
5050
import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
5151
import com.oracle.graal.python.nodes.truffle.PythonArithmeticTypes;
52-
import com.oracle.graal.python.runtime.sequence.SequenceUtil;
5352
import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
5453
import com.oracle.truffle.api.dsl.Fallback;
5554
import com.oracle.truffle.api.dsl.GenerateNodeFactory;
@@ -210,8 +209,8 @@ Object doPRange(PRange primary, PInt idx) {
210209
Object doPRange(PRange range, PSlice slice) {
211210
SliceInfo info = slice.computeActualIndices(range.len());
212211
int newStep = range.getStep() * info.step;
213-
int newStart = info.start == SequenceUtil.MISSING_INDEX ? range.getStart() : range.getStart() + info.start * range.getStep();
214-
int newStop = info.stop == SequenceUtil.MISSING_INDEX ? range.getStop() : Math.min(range.getStop(), newStart + info.length * newStep);
212+
int newStart = info.start == PSlice.MISSING_INDEX ? range.getStart() : range.getStart() + info.start * range.getStep();
213+
int newStop = info.stop == PSlice.MISSING_INDEX ? range.getStop() : Math.min(range.getStop(), newStart + info.length * newStep);
215214
return factory().createRange(newStart, newStop, newStep);
216215
}
217216

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/slice/PSlice.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
package com.oracle.graal.python.builtins.objects.slice;
2727

2828
import static com.oracle.graal.python.runtime.exception.PythonErrorType.ValueError;
29-
import static com.oracle.graal.python.runtime.sequence.SequenceUtil.MISSING_INDEX;
3029

3130
import com.oracle.graal.python.PythonLanguage;
3231
import com.oracle.graal.python.builtins.objects.object.PythonBuiltinObject;
@@ -37,6 +36,8 @@
3736

3837
public class PSlice extends PythonBuiltinObject {
3938

39+
public static final int MISSING_INDEX = Integer.MIN_VALUE;
40+
4041
protected int start;
4142
protected int stop;
4243
protected final int step;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/slice/SliceBuiltins.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
3939
import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
4040
import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
41-
import com.oracle.graal.python.runtime.sequence.SequenceUtil;
4241
import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
4342
import com.oracle.truffle.api.dsl.GenerateNodeFactory;
4443
import com.oracle.truffle.api.dsl.ImportStatic;
@@ -74,7 +73,7 @@ boolean doPRange(PSlice left, PSlice right) {
7473

7574
@Builtin(name = "start", fixedNumOfPositionalArgs = 1, isGetter = true)
7675
@GenerateNodeFactory
77-
@ImportStatic(SequenceUtil.class)
76+
@ImportStatic(PSlice.class)
7877
abstract static class StartNode extends PythonUnaryBuiltinNode {
7978

8079
@Specialization(guards = "self.getStart() != MISSING_INDEX")
@@ -90,7 +89,7 @@ protected Object getNone(@SuppressWarnings("unused") PSlice self) {
9089

9190
@Builtin(name = "stop", fixedNumOfPositionalArgs = 1, isGetter = true)
9291
@GenerateNodeFactory
93-
@ImportStatic(SequenceUtil.class)
92+
@ImportStatic(PSlice.class)
9493
abstract static class StopNode extends PythonUnaryBuiltinNode {
9594

9695
@Specialization(guards = "self.getStop() != MISSING_INDEX")
@@ -106,7 +105,7 @@ protected Object getNone(@SuppressWarnings("unused") PSlice self) {
106105

107106
@Builtin(name = "step", fixedNumOfPositionalArgs = 1, isGetter = true)
108107
@GenerateNodeFactory
109-
@ImportStatic(SequenceUtil.class)
108+
@ImportStatic(PSlice.class)
110109
abstract static class StepNode extends PythonUnaryBuiltinNode {
111110

112111
@Specialization(guards = "self.getStep() != MISSING_INDEX")

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/subscript/SliceLiteralNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*/
2626
package com.oracle.graal.python.nodes.subscript;
2727

28-
import static com.oracle.graal.python.runtime.sequence.SequenceUtil.MISSING_INDEX;
28+
import static com.oracle.graal.python.builtins.objects.slice.PSlice.MISSING_INDEX;
2929

3030
import com.oracle.graal.python.builtins.objects.PNone;
3131
import com.oracle.graal.python.builtins.objects.ints.PInt;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/SequenceUtil.java

Lines changed: 0 additions & 79 deletions
This file was deleted.

0 commit comments

Comments
 (0)