Skip to content

Commit 3c94bfd

Browse files
committed
[GR-53462] Use the correct EE labsjdk for EE CI jobs and do not use graal common at all
PullRequest: graalpython/3945
2 parents 2e1ae2b + ea81d23 commit 3c94bfd

File tree

5 files changed

+27
-32
lines changed

5 files changed

+27
-32
lines changed

ci.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@
329329
GPY_RELEASE[self.os].url,
330330
]
331331
],
332-
"logs"+: [
332+
logs+: [
333333
"wheelhouse/*.whl",
334334
],
335335
}),

ci/constants.libsonnet

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
local graal_common = import "graal/ci/common.jsonnet",
2+
local common = import "graal/ci/common.jsonnet",
33

44
MX_VERSION:: "HEAD",
55

@@ -24,12 +24,12 @@
2424
},
2525

2626
TARGET:: {
27-
onDemand: graal_common.frequencies.on_demand.targets,
28-
postMerge: graal_common.frequencies.post_merge.targets,
29-
daily: graal_common.frequencies.daily.targets,
30-
weekly: graal_common.frequencies.weekly.targets,
31-
monthly: graal_common.frequencies.monthly.targets,
32-
gate: graal_common.frequencies.gate.targets,
27+
onDemand: common.frequencies.on_demand.targets,
28+
postMerge: common.frequencies.post_merge.targets,
29+
daily: common.frequencies.daily.targets,
30+
weekly: common.frequencies.weekly.targets,
31+
monthly: common.frequencies.monthly.targets,
32+
gate: common.frequencies.gate.targets,
3333
},
3434

3535
NOTIFY_GROUPS:: ["[email protected]"],

ci/python-bench.libsonnet

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
(import "python-gate.libsonnet") +
22
{
3-
local graal_common = import "graal/common.json",
4-
local common = import "graal/ci/ci_common/common.jsonnet",
3+
local common = import "graal/ci/common.jsonnet",
54
local common_util = import "graal/ci/ci_common/common-utils.libsonnet",
65
local run_spec = import "graal/ci/ci_common/run-spec.libsonnet",
76
local tools = import "graal/ci/ci_common/run-spec-tools.libsonnet",

ci/python-gate.libsonnet

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
2-
local graal_common = import "graal/ci/common.jsonnet",
3-
local common = import "graal/ci/ci_common/common.jsonnet",
2+
local common = import "graal/ci/common.jsonnet",
43
local common_util = import "graal/ci/ci_common/common-utils.libsonnet",
54
local run_spec = import "graal/ci/ci_common/run-spec.libsonnet",
65
local tools = import "graal/ci/ci_common/run-spec-tools.libsonnet",
@@ -27,10 +26,8 @@
2726
//
2827
// -----------------------------------------------------------------------------------------------------------------
2928
local jdk_name_to_dict = {[edition]: {
30-
"jdk17"+: common.labsjdk17,
31-
"jdk20"+: common.labsjdk20,
32-
"jdk21"+: common.labsjdk21,
33-
"jdk-latest"+: common.labsjdkLatest,
29+
"jdk21"+: common.jdks["labsjdk-" + edition + "-21"],
30+
"jdk-latest"+: common.jdks["labsjdk-" + edition + "-latest"],
3431
} for edition in ['ce', 'ee']},
3532

3633
local jdk_name_to_devkit_suffix = function(name)
@@ -81,7 +78,7 @@
8178
//------------------------------------------------------------------------------------------------------------------
8279
local DOWNLOADS = {
8380
common: {
84-
GRADLE_JAVA_HOME: graal_common.jdks_data["oraclejdk21"],
81+
GRADLE_JAVA_HOME: common.jdks_data["oraclejdk21"],
8582
},
8683
linux: {
8784
common: {
@@ -253,22 +250,21 @@
253250
timelimit(limit):: task_spec({timelimit: limit}),
254251

255252
local tierConfig = {
256-
"tier1": graal_common.frequencies.gate.targets[0],
257-
"tier2": graal_common.frequencies.gate.targets[0],
258-
"tier3": graal_common.frequencies.gate.targets[0],
259-
"tier4": graal_common.frequencies.post_merge.targets[0],
253+
"tier1": "gate",
254+
"tier2": "gate",
255+
"tier3": "gate",
260256
},
261257
tierConfig: tierConfig,
262258
tier1:: $.target("tier1"),
263259
tier2:: $.target("tier2"),
264260
tier3:: $.target("tier3"),
265261
post_merge:: $.target("post-merge") + task_spec({name_target:: "post_merge"}),
266262

267-
bench:: $.target(graal_common.frequencies.bench.targets[0]),
268-
on_demand:: $.target(graal_common.frequencies.on_demand.targets[0]) + task_spec({name_target:: "on_demand"}),
269-
daily:: $.target(graal_common.frequencies.daily.targets[0]),
270-
weekly:: $.target(graal_common.frequencies.weekly.targets[0]),
271-
monthly:: $.target(graal_common.frequencies.monthly.targets[0]),
263+
bench:: $.target("bench"),
264+
on_demand:: $.target("ondemand") + task_spec({name_target:: "on_demand"}),
265+
daily:: $.target("daily"),
266+
weekly:: $.target("weekly"),
267+
monthly:: $.target("monthly"),
272268

273269
provide_graalpy_standalone_artifact(name):: task_spec(evaluate_late(
274270
// use 2 after _ to make sure we evaluate this right after _1 late eval keys like _1_os_arch_jdk
@@ -443,13 +439,13 @@
443439

444440
local jdk_spec = task_spec(evaluate_late({
445441
"select_graalvm_if_older_jdk": function (b)
446-
if b.jdk_version < graal_common.jdks["labsjdk-ee-latest"].jdk_version then
442+
if b.jdk_version < common.jdks["labsjdk-ee-latest"].jdk_version then
447443
{
448444
downloads+: {
449-
LATEST_JAVA_HOME: graal_common.jdks_data["labsjdk-ce-latest"],
445+
LATEST_JAVA_HOME: common.jdks_data["labsjdk-ce-latest"],
450446
}
451447
} +
452-
graal_common.jdks["graalvm-ee-" + b.jdk_version] +
448+
common.jdks["graalvm-ee-" + b.jdk_version] +
453449
{
454450
dynamic_imports+:: [],
455451
environment+: {
@@ -567,7 +563,7 @@
567563
local base_style_gate = $.graalpy_eclipse_gate + task_spec({
568564
dynamic_imports:: ["/truffle"],
569565
downloads +: {
570-
EXTRA_JAVA_HOMES: graal_common.jdks_data["labsjdk-ce-21"],
566+
EXTRA_JAVA_HOMES: common.jdks_data["labsjdk-ce-21"],
571567
},
572568
packages +: {
573569
"pip:pylint": "==2.4.4",

ci/utils.libsonnet

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
local const = import 'constants.libsonnet';
2-
local graal_common = import "graal/ci/common.jsonnet";
2+
local common = import "graal/ci/common.jsonnet";
33

44
{
55
// add a graal option
@@ -36,7 +36,7 @@ local graal_common = import "graal/ci/common.jsonnet";
3636

3737
ensure_no_mx_wrong_build(builds):: [
3838
b + (
39-
if std.objectHas(b, "setup") && b.jdk_version != graal_common.jdks["labsjdk-ee-latest"].jdk_version then
39+
if std.objectHas(b, "setup") && b.jdk_version != common.jdks["labsjdk-ee-latest"].jdk_version then
4040
assert (std.length([step for step in b.setup if std.length(std.find("build", step)) != 0 && std.length(std.find("mx", step)) != 0]) == 0) : b.name + " should not call build in " + b.setup;
4141
{}
4242
else

0 commit comments

Comments
 (0)