[GR-51959] Load C API when using ctypes.dlopen

PullRequest: graalpython/3360

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SignalModuleBuiltins.java

@@ -360,7 +360,7 @@ private static Object signal(Node raisingNode, int signum, int id, ModuleData da
         }
     }
 
-    @Builtin(name = "set_wakeup_fd", minNumOfPositionalArgs = 1, parameterNames = {"", "warn_on_full_buffer"})
+    @Builtin(name = "set_wakeup_fd", minNumOfPositionalArgs = 1, numOfPositionalOnlyArgs = 1, parameterNames = {"fd", "warn_on_full_buffer"})
     @GenerateNodeFactory
     abstract static class SetWakeupFdNode extends PythonBuiltinNode {
         @Specialization

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/bz2/BZ2DecompressorBuiltins.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2020, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2020, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -105,7 +105,7 @@ static PNone init(BZ2Object.BZ2Decompressor self,
         }
     }
 
-    @Builtin(name = "decompress", minNumOfPositionalArgs = 1, parameterNames = {"$self", "", "max_length"})
+    @Builtin(name = "decompress", minNumOfPositionalArgs = 1, parameterNames = {"$self", "data", "max_length"})
     @ArgumentClinic(name = "max_length", conversion = ArgumentClinic.ClinicConversion.Int, defaultValue = "-1", useDefaultForNone = true)
     @GenerateNodeFactory
     abstract static class DecompressNode extends PythonTernaryClinicBuiltinNode {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ctypes/CtypesModuleBuiltins.java

@@ -630,7 +630,7 @@ static Object buffer_info(Object arg,
         }
     }
 
-    @Builtin(name = "resize", minNumOfPositionalArgs = 2, parameterNames = {"", "size"})
+    @Builtin(name = "resize", minNumOfPositionalArgs = 2, numOfPositionalOnlyArgs = 2, parameterNames = {"obj", "size"})
     @ArgumentClinic(name = "size", conversion = ClinicConversion.Int)
     @GenerateNodeFactory
     protected abstract static class ResizeNode extends PythonBinaryClinicBuiltinNode {
@@ -746,6 +746,9 @@ static Object py_dl_open(VirtualFrame frame, PythonModule self, TruffleString na
                 return factory.createNativeVoidPtr(((CtypesModuleBuiltins) self.getBuiltins()).rtldDefault);
             }
 
+            // The loaded library can link against libpython, so we have to make sure it is loaded
+            CApiContext.ensureCapiWasLoaded();
+
             int mode = m != Integer.MIN_VALUE ? m : RTLD_LOCAL.getValueIfDefined();
             mode |= RTLD_NOW.getValueIfDefined();
             PythonContext context = PythonContext.get(inliningTarget);
@@ -986,7 +989,7 @@ static Object doit(Object obj,
         }
     }
 
-    @Builtin(name = "byref", minNumOfPositionalArgs = 1, parameterNames = {"", "offset"})
+    @Builtin(name = "byref", minNumOfPositionalArgs = 1, numOfPositionalOnlyArgs = 2, parameterNames = {"instance", "offset"})
     @ArgumentClinic(name = "offset", conversion = ClinicConversion.Int, defaultValue = "0", useDefaultForNone = true)
     @GenerateNodeFactory
     protected abstract static class ByRefNode extends PythonBinaryClinicBuiltinNode {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/io/FileIOBuiltins.java

@@ -847,7 +847,7 @@ static void deallocWarn(VirtualFrame frame, PFileIO self,
         }
     }
 
-    @Builtin(name = J_TRUNCATE, minNumOfPositionalArgs = 1, parameterNames = {"$self", ""})
+    @Builtin(name = J_TRUNCATE, minNumOfPositionalArgs = 1, numOfPositionalOnlyArgs = 2, parameterNames = {"$self", "size"})
     @GenerateNodeFactory
     abstract static class TruncateNode extends PythonBinaryBuiltinNode {
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/zlib/ZLibModuleBuiltins.java

@@ -402,7 +402,7 @@ long nativeCrc32(byte[] bytes, int len, int value,
     }
 
     // zlib.adler32(data[, value])
-    @Builtin(name = "adler32", minNumOfPositionalArgs = 1, parameterNames = {"", "value"})
+    @Builtin(name = "adler32", minNumOfPositionalArgs = 1, numOfPositionalOnlyArgs = 2, parameterNames = {"data", "value"})
     @ArgumentClinic(name = "value", conversionClass = ZLibModuleBuiltins.ExpectIntNode.class, defaultValue = "PNone.NO_VALUE", useDefaultForNone = true)
     @TypeSystemReference(PythonArithmeticTypes.class)
     @GenerateNodeFactory

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/function/BuiltinFunctionRootNode.java

@@ -217,6 +217,9 @@ private static Signature createSignature(NodeFactory<? extends PythonBuiltinBase
                     PythonUtils.arraycopy(parameterNames, 0, parameterNames, 1, parameterNames.length - 1);
                     parameterNames[0] = constructsClass ? T_DOLLAR_DECL_TYPE : T_DOLLAR_SELF;
                 }
+                for (TruffleString name : parameterNames) {
+                    assert !name.isEmpty() : "empty parameter name not allowed on " + factory;
+                }
             }
         }
         assert canUseSpecialBuiltinNode(builtin) || !usesSpecialBuiltinNode(factory.getNodeClass()) : factory.getNodeClass().getName() +