[GR-18449] Assigning to a literal should raise error.

PullRequest: graalpython/670

Author: ppisl

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/parser/AssignmentTests.java

@@ -167,4 +167,33 @@ public void augassign14() throws Exception {
                                         "    cls_or_self, *rest = args");
     }
 
+    @Test
+    public void assignToLiteral01() throws Exception {
+        checkSyntaxErrorMessage("1 = 1", "SyntaxError: can't assign to literal");
+    }
+
+    @Test
+    public void assignToLiteral02() throws Exception {
+        checkSyntaxErrorMessage("1.1 = 1", "SyntaxError: can't assign to literal");
+    }
+
+    @Test
+    public void assignToLiteral03() throws Exception {
+        checkSyntaxErrorMessage("'' = 1", "SyntaxError: can't assign to literal");
+    }
+
+    @Test
+    public void assignToLiteral04() throws Exception {
+        checkSyntaxErrorMessage("f'' = 1", "SyntaxError: can't assign to literal");
+    }
+
+    @Test
+    public void assignToLiteral05() throws Exception {
+        checkSyntaxErrorMessage("'' f'' = 1", "SyntaxError: can't assign to literal");
+    }
+
+    @Test
+    public void assignToKeyword01() throws Exception {
+        checkSyntaxErrorMessage("True = 1", "SyntaxError: can't assign to keyword");
+    }
 }

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/parser/ParserTestBase.java

@@ -59,6 +59,7 @@
 import java.nio.CharBuffer;
 import java.util.Arrays;
 import java.util.List;
+import org.junit.Assert;
 import static org.junit.Assert.assertTrue;
 import org.junit.Rule;
 import org.junit.rules.TestName;
@@ -149,6 +150,18 @@ public void checkSyntaxError(String source) throws Exception {
         assertTrue("Expected SyntaxError was not thrown.", thrown);
     }
 
+    public void checkSyntaxErrorMessage(String source, String expectedMessage) throws Exception {
+        boolean thrown = false;
+        try {
+            parseNew(source, name.getMethodName(), PythonParser.ParserMode.File);
+        } catch (PException e) {
+            thrown = e.isSyntaxError();
+            Assert.assertEquals(expectedMessage, e.getMessage());
+        }
+
+        assertTrue("Expected SyntaxError was not thrown.", thrown);
+    }
+
     public void saveNewTreeResult(File testFile, boolean goldenFileNextToTestFile) throws Exception {
         assertTrue("The test files " + testFile.getAbsolutePath() + " was not found.", testFile.exists());
         TruffleFile src = context.getEnv().getInternalTruffleFile(testFile.getAbsolutePath());

graalpython/com.oracle.graal.python.test/testData/goldenFiles/NumberTests/bin01.tast

@@ -0,0 +1,9 @@
+ModuleRootNode Name: <module 'bin01'> SourceSection: [0,5]`0b101`
+  Signature: varArgs=False, varKeywordArgs=False, noArguments=True, positionalOnly=True, requiresKeywordArgs=False
+  FreeVars: None
+  NeedsCellFrame: False
+  FrameDescriptor:  Empty
+  Documentation: None
+  InnerRootNode SourceSection: [0,5]`0b101`
+    IntegerLiteralNode SourceSection: [0,5]`0b101`
+      Value: 5

graalpython/com.oracle.graal.python.test/testData/goldenFiles/NumberTests/bin02.tast

@@ -0,0 +1,9 @@
+ModuleRootNode Name: <module 'bin02'> SourceSection: [0,6]`-0b101`
+  Signature: varArgs=False, varKeywordArgs=False, noArguments=True, positionalOnly=True, requiresKeywordArgs=False
+  FreeVars: None
+  NeedsCellFrame: False
+  FrameDescriptor:  Empty
+  Documentation: None
+  InnerRootNode SourceSection: [0,6]`-0b101`
+    IntegerLiteralNode SourceSection: [0,6]`-0b101`
+      Value: -5

graalpython/com.oracle.graal.python.test/testData/goldenFiles/NumberTests/bin03.tast

@@ -0,0 +1,9 @@
+ModuleRootNode Name: <module 'bin03'> SourceSection: [0,66]`0b111111111111111111...`
+  Signature: varArgs=False, varKeywordArgs=False, noArguments=True, positionalOnly=True, requiresKeywordArgs=False
+  FreeVars: None
+  NeedsCellFrame: False
+  FrameDescriptor:  Empty
+  Documentation: None
+  InnerRootNode SourceSection: [0,66]`0b111111111111111111...`
+    PIntLiteralNode SourceSection: [0,66]`0b111111111111111111...`
+      Value: 18446744073709551615

graalpython/com.oracle.graal.python.test/testData/goldenFiles/NumberTests/complex01.tast

@@ -0,0 +1,13 @@
+ModuleRootNode Name: <module 'complex01'> SourceSection: [0,4]`0+1j`
+  Signature: varArgs=False, varKeywordArgs=False, noArguments=True, positionalOnly=True, requiresKeywordArgs=False
+  FreeVars: None
+  NeedsCellFrame: False
+  FrameDescriptor:  Empty
+  Documentation: None
+  InnerRootNode SourceSection: [0,4]`0+1j`
+    BinaryArithmeticExpression SourceSection: [0,4]`0+1j`
+      LookupAndCallBinaryNodeGen SourceSection: None
+        Op: __add__
+      IntegerLiteralNode SourceSection: [0,1]`0`
+        Value: 0
+      ComplexLiteralNode SourceSection: [2,4]`1j`

graalpython/com.oracle.graal.python.test/testData/goldenFiles/NumberTests/int01.tast

@@ -0,0 +1,9 @@
+ModuleRootNode Name: <module 'int01'> SourceSection: [0,1]`1`
+  Signature: varArgs=False, varKeywordArgs=False, noArguments=True, positionalOnly=True, requiresKeywordArgs=False
+  FreeVars: None
+  NeedsCellFrame: False
+  FrameDescriptor:  Empty
+  Documentation: None
+  InnerRootNode SourceSection: [0,1]`1`
+    IntegerLiteralNode SourceSection: [0,1]`1`
+      Value: 1

graalpython/com.oracle.graal.python.test/testData/goldenFiles/NumberTests/int02.tast

@@ -0,0 +1,9 @@
+ModuleRootNode Name: <module 'int02'> SourceSection: [0,2]`-1`
+  Signature: varArgs=False, varKeywordArgs=False, noArguments=True, positionalOnly=True, requiresKeywordArgs=False
+  FreeVars: None
+  NeedsCellFrame: False
+  FrameDescriptor:  Empty
+  Documentation: None
+  InnerRootNode SourceSection: [0,2]`-1`
+    IntegerLiteralNode SourceSection: [0,2]`-1`
+      Value: -1

graalpython/com.oracle.graal.python.test/testData/goldenFiles/NumberTests/int03.tast

@@ -0,0 +1,9 @@
+ModuleRootNode Name: <module 'int03'> SourceSection: [0,2]`-0`
+  Signature: varArgs=False, varKeywordArgs=False, noArguments=True, positionalOnly=True, requiresKeywordArgs=False
+  FreeVars: None
+  NeedsCellFrame: False
+  FrameDescriptor:  Empty
+  Documentation: None
+  InnerRootNode SourceSection: [0,2]`-0`
+    IntegerLiteralNode SourceSection: [0,2]`-0`
+      Value: 0

graalpython/com.oracle.graal.python.test/testData/goldenFiles/NumberTests/int04.tast

@@ -0,0 +1,14 @@
+ModuleRootNode Name: <module 'int04'> SourceSection: [0,7]`h == -1`
+  Signature: varArgs=False, varKeywordArgs=False, noArguments=True, positionalOnly=True, requiresKeywordArgs=False
+  FreeVars: None
+  NeedsCellFrame: False
+  FrameDescriptor:  Empty
+  Documentation: None
+  InnerRootNode SourceSection: [0,7]`h == -1`
+    BinaryComparisonNodeGen SourceSection: [0,7]`h == -1`
+      LookupAndCallBinaryNodeGen SourceSection: None
+        Op: __eq__
+      ReadNameNodeGen SourceSection: [0,1]`h`
+        Identifier: h
+      IntegerLiteralNode SourceSection: [5,7]`-1`
+        Value: -1