[GR-45300] Prefer gcc and clang when using system toolchain.

PullRequest: graalpython/2728

Author: fangerer

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/GraalPythonModuleBuiltins.java

@@ -60,15 +60,18 @@
 import static com.oracle.graal.python.util.PythonUtils.toTruffleStringUncached;
 import static com.oracle.graal.python.util.PythonUtils.tsLiteral;
 
+import java.io.File;
 import java.io.IOException;
 import java.io.InputStreamReader;
 import java.io.PrintWriter;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
 import java.util.List;
 import java.util.logging.Level;
 
-import com.oracle.truffle.api.dsl.Bind;
-import com.oracle.truffle.api.nodes.Node;
 import org.graalvm.nativeimage.ImageInfo;
 
 import com.oracle.graal.python.PythonLanguage;
@@ -105,7 +108,6 @@
 import com.oracle.graal.python.builtins.objects.type.TypeNodes.CreateTypeNode;
 import com.oracle.graal.python.lib.PyObjectCallMethodObjArgs;
 import com.oracle.graal.python.lib.PyObjectGetItem;
-import com.oracle.graal.python.lib.PyObjectTypeCheck;
 import com.oracle.graal.python.nodes.ErrorMessages;
 import com.oracle.graal.python.nodes.builtins.FunctionNodes.GetCallTargetNode;
 import com.oracle.graal.python.nodes.bytecode.PBytecodeRootNode;
@@ -131,11 +133,13 @@
 import com.oracle.graal.python.runtime.sequence.storage.SequenceStorage;
 import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.CallTarget;
+import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.TruffleFile;
 import com.oracle.truffle.api.TruffleLanguage.Env;
 import com.oracle.truffle.api.TruffleLogger;
+import com.oracle.truffle.api.dsl.Bind;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Cached.Shared;
 import com.oracle.truffle.api.dsl.Fallback;
@@ -150,6 +154,7 @@
 import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.library.CachedLibrary;
 import com.oracle.truffle.api.nodes.LanguageInfo;
+import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.nodes.NodeUtil;
 import com.oracle.truffle.api.nodes.RootNode;
 import com.oracle.truffle.api.source.Source;
@@ -631,14 +636,62 @@ protected Object getToolPath(TruffleString tool) {
         }
     }
 
-    // Equivalent of PyObject_TypeCheck
-    @Builtin(name = "type_check", minNumOfPositionalArgs = 2)
+    @Builtin(name = "determine_system_toolchain", maxNumOfPositionalArgs = 1)
     @GenerateNodeFactory
-    public abstract static class TypeCheckNode extends PythonBinaryBuiltinNode {
+    public abstract static class DetermineSystemToolchain extends PythonUnaryBuiltinNode {
+        /**
+         * This is derived from {@code distutils.unixccompiler._is_gcc}
+         */
+        private static final String[] C_COMPILER_PRECEDENCE = {"gcc", "clang"};
+        private static final String[] CXX_COMPILER_PRECEDENCE = {"g++", "clang++"};
+
+        private static final PKeyword[] GENERIC_TOOLCHAIN = {
+                        new PKeyword(tsLiteral("CC"), tsLiteral("cc")),
+                        new PKeyword(tsLiteral("CXX"), tsLiteral("c++")),
+                        new PKeyword(tsLiteral("AR"), tsLiteral("ar")),
+                        new PKeyword(tsLiteral("RANLIB"), tsLiteral("ranlib")),
+                        new PKeyword(tsLiteral("LD"), tsLiteral("ld")),
+                        new PKeyword(tsLiteral("NM"), tsLiteral("nm"))
+        };
+
         @Specialization
-        boolean typeCheck(Object instance, Object cls,
-                        @Cached PyObjectTypeCheck typeCheckNode) {
-            return typeCheckNode.execute(instance, cls);
+        PDict doGeneric(@SuppressWarnings("unused") Object unused) {
+            return factory().createDict(fromToolchain());
+        }
+
+        @TruffleBoundary
+        private static PKeyword[] fromToolchain() {
+            PKeyword[] result = GENERIC_TOOLCHAIN;
+            int id = which();
+            if (id >= 0) {
+                assert id < C_COMPILER_PRECEDENCE.length;
+                result = Arrays.copyOf(GENERIC_TOOLCHAIN, GENERIC_TOOLCHAIN.length);
+                result[0] = new PKeyword(tsLiteral("CC"), tsLiteral(C_COMPILER_PRECEDENCE[id]));
+                result[1] = new PKeyword(tsLiteral("CXX"), tsLiteral(CXX_COMPILER_PRECEDENCE[id]));
+            }
+            return result;
+        }
+
+        private static int which() {
+            CompilerAsserts.neverPartOfCompilation();
+            String path = System.getenv("PATH");
+            if (path != null) {
+                for (int i = 0; i < C_COMPILER_PRECEDENCE.length; i++) {
+                    int last = 0;
+                    for (int j = path.indexOf(File.pathSeparatorChar); j != -1; j = path.indexOf(File.pathSeparatorChar, last)) {
+                        Path resolvedProgramName = Paths.get(path.substring(last, j)).resolve(C_COMPILER_PRECEDENCE[i]);
+                        if (Files.isExecutable(resolvedProgramName)) {
+                            return i;
+                        }
+                        /*
+                         * next start is the char after the separator because we have "path0:path1"
+                         * and 'i' points to ':'
+                         */
+                        last = j + 1;
+                    }
+                }
+            }
+            return -1;
         }
     }
 
@@ -662,7 +715,7 @@ static long doIt(@SuppressWarnings("unused") Object dummy) {
         }
     }
 
-    // Internal builtin used for testing: changes strategy of newly allocated set or map
+// Internal builtin used for testing: changes strategy of newly allocated set or map
     @Builtin(name = "set_storage_strategy", minNumOfPositionalArgs = 2)
     @GenerateNodeFactory
     public abstract static class SetStorageStrategyNode extends PythonBinaryBuiltinNode {

graalpython/lib-graalpython/_sysconfig.py

@@ -56,8 +56,7 @@ def _get_posix_vars():
 
     use_system_toolchain = __graalpython__.use_system_toolchain
     if use_system_toolchain:
-        def get_toolchain(name):
-            return dict(CC='cc',CXX='c++',AR='ar',RANLIB='ranlib',LD='ld',NM='nm')[name]
+        get_toolchain = __graalpython__.determine_system_toolchain().get
     else:
         get_toolchain = __graalpython__.get_toolchain_tool_path